Skip to content

Conversation

@airborne12
Copy link
Member

@airborne12 airborne12 commented Nov 8, 2024

What problem does this PR solve?

Related PR: #41625

Problem Summary:
Fix coredump when doing segcompaction after refactor of inverted index file writer.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@airborne12
Copy link
Member Author

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.90% (9864/26026)
Line Coverage: 29.07% (82064/282338)
Region Coverage: 28.28% (42264/149427)
Branch Coverage: 24.85% (21434/86244)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a497292dae4581f8a9cd59c2241613f40c3c77c5_a497292dae4581f8a9cd59c2241613f40c3c77c5/report/index.html

@airborne12
Copy link
Member Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@csun5285 csun5285 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@airborne12
Copy link
Member Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.94% (9875/26029)
Line Coverage: 29.11% (82331/282790)
Region Coverage: 28.26% (42378/149942)
Branch Coverage: 24.81% (21462/86496)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ff1a9ff5dfe3a0f9959b1732e992089c9f036877_ff1a9ff5dfe3a0f9959b1732e992089c9f036877/report/index.html

Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 11, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@airborne12 airborne12 merged commit 14084ee into apache:master Nov 11, 2024
@airborne12 airborne12 deleted the fix-segcompaction branch November 11, 2024 06:37
github-actions bot pushed a commit that referenced this pull request Nov 11, 2024
…e in segment compaction (#43477)

Related PR: #41625

Problem Summary:
Fix coredump when doing segcompaction after refactor of inverted index
file writer.

Co-authored-by: airborne12 <jiangkai@selectdb.com>
@shuke987 shuke987 added the p0_c label Nov 11, 2024
airborne12 added a commit to airborne12/apache-doris that referenced this pull request Nov 11, 2024
…e in segment compaction (apache#43477)

Related PR: apache#41625

Problem Summary:
Fix coredump when doing segcompaction after refactor of inverted index
file writer.

Co-authored-by: airborne12 <jiangkai@selectdb.com>
airborne12 added a commit that referenced this pull request Nov 11, 2024
…e in segment compaction #43477 (#43587)

cherry pick from #43477

Co-authored-by: airborne12 <jiangkai@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.3-merged p0_c reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants