Skip to content

[fix](segcompaction) fix coredump for inverted index file writer close in segment compaction #43477 #43587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
airborne12 merged 1 commit into from
Nov 11, 2024
Merged

[fix](segcompaction) fix coredump for inverted index file writer close in segment compaction #43477 #43587

airborne12 merged 1 commit into from
Nov 11, 2024

Conversation

@airborne12
Copy link
Member

@airborne12 airborne12 commented Nov 11, 2024

cherry pick from #43477

@airborne12
Copy link
Member Author

airborne12 commented Nov 11, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Nov 11, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024

clang-tidy review says "All clean, LGTM! 👍"

@airborne12
[fix](segcompaction) fix coredump for inverted index file writer clos…
7662bbd 
…e in segment compaction (apache#43477)

Related PR: apache#41625

Problem Summary:
Fix coredump when doing segcompaction after refactor of inverted index
file writer.

Co-authored-by: airborne12 <jiangkai@selectdb.com>
@airborne12 airborne12 force-pushed the pick_43477_to_origin_branch-3.0 branch from 2e10b68 to 7662bbd Compare November 11, 2024 12:32
@airborne12
Copy link
Member Author

airborne12 commented Nov 11, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024

clang-tidy review says "All clean, LGTM! 👍"

@airborne12 airborne12 merged commit 014b709 into apache:branch-3.0 Nov 11, 2024
@airborne12 airborne12 deleted the pick_43477_to_origin_branch-3.0 branch November 11, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@airborne12 @doris-robot