Skip to content

[opt](Variant) avoid unnecessary mem for variant extracted columns #43567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eldenmoon merged 1 commit into from
Nov 11, 2024
Merged

[opt](Variant) avoid unnecessary mem for variant extracted columns #43567

eldenmoon merged 1 commit into from
Nov 11, 2024

Conversation

@eldenmoon
Copy link
Member

@eldenmoon eldenmoon commented Nov 11, 2024 •
edited
Loading

What problem does this PR solve?

_field_name_to_index and _field_id_to_index is unnecessary for variant subcolumns, since they use column path as identifier

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

doris-robot commented Nov 11, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@eldenmoon
Copy link
Member Author

eldenmoon commented Nov 11, 2024

run buildall

@eldenmoon
Copy link
Member Author

eldenmoon commented Nov 11, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Nov 11, 2024

TeamCity be ut coverage result:
Function Coverage: 37.91% (9866/26027)
Line Coverage: 29.08% (82241/282779)
Region Coverage: 28.24% (42340/149931)
Branch Coverage: 24.78% (21436/86494)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e1abab7a261a636e7858a3edb43654544e056e98_e1abab7a261a636e7858a3edb43654544e056e98/report/index.html

csun5285
csun5285 approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@csun5285 csun5285 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024

PR approved by anyone and no changes requested.

qidaye
qidaye approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 11, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024

PR approved by at least one committer and no changes requested.

@eldenmoon eldenmoon merged commit 7319d84 into apache:master Nov 11, 2024
@eldenmoon eldenmoon deleted the var_ext-mem branch November 11, 2024 09:39
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Nov 11, 2024
@eldenmoon
[opt](Variant) avoid unnecessary mem for variant extracted columns (a…
490c38e 
…pache#43567)

_field_name_to_index and _field_id_to_index is unnecessary for variant
subcolumns, since they use column path as identifier
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Nov 11, 2024
@eldenmoon
[opt](Variant) avoid unnecessary mem for variant extracted columns (a…
0fd9050 
…pache#43567)

_field_name_to_index and _field_id_to_index is unnecessary for variant
subcolumns, since they use column path as identifier
@eldenmoon eldenmoon mentioned this pull request Nov 11, 2024
Merged
eldenmoon added a commit that referenced this pull request Nov 11, 2024
@eldenmoon
[opt](Variant) avoid unnecessary mem for variant extracted columns (#…
ff6ec6c 
…43567) (#43620)

(#43567)

Co-authored-by: eldenmoon <lihangyu@selectdb.com>
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Nov 26, 2024
@eldenmoon
[opt](Variant) avoid unnecessary mem for variant extracted columns (a…
dcb70e0 
…pache#43567)

_field_name_to_index and _field_id_to_index is unnecessary for variant
subcolumns, since they use column path as identifier
@eldenmoon eldenmoon mentioned this pull request Nov 26, 2024
Merged
@gavinchou gavinchou mentioned this pull request Nov 26, 2024
Closed
yiguolei pushed a commit that referenced this pull request Nov 26, 2024
@eldenmoon
[opt](Variant) avoid unnecessary mem for variant extracted columns (#… (
f88a816 
#44585)

cherry-pick from #43567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qidaye qidaye qidaye approved these changes

+1 more reviewer

@csun5285 csun5285 csun5285 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dev/2.1.8-merged dev/3.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eldenmoon @doris-robot @qidaye @csun5285 @yiguolei