Skip to content

[opt](Variant) avoid unnecessary mem for variant extracted columns (#… #44585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Nov 26, 2024
Merged

[opt](Variant) avoid unnecessary mem for variant extracted columns (#… #44585

yiguolei merged 1 commit into from
Nov 26, 2024

Conversation

@eldenmoon
Copy link
Member

@eldenmoon eldenmoon commented Nov 26, 2024

cherry-pick from #43567

@eldenmoon
[opt](Variant) avoid unnecessary mem for variant extracted columns (a…
dcb70e0 
…pache#43567)

_field_name_to_index and _field_id_to_index is unnecessary for variant
subcolumns, since they use column path as identifier
@doris-robot
Copy link

doris-robot commented Nov 26, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@eldenmoon
Copy link
Member Author

eldenmoon commented Nov 26, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Nov 26, 2024

TeamCity be ut coverage result:
Function Coverage: 36.73% (9604/26145)
Line Coverage: 28.14% (79007/280774)
Region Coverage: 26.82% (40597/151393)
Branch Coverage: 23.64% (20652/87378)
Coverage Report: http://coverage.selectdb-in.cc/coverage/dcb70e053bb1f04f52f69b725fce28b2cbe01698_dcb70e053bb1f04f52f69b725fce28b2cbe01698/report/index.html

@yiguolei yiguolei merged commit f88a816 into apache:branch-2.1 Nov 26, 2024
12 of 13 checks passed
@yiguolei yiguolei mentioned this pull request Jan 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eldenmoon @doris-robot @yiguolei