Skip to content

[fix](Nereids) fold const return type does not matched with type coercion #44022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Nov 18, 2024
Merged

[fix](Nereids) fold const return type does not matched with type coercion #44022

morrySnow merged 1 commit into from
Nov 18, 2024

Conversation

@LiBinfeng-01
Copy link
Contributor

@LiBinfeng-01 LiBinfeng-01 commented Nov 15, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #44021

Related PR: #40744
Problem Summary:
when executing floor(1) it would castTo decimalV3(3,0) because it need (3,0) to contain it's message.
But after fold const, it lost precision(3) because decimalV3 literal class does not have mechanism to save precision
Solved: after folding constant, we need to change result type to the type we wanted

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

doris-robot commented Nov 15, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@LiBinfeng-01
Copy link
Contributor Author

LiBinfeng-01 commented Nov 15, 2024

run buildall

1 similar comment
@LiBinfeng-01
Copy link
Contributor Author

LiBinfeng-01 commented Nov 15, 2024

run buildall

@morrySnow morrySnow closed this Nov 16, 2024
@LiBinfeng-01 LiBinfeng-01 reopened this Nov 16, 2024
@LiBinfeng-01
Copy link
Contributor Author

LiBinfeng-01 commented Nov 16, 2024

run buildall

1 similar comment
@LiBinfeng-01
Copy link
Contributor Author

LiBinfeng-01 commented Nov 17, 2024

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 18, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 7e4cf07 into apache:master Nov 18, 2024
github-actions bot pushed a commit that referenced this pull request Nov 18, 2024
[fix](Nereids) fold const return type does not matched with type coer…
dd5da09 
…cion (#44022)

Related PR: #40744 

when executing floor(1) it would castTo decimalV3(3,0) because it need
(3,0) to contain it's message.
But after fold const, it lost precision(3) because decimalV3 literal
class does not have mechanism to save precision
Solved: after folding constant, we need to change result type to the
type we wanted
@github-actions github-actions bot mentioned this pull request Nov 18, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Nov 18, 2024
[fix](Nereids) fold const return type does not matched with type coer…
d986b9b 
…cion (#44022)

Related PR: #40744 

when executing floor(1) it would castTo decimalV3(3,0) because it need
(3,0) to contain it's message.
But after fold const, it lost precision(3) because decimalV3 literal
class does not have mechanism to save precision
Solved: after folding constant, we need to change result type to the
type we wanted
@github-actions github-actions bot mentioned this pull request Nov 18, 2024
Merged
morrySnow pushed a commit that referenced this pull request Nov 18, 2024
@github-actions
branch-3.0: [fix](Nereids) fold const return type does not matched wi…
2aa1fa2 
…th type coercion #44022 (#44139)

Cherry-picked from #44022

Co-authored-by: LiBinfeng <libinfeng@selectdb.com>
morrySnow pushed a commit that referenced this pull request Nov 18, 2024
@github-actions
branch-2.1: [fix](Nereids) fold const return type does not matched wi…
b01b202 
…th type coercion #44022 (#44141)

Cherry-picked from #44022

Co-authored-by: LiBinfeng <libinfeng@selectdb.com>
GoGoWen pushed a commit to GoGoWen/incubator-doris that referenced this pull request Sep 26, 2025
fix(Nereids): fold const return type does not matched with type coerc…
5d422b1 
…ion apache#44022 (apache#44141)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@englefly englefly englefly approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] floor(1) can not work in cte

5 participants

@LiBinfeng-01 @doris-robot @englefly @morrySnow @dataroaring