Skip to content

branch-3.0: [fix](Nereids) fold const return type does not matched with type coercion #44022 #44139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Nov 18, 2024
Merged

branch-3.0: [fix](Nereids) fold const return type does not matched with type coercion #44022 #44139

morrySnow merged 1 commit into from
Nov 18, 2024

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 18, 2024

Cherry-picked from #44022

[fix](Nereids) fold const return type does not matched with type coer…
dd5da09 
…cion (#44022)

Related PR: #40744 

when executing floor(1) it would castTo decimalV3(3,0) because it need
(3,0) to contain it's message.
But after fold const, it lost precision(3) because decimalV3 literal
class does not have mechanism to save precision
Solved: after folding constant, we need to change result type to the
type we wanted
@doris-robot
Copy link

doris-robot commented Nov 18, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Nov 18, 2024
@doris-robot
Copy link

doris-robot commented Nov 18, 2024

run buildall

@LiBinfeng-01 LiBinfeng-01 self-assigned this Nov 18, 2024
@morrySnow morrySnow merged commit 2aa1fa2 into branch-3.0 Nov 18, 2024
@morrySnow morrySnow deleted the auto-pick-44022-branch-3.0 branch November 18, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@LiBinfeng-01 LiBinfeng-01

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@doris-robot @LiBinfeng-01 @dataroaring @morrySnow