Skip to content

Conversation

@hust-hhb
Copy link
Contributor

What problem does this PR solve?

Related PR: #40204

Problem Summary:
There is some implicit conversion loses like uint64_t to uint32_t on mow code, this pr fix it.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hust-hhb
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 21, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.04% (9902/26033)
Line Coverage: 29.21% (82817/283514)
Region Coverage: 28.34% (42541/150083)
Branch Coverage: 24.90% (21564/86590)
Coverage Report: http://coverage.selectdb-in.cc/coverage/61069bea820b88c05415c8c494771be4746f501a_61069bea820b88c05415c8c494771be4746f501a/report/index.html

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
Copy link
Contributor

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.31% (9979/26049)
Line Coverage: 29.42% (83511/283827)
Region Coverage: 28.59% (42981/150360)
Branch Coverage: 25.16% (21829/86746)
Coverage Report: http://coverage.selectdb-in.cc/coverage/30f579ddf3df36bb6dd40fb1b8131f3b15112195_30f579ddf3df36bb6dd40fb1b8131f3b15112195/report/index.html

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 09daf06 into apache:master Nov 26, 2024
2 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 26, 2024
…ode (#44410)


Related PR: #40204

Problem Summary:
There is some implicit conversion loses like uint64_t to uint32_t on mow
code, this pr fix it.
dataroaring pushed a commit that referenced this pull request Dec 3, 2024
…omplie mow code #44410 (#44644)

Cherry-picked from #44410

Co-authored-by: huanghaibin <huanghaibin@selectdb.com>
dataroaring pushed a commit that referenced this pull request Dec 6, 2024
Related PR: #44410

Problem Summary:
Add code check for some mow code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants