Skip to content

Conversation

@hust-hhb
Copy link
Contributor

What problem does this PR solve?

Related PR: #44410

Problem Summary:
Add code check for some mow code

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hust-hhb
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40303 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fce0e3e0708297a4845ae55d5853e16d164de53b, data reload: false

------ Round 1 ----------------------------------
q1	17596	7497	7322	7322
q2	2038	168	178	168
q3	10570	1109	1202	1109
q4	10395	739	691	691
q5	7622	2779	2736	2736
q6	245	152	153	152
q7	987	651	607	607
q8	9231	1907	1904	1904
q9	6659	6471	6512	6471
q10	7008	2330	2311	2311
q11	466	264	279	264
q12	433	218	224	218
q13	17771	3002	3034	3002
q14	253	213	217	213
q15	572	514	526	514
q16	650	578	580	578
q17	981	570	603	570
q18	7324	6669	6749	6669
q19	1373	1017	1072	1017
q20	467	178	174	174
q21	4244	3316	3301	3301
q22	380	324	312	312
Total cold run time: 107265 ms
Total hot run time: 40303 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7244	7252	7230	7230
q2	321	225	223	223
q3	2961	2827	2929	2827
q4	2038	1829	1817	1817
q5	5697	5696	5775	5696
q6	225	149	145	145
q7	2306	1818	1833	1818
q8	3446	3620	3551	3551
q9	8832	8991	8978	8978
q10	3627	3573	3620	3573
q11	593	522	519	519
q12	836	595	584	584
q13	11274	3286	3218	3218
q14	325	279	270	270
q15	573	502	524	502
q16	707	647	637	637
q17	1885	1631	1644	1631
q18	8431	7792	7887	7792
q19	1713	1617	1651	1617
q20	2141	1912	1891	1891
q21	5556	5392	5357	5357
q22	626	557	556	556
Total cold run time: 71357 ms
Total hot run time: 60432 ms

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-DS: Total hot run time: 197439 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fce0e3e0708297a4845ae55d5853e16d164de53b, data reload: false

query1	1243	951	926	926
query2	6257	2216	2178	2178
query3	10788	4023	3882	3882
query4	68066	27600	23569	23569
query5	4962	467	462	462
query6	410	188	177	177
query7	5556	295	300	295
query8	329	227	215	215
query9	8583	2694	2673	2673
query10	442	254	239	239
query11	17173	15253	15903	15253
query12	155	99	105	99
query13	1456	433	418	418
query14	10558	7496	7930	7496
query15	205	186	185	185
query16	7132	475	493	475
query17	1087	596	600	596
query18	2000	308	297	297
query19	202	160	158	158
query20	125	125	116	116
query21	206	106	106	106
query22	4883	4501	4426	4426
query23	34857	34236	34365	34236
query24	5477	2469	2635	2469
query25	496	397	401	397
query26	661	155	145	145
query27	2038	282	288	282
query28	4717	2524	2501	2501
query29	686	427	416	416
query30	211	152	162	152
query31	1011	842	872	842
query32	66	55	59	55
query33	422	281	285	281
query34	962	519	547	519
query35	856	775	754	754
query36	1087	974	953	953
query37	130	71	74	71
query38	4495	4370	4363	4363
query39	1530	1462	1487	1462
query40	198	106	119	106
query41	45	43	41	41
query42	110	101	99	99
query43	570	490	513	490
query44	1227	870	862	862
query45	184	169	170	169
query46	1163	704	694	694
query47	2048	1949	1927	1927
query48	424	328	317	317
query49	752	387	401	387
query50	849	407	410	407
query51	7445	7292	7144	7144
query52	97	87	87	87
query53	258	178	175	175
query54	528	402	403	402
query55	78	74	74	74
query56	256	244	238	238
query57	1332	1174	1129	1129
query58	216	210	214	210
query59	3264	3152	3221	3152
query60	267	253	238	238
query61	144	106	106	106
query62	827	677	670	670
query63	211	189	189	189
query64	1412	650	630	630
query65	3275	3287	3230	3230
query66	704	320	308	308
query67	16165	16068	15720	15720
query68	3853	577	568	568
query69	424	261	249	249
query70	1225	1139	1135	1135
query71	348	251	245	245
query72	6389	4029	4030	4029
query73	780	361	365	361
query74	10259	8955	9170	8955
query75	3415	2683	2673	2673
query76	1729	1080	1125	1080
query77	512	263	282	263
query78	10584	9506	9446	9446
query79	2179	603	594	594
query80	1401	417	421	417
query81	530	234	227	227
query82	1079	114	117	114
query83	197	153	152	152
query84	279	69	72	69
query85	1005	292	372	292
query86	392	305	293	293
query87	4811	4561	4497	4497
query88	3683	2288	2265	2265
query89	427	306	291	291
query90	2004	194	189	189
query91	145	109	101	101
query92	63	51	50	50
query93	2741	559	557	557
query94	826	291	286	286
query95	342	248	243	243
query96	641	283	290	283
query97	2905	2728	2687	2687
query98	214	198	194	194
query99	1624	1294	1325	1294
Total cold run time: 322575 ms
Total hot run time: 197439 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.51 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fce0e3e0708297a4845ae55d5853e16d164de53b, data reload: false

query1	0.04	0.03	0.03
query2	0.06	0.02	0.04
query3	0.23	0.07	0.07
query4	1.62	0.11	0.11
query5	0.42	0.40	0.41
query6	1.16	0.66	0.65
query7	0.03	0.01	0.02
query8	0.04	0.04	0.03
query9	0.58	0.50	0.50
query10	0.55	0.56	0.56
query11	0.14	0.09	0.11
query12	0.13	0.12	0.11
query13	0.61	0.60	0.60
query14	2.70	2.77	2.74
query15	0.89	0.82	0.83
query16	0.39	0.38	0.39
query17	1.09	1.08	1.09
query18	0.22	0.21	0.21
query19	1.89	1.87	2.02
query20	0.01	0.01	0.01
query21	15.35	0.60	0.60
query22	2.31	2.43	2.01
query23	17.05	0.93	0.83
query24	2.83	1.47	1.60
query25	0.22	0.16	0.16
query26	0.60	0.13	0.13
query27	0.04	0.05	0.04
query28	10.05	1.10	1.07
query29	12.57	3.23	3.21
query30	0.24	0.06	0.07
query31	2.86	0.38	0.38
query32	3.29	0.47	0.47
query33	3.02	3.08	3.05
query34	17.05	4.50	4.46
query35	4.49	4.57	4.48
query36	0.67	0.49	0.51
query37	0.08	0.06	0.06
query38	0.05	0.04	0.04
query39	0.04	0.02	0.03
query40	0.16	0.13	0.12
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 105.9 s
Total hot run time: 33.51 s

zhannngchen
zhannngchen previously approved these changes Dec 3, 2024
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hust-hhb
Copy link
Contributor Author

hust-hhb commented Dec 4, 2024

run buildall

@hust-hhb
Copy link
Contributor Author

hust-hhb commented Dec 4, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40007 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 17c0f0f59b42deedc68690337eae5b9a40d7a868, data reload: false

------ Round 1 ----------------------------------
q1	17609	7585	7265	7265
q2	2054	177	171	171
q3	10663	1121	1208	1121
q4	10577	745	699	699
q5	7625	2773	2685	2685
q6	245	147	144	144
q7	1013	632	589	589
q8	9257	1878	1898	1878
q9	6679	6637	6531	6531
q10	6965	2307	2278	2278
q11	454	260	255	255
q12	427	226	225	225
q13	17796	3012	3012	3012
q14	244	213	209	209
q15	566	529	523	523
q16	632	583	576	576
q17	993	545	557	545
q18	7471	6673	6934	6673
q19	1354	998	1048	998
q20	480	178	179	178
q21	4192	3267	3132	3132
q22	375	320	322	320
Total cold run time: 107671 ms
Total hot run time: 40007 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7296	7228	7245	7228
q2	330	234	230	230
q3	2913	2876	2993	2876
q4	2107	1937	1947	1937
q5	5658	5665	5656	5656
q6	226	136	138	136
q7	2280	1808	1827	1808
q8	3377	3576	3572	3572
q9	8920	8980	8999	8980
q10	3624	3561	3579	3561
q11	594	496	500	496
q12	801	641	607	607
q13	13003	3263	3205	3205
q14	307	274	288	274
q15	583	517	519	517
q16	696	639	632	632
q17	1896	1661	1619	1619
q18	8245	7762	7796	7762
q19	1688	1603	1583	1583
q20	2102	1904	1929	1904
q21	5680	5467	5451	5451
q22	654	609	570	570
Total cold run time: 72980 ms
Total hot run time: 60604 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197558 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 17c0f0f59b42deedc68690337eae5b9a40d7a868, data reload: false

query1	1249	961	906	906
query2	6246	2023	1983	1983
query3	11062	4412	4545	4412
query4	67113	29393	23598	23598
query5	5032	502	455	455
query6	436	192	175	175
query7	5523	316	310	310
query8	332	255	222	222
query9	8876	2760	2734	2734
query10	442	247	245	245
query11	17126	15366	15808	15366
query12	153	100	104	100
query13	1449	405	411	405
query14	10842	7056	7656	7056
query15	221	189	193	189
query16	7398	492	489	489
query17	1104	602	605	602
query18	1912	320	306	306
query19	208	158	159	158
query20	118	115	114	114
query21	212	107	105	105
query22	4804	4601	4480	4480
query23	35679	34280	34462	34280
query24	5388	2498	2457	2457
query25	495	417	405	405
query26	673	153	154	153
query27	1971	293	287	287
query28	4299	2546	2495	2495
query29	675	426	422	422
query30	214	163	152	152
query31	1000	845	834	834
query32	70	56	55	55
query33	453	297	288	288
query34	928	506	540	506
query35	894	779	754	754
query36	1089	972	985	972
query37	118	76	70	70
query38	4608	4407	4468	4407
query39	1515	1482	1454	1454
query40	206	106	101	101
query41	49	42	44	42
query42	121	99	98	98
query43	532	495	495	495
query44	1164	827	823	823
query45	193	178	174	174
query46	1173	744	723	723
query47	2063	1954	1955	1954
query48	427	319	349	319
query49	726	399	399	399
query50	866	405	388	388
query51	7414	7184	7190	7184
query52	98	87	94	87
query53	246	183	180	180
query54	510	398	385	385
query55	74	78	84	78
query56	255	240	224	224
query57	1286	1137	1126	1126
query58	221	212	220	212
query59	3221	3056	3137	3056
query60	275	243	243	243
query61	110	109	107	107
query62	843	691	656	656
query63	211	195	178	178
query64	1497	695	623	623
query65	3295	3177	3220	3177
query66	730	295	304	295
query67	16102	15712	15684	15684
query68	3893	594	560	560
query69	443	249	254	249
query70	1220	1146	1166	1146
query71	342	247	249	247
query72	6376	4077	4032	4032
query73	762	354	357	354
query74	10271	9083	9010	9010
query75	3379	2691	2681	2681
query76	1907	1106	1130	1106
query77	476	279	316	279
query78	10550	9389	9523	9389
query79	1391	593	584	584
query80	899	426	442	426
query81	498	226	232	226
query82	1271	123	118	118
query83	250	146	139	139
query84	279	71	68	68
query85	920	370	291	291
query86	335	306	300	300
query87	4731	4712	4569	4569
query88	3400	2241	2180	2180
query89	415	295	284	284
query90	1995	192	186	186
query91	135	104	107	104
query92	61	51	49	49
query93	1941	540	537	537
query94	769	295	292	292
query95	344	247	241	241
query96	630	281	276	276
query97	2855	2729	2705	2705
query98	223	206	199	199
query99	1657	1335	1319	1319
Total cold run time: 320453 ms
Total hot run time: 197558 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.47% (10006/26008)
Line Coverage: 29.52% (83905/284217)
Region Coverage: 28.62% (43112/150636)
Branch Coverage: 25.22% (21918/86904)
Coverage Report: http://coverage.selectdb-in.cc/coverage/17c0f0f59b42deedc68690337eae5b9a40d7a868_17c0f0f59b42deedc68690337eae5b9a40d7a868/report/index.html

@doris-robot
Copy link

ClickBench: Total hot run time: 33.06 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 17c0f0f59b42deedc68690337eae5b9a40d7a868, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.63	0.11	0.11
query5	0.44	0.42	0.40
query6	1.17	0.66	0.66
query7	0.02	0.01	0.01
query8	0.04	0.03	0.04
query9	0.58	0.51	0.49
query10	0.56	0.56	0.56
query11	0.14	0.10	0.10
query12	0.14	0.12	0.12
query13	0.61	0.60	0.60
query14	2.75	2.84	2.85
query15	0.91	0.82	0.82
query16	0.38	0.39	0.37
query17	1.05	0.96	1.05
query18	0.23	0.20	0.21
query19	1.88	1.86	2.05
query20	0.02	0.01	0.02
query21	15.37	0.59	0.58
query22	2.46	1.87	2.11
query23	17.00	0.90	0.87
query24	2.82	1.15	1.88
query25	0.26	0.13	0.24
query26	0.44	0.14	0.14
query27	0.04	0.04	0.05
query28	9.99	1.10	1.07
query29	12.56	3.27	3.21
query30	0.26	0.06	0.06
query31	2.88	0.38	0.38
query32	3.31	0.46	0.46
query33	2.99	2.99	3.05
query34	16.83	4.52	4.51
query35	4.57	4.59	4.54
query36	0.67	0.48	0.50
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 105.81 s
Total hot run time: 33.06 s

@hust-hhb
Copy link
Contributor Author

hust-hhb commented Dec 5, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40234 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b5fdfa04d0227753e97e008d5cb04db59ccbd6de, data reload: false

------ Round 1 ----------------------------------
q1	17683	7528	7331	7331
q2	2072	174	165	165
q3	10638	1169	1244	1169
q4	10319	762	762	762
q5	7606	2736	2692	2692
q6	239	150	151	150
q7	1035	620	606	606
q8	9244	1908	1924	1908
q9	6755	6521	6406	6406
q10	6964	2309	2358	2309
q11	474	264	267	264
q12	431	232	225	225
q13	17807	3043	3059	3043
q14	243	205	221	205
q15	572	532	508	508
q16	665	584	589	584
q17	1001	584	556	556
q18	7487	6708	6746	6708
q19	1363	960	929	929
q20	478	180	183	180
q21	4132	3265	3223	3223
q22	386	311	316	311
Total cold run time: 107594 ms
Total hot run time: 40234 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7261	7243	7258	7243
q2	329	231	241	231
q3	2887	2825	2998	2825
q4	2062	1806	1808	1806
q5	5419	5617	5707	5617
q6	226	149	151	149
q7	2195	1798	1786	1786
q8	3361	3568	3523	3523
q9	9019	9055	9060	9055
q10	3622	3549	3559	3549
q11	622	494	515	494
q12	820	614	620	614
q13	12143	3287	3285	3285
q14	317	277	284	277
q15	565	515	522	515
q16	706	644	694	644
q17	1889	1606	1596	1596
q18	8256	7700	7690	7690
q19	1721	1568	1516	1516
q20	2133	1875	1940	1875
q21	5640	5489	5442	5442
q22	633	577	580	577
Total cold run time: 71826 ms
Total hot run time: 60309 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191300 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b5fdfa04d0227753e97e008d5cb04db59ccbd6de, data reload: false

query1	1162	378	389	378
query2	6512	2048	1980	1980
query3	6709	222	209	209
query4	33626	23815	23580	23580
query5	4328	466	462	462
query6	308	190	193	190
query7	4629	315	328	315
query8	291	230	222	222
query9	9555	2715	2695	2695
query10	463	249	250	249
query11	18155	15211	15298	15211
query12	157	100	104	100
query13	1672	440	401	401
query14	10214	7125	6638	6638
query15	275	188	181	181
query16	8099	473	442	442
query17	1687	613	581	581
query18	2324	332	309	309
query19	245	159	162	159
query20	120	115	113	113
query21	210	114	105	105
query22	4737	4468	4387	4387
query23	35573	34586	34489	34489
query24	11403	2594	2510	2510
query25	636	375	372	372
query26	1783	148	152	148
query27	2815	281	281	281
query28	7977	2425	2457	2425
query29	1024	404	422	404
query30	285	146	142	142
query31	1024	824	848	824
query32	92	52	53	52
query33	751	286	289	286
query34	966	507	534	507
query35	946	756	734	734
query36	1112	949	953	949
query37	195	79	73	73
query38	4507	4314	4238	4238
query39	1456	1400	1405	1400
query40	283	96	98	96
query41	46	40	42	40
query42	109	98	98	98
query43	563	494	489	489
query44	1260	812	797	797
query45	188	165	165	165
query46	1183	721	698	698
query47	1920	1835	1881	1835
query48	400	307	312	307
query49	1190	386	386	386
query50	827	390	394	390
query51	7290	7069	7053	7053
query52	97	91	90	90
query53	256	192	182	182
query54	1158	403	399	399
query55	80	79	79	79
query56	259	237	249	237
query57	1256	1109	1125	1109
query58	230	199	236	199
query59	3218	3059	3053	3053
query60	267	246	240	240
query61	130	107	112	107
query62	891	670	660	660
query63	210	188	181	181
query64	5071	659	631	631
query65	3281	3153	3208	3153
query66	1376	302	325	302
query67	16087	15606	15526	15526
query68	4796	562	563	562
query69	429	262	248	248
query70	1195	1140	1134	1134
query71	390	253	247	247
query72	6408	4014	4102	4014
query73	776	376	368	368
query74	10527	9136	9052	9052
query75	3521	2630	2651	2630
query76	2929	1073	1029	1029
query77	578	278	270	270
query78	10517	9469	9401	9401
query79	2409	610	609	609
query80	1069	431	443	431
query81	542	239	233	233
query82	888	119	115	115
query83	257	155	141	141
query84	261	71	70	70
query85	1394	301	293	293
query86	435	295	301	295
query87	4738	4605	4672	4605
query88	3888	2238	2172	2172
query89	410	291	305	291
query90	1999	189	188	188
query91	134	109	101	101
query92	70	51	47	47
query93	1580	547	544	544
query94	953	310	298	298
query95	348	252	256	252
query96	618	283	284	283
query97	2868	2664	2635	2635
query98	216	200	215	200
query99	1583	1306	1299	1299
Total cold run time: 305875 ms
Total hot run time: 191300 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.1 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b5fdfa04d0227753e97e008d5cb04db59ccbd6de, data reload: false

query1	0.03	0.04	0.04
query2	0.07	0.04	0.03
query3	0.24	0.07	0.06
query4	1.63	0.10	0.11
query5	0.46	0.38	0.41
query6	1.17	0.64	0.65
query7	0.01	0.02	0.01
query8	0.04	0.03	0.03
query9	0.56	0.51	0.50
query10	0.55	0.55	0.55
query11	0.15	0.10	0.10
query12	0.14	0.10	0.11
query13	0.62	0.59	0.60
query14	2.73	2.78	2.77
query15	0.91	0.84	0.82
query16	0.37	0.38	0.38
query17	1.06	0.99	1.05
query18	0.22	0.21	0.20
query19	1.97	1.90	2.04
query20	0.02	0.01	0.01
query21	15.36	0.59	0.58
query22	2.94	2.14	1.74
query23	16.82	1.09	0.87
query24	3.37	1.63	0.50
query25	0.27	0.16	0.16
query26	0.35	0.13	0.13
query27	0.04	0.04	0.04
query28	10.56	1.10	1.07
query29	12.55	3.23	3.22
query30	0.24	0.06	0.06
query31	2.88	0.38	0.38
query32	3.26	0.46	0.46
query33	2.98	3.04	3.07
query34	16.75	4.39	4.50
query35	4.49	4.50	4.47
query36	0.66	0.49	0.48
query37	0.08	0.06	0.07
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.17	0.13	0.13
query41	0.09	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.96 s
Total hot run time: 32.1 s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.48% (10007/26005)
Line Coverage: 29.49% (83879/284391)
Region Coverage: 28.60% (43111/150742)
Branch Coverage: 25.20% (21915/86978)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b5fdfa04d0227753e97e008d5cb04db59ccbd6de_b5fdfa04d0227753e97e008d5cb04db59ccbd6de/report/index.html

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 6, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

PR approved by at least one committer and no changes requested.

@dataroaring dataroaring merged commit f3aff7c into apache:master Dec 6, 2024
13 of 14 checks passed
hello-stephen pushed a commit that referenced this pull request Dec 7, 2024
### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #44439
github-actions bot pushed a commit that referenced this pull request Dec 7, 2024
### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #44439
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants