Skip to content

Conversation

@ccoffline
Copy link
Contributor

@ccoffline ccoffline commented Sep 2, 2020

Proposed changes

This commit adds git commit message of fe to the system page, just like be.
To achieve this, fe heartbeat message has now been carrying git commit message.

Types of changes

  • [] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

  • [] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • [] Compiling and unit tests pass locally with my changes
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] If this change need a document change, I have updated the document
  • [] Any dependent changes have been merged

Further comments

This is my first public pr so plzzzzzz be gentle, thx=.=

@kangkaisen
Copy link
Contributor

@ccoffline Hi, Thanks for your contribution.

This commit adds git commit message of fe to the system page, just like be.

If we only want to show a git commit message on FE web, why do we need to add a commit message to the heartbeat?

@ccoffline
Copy link
Contributor Author

@ccoffline Hi, Thanks for your contribution.

This commit adds git commit message of fe to the system page, just like be.

If we only want to show a git commit message on FE web, why do we need to add a commit message to the heartbeat?t

FE web shows status of each BE and FE by represent the message from the heartbeat.
The BE Version has been shown on the web and it is carried by the BE heartbeat.
I use the same implementation as BE.

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the approved Indicates a PR has been approved by one committer. label Sep 5, 2020
@morningman morningman merged commit 81aa1c5 into apache:branch-0.12 Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. good first issue kind/improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants