Skip to content

Conversation

@ccoffline
Copy link
Contributor

@ccoffline ccoffline commented Nov 24, 2020

Proposed changes

as #4521

This commit adds git commit message of FE to the system page, just like BE.

In addition, It shows commit message on mysql connection.

Types of changes

  • [] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

  • [] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • [] If this change need a document change, I have updated the document
  • Any dependent changes have been merged

@ccoffline ccoffline changed the title [Feature] Show fe commit hash on proc [Feature] Show FE commit hash on proc Nov 24, 2020
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added approved Indicates a PR has been approved by one committer. kind/improvement labels Nov 27, 2020
@morningman morningman merged commit 3b56b60 into apache:master Nov 28, 2020
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants