Skip to content

[branch-3.0](function) fix coredump of function StDistanceSphere and StAngleSphere (#45508) #45526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhangstar333 merged 1 commit into from
Dec 25, 2024
Merged

[branch-3.0](function) fix coredump of function StDistanceSphere and StAngleSphere (#45508) #45526

zhangstar333 merged 1 commit into from
Dec 25, 2024

Conversation

@zclllyybb
Copy link
Contributor

@zclllyybb zclllyybb commented Dec 17, 2024

pick #45508

@zclllyybb
[Fix](function) fix coredump of function StDistanceSphere and StAngle…
80d95e0 
…Sphere (apache#45508)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: apache#40107

Problem Summary:

In apache#40107 we introduced a wrong
behaviour which would lead to BE crash because of dangling reference.
now fix it.

### Release note

fix BE crash of function StDistanceSphere and StAngleSphere

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [x] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@Thearas
Copy link
Contributor

Thearas commented Dec 17, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zclllyybb zclllyybb changed the title [branch-3.-](function) fix coredump of function StDistanceSphere and StAngleSphere (#45508) [branch-3.0](function) fix coredump of function StDistanceSphere and StAngleSphere (#45508) Dec 17, 2024
@zclllyybb
Copy link
Contributor Author

zclllyybb commented Dec 17, 2024

run buildall

@zhangstar333 zhangstar333 merged commit d52c555 into apache:branch-3.0 Dec 25, 2024
20 of 25 checks passed
@zclllyybb zclllyybb deleted the pick_st_30 branch December 25, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zclllyybb @Thearas @zhangstar333