Skip to content

branch-3.0: [fix](Nereids) fix cast string to date #46065 #46161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
github-actions wants to merge 1 commit into from
Closed

branch-3.0: [fix](Nereids) fix cast string to date #46065 #46161

github-actions wants to merge 1 commit into from

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Dec 30, 2024

Cherry-picked from #46065

[fix](Nereids) fix cast string to date (#46065)
d386036 
### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #35637 

Problem Summary:
When cast("201-01-01" as datetimev2(0)), The result is "2020-01-01" but
it is wrong. It should be result in "0201-01-01".
201 would be regarded as 20xy-0z as related pr show, it was a bug. But
actually it should not have this trasformation and result in
@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 30, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Dec 30, 2024
@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 30, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Dec 30, 2024

TPC-H: Total hot run time: 41229 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d386036d8074d3677ff40dd8073f8acbf9bb01c4, data reload: false

------ Round 1 ----------------------------------
q1	17579	7364	7250	7250
q2	2065	182	182	182
q3	10594	1092	1199	1092
q4	10524	687	703	687
q5	7727	2846	2830	2830
q6	233	145	144	144
q7	973	613	609	609
q8	9333	1940	1994	1940
q9	6621	6434	6382	6382
q10	7035	2309	2322	2309
q11	459	265	254	254
q12	398	212	207	207
q13	17830	3112	3137	3112
q14	255	217	217	217
q15	582	511	525	511
q16	689	647	614	614
q17	991	612	583	583
q18	7474	7107	6954	6954
q19	1393	1132	1065	1065
q20	480	209	203	203
q21	4322	3199	3112	3112
q22	1138	972	1031	972
Total cold run time: 108695 ms
Total hot run time: 41229 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7274	7255	7208	7208
q2	329	234	227	227
q3	2995	2911	2936	2911
q4	2091	1825	1756	1756
q5	5731	5695	5715	5695
q6	226	142	141	141
q7	2202	1844	1817	1817
q8	3321	3540	3447	3447
q9	8863	8923	8881	8881
q10	3610	3539	3514	3514
q11	602	497	498	497
q12	801	591	627	591
q13	10157	3164	3206	3164
q14	304	285	278	278
q15	575	534	530	530
q16	721	683	661	661
q17	1847	1624	1632	1624
q18	8222	7685	7648	7648
q19	1682	1636	1617	1617
q20	2114	1906	1873	1873
q21	5487	5414	5456	5414
q22	1137	1069	1056	1056
Total cold run time: 70291 ms
Total hot run time: 60550 ms

@doris-robot
Copy link

doris-robot commented Dec 30, 2024

TPC-DS: Total hot run time: 197519 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d386036d8074d3677ff40dd8073f8acbf9bb01c4, data reload: false

query1	1274	926	910	910
query2	6225	2061	2112	2061
query3	10807	4232	4233	4232
query4	66299	29183	23432	23432
query5	4898	439	462	439
query6	416	166	175	166
query7	5711	312	310	310
query8	306	226	233	226
query9	9421	2692	2688	2688
query10	492	284	258	258
query11	17929	15191	15663	15191
query12	157	109	103	103
query13	1540	462	432	432
query14	10963	7726	7189	7189
query15	209	178	176	176
query16	7192	519	474	474
query17	1201	598	605	598
query18	1774	328	310	310
query19	245	158	153	153
query20	120	116	117	116
query21	59	45	46	45
query22	4726	4615	4559	4559
query23	34869	34236	34427	34236
query24	6180	2961	2955	2955
query25	531	425	438	425
query26	680	167	170	167
query27	1878	309	304	304
query28	4835	2493	2481	2481
query29	691	460	452	452
query30	249	173	168	168
query31	1036	819	847	819
query32	66	51	53	51
query33	419	292	283	283
query34	941	504	509	504
query35	847	753	746	746
query36	1084	957	967	957
query37	116	71	71	71
query38	4172	3968	3946	3946
query39	1518	1486	1440	1440
query40	142	93	83	83
query41	49	46	50	46
query42	116	98	98	98
query43	528	495	507	495
query44	1202	829	844	829
query45	190	174	168	168
query46	1179	708	728	708
query47	2018	1969	1939	1939
query48	481	383	380	380
query49	724	384	395	384
query50	837	422	416	416
query51	7445	7275	7351	7275
query52	100	82	88	82
query53	245	191	177	177
query54	565	429	447	429
query55	76	73	71	71
query56	248	244	240	240
query57	1236	1110	1111	1110
query58	204	206	207	206
query59	3228	3087	3282	3087
query60	264	244	249	244
query61	106	108	106	106
query62	783	683	665	665
query63	209	191	191	191
query64	1391	666	625	625
query65	3277	3192	3245	3192
query66	702	297	307	297
query67	15953	15556	15479	15479
query68	3993	591	580	580
query69	425	273	290	273
query70	1195	1135	1133	1133
query71	362	262	248	248
query72	6459	3960	3994	3960
query73	752	351	347	347
query74	10220	8976	8952	8952
query75	3374	2637	2627	2627
query76	1822	964	998	964
query77	502	269	271	269
query78	10642	9666	9546	9546
query79	1117	599	600	599
query80	788	421	434	421
query81	524	242	240	240
query82	470	115	114	114
query83	162	153	143	143
query84	280	84	78	78
query85	843	304	287	287
query86	322	284	299	284
query87	4458	4327	4288	4288
query88	3881	2386	2348	2348
query89	403	304	285	285
query90	2016	179	186	179
query91	177	147	147	147
query92	59	46	49	46
query93	1519	557	551	551
query94	802	292	288	288
query95	354	251	256	251
query96	613	279	283	279
query97	3273	3189	3200	3189
query98	207	199	195	195
query99	1671	1329	1313	1313
Total cold run time: 319259 ms
Total hot run time: 197519 ms

@doris-robot
Copy link

doris-robot commented Dec 30, 2024

ClickBench: Total hot run time: 33.96 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d386036d8074d3677ff40dd8073f8acbf9bb01c4, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.04
query3	0.23	0.06	0.07
query4	1.62	0.11	0.10
query5	0.52	0.51	0.52
query6	1.13	0.71	0.73
query7	0.02	0.01	0.01
query8	0.04	0.04	0.04
query9	0.57	0.50	0.50
query10	0.56	0.55	0.57
query11	0.14	0.10	0.10
query12	0.14	0.12	0.10
query13	0.61	0.60	0.60
query14	2.89	3.04	3.01
query15	0.90	0.83	0.81
query16	0.39	0.39	0.38
query17	1.06	1.06	1.06
query18	0.24	0.22	0.22
query19	2.00	1.87	2.00
query20	0.01	0.01	0.01
query21	15.37	0.59	0.59
query22	2.59	2.83	3.02
query23	16.95	0.98	0.80
query24	3.29	1.06	1.59
query25	0.20	0.10	0.07
query26	0.57	0.13	0.13
query27	0.05	0.04	0.04
query28	9.77	1.11	1.06
query29	12.54	3.18	3.14
query30	0.24	0.07	0.06
query31	2.84	0.38	0.38
query32	3.26	0.46	0.47
query33	2.98	2.98	3.05
query34	17.36	4.46	4.41
query35	4.50	4.47	4.56
query36	0.67	0.49	0.47
query37	0.09	0.06	0.07
query38	0.04	0.04	0.03
query39	0.03	0.03	0.02
query40	0.17	0.13	0.13
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.83 s
Total hot run time: 33.96 s

@morrySnow morrySnow closed this Jan 14, 2025
@morrySnow morrySnow deleted the auto-pick-46065-branch-3.0 branch January 14, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hello-stephen @doris-robot @dataroaring @morrySnow