Skip to content

Conversation

@LiBinfeng-01
Copy link
Contributor

@LiBinfeng-01 LiBinfeng-01 commented Dec 27, 2024

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #35637

Problem Summary:
When cast("201-01-01" as datetimev2(0)), The result is "2020-01-01" but it is wrong. It should be result in "0201-01-01".
201 would be regarded as 20xy-0z as related pr show, it was a bug. But actually it should not have this trasformation and result in

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 27, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@LiBinfeng-01 LiBinfeng-01 force-pushed the fix_cast_string_to_date branch from 4dea898 to 8b451f1 Compare December 27, 2024 02:07
@LiBinfeng-01
Copy link
Contributor Author

run buildall

morrySnow
morrySnow previously approved these changes Dec 27, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 27, 2024
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 32559 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8b451f1de7d236a50ac840fe0a52787f6ee90d13, data reload: false

------ Round 1 ----------------------------------
q1	17565	6153	5981	5981
q2	2049	291	164	164
q3	10516	1234	737	737
q4	10232	870	430	430
q5	8203	2199	1943	1943
q6	205	183	151	151
q7	886	740	592	592
q8	9224	1338	1129	1129
q9	5235	4953	4892	4892
q10	6726	2335	1877	1877
q11	472	278	250	250
q12	349	358	221	221
q13	17803	3698	3168	3168
q14	248	237	222	222
q15	571	518	496	496
q16	629	624	603	603
q17	572	859	338	338
q18	7001	6407	6325	6325
q19	2608	957	573	573
q20	294	323	184	184
q21	2804	2120	1979	1979
q22	363	337	304	304
Total cold run time: 104555 ms
Total hot run time: 32559 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6314	6183	6204	6183
q2	233	329	235	235
q3	2236	2653	2337	2337
q4	1407	1852	1396	1396
q5	4315	4735	4859	4735
q6	185	177	145	145
q7	2075	1951	1794	1794
q8	2613	2754	2690	2690
q9	7316	7264	7361	7264
q10	3064	3394	2825	2825
q11	564	508	495	495
q12	648	788	645	645
q13	3340	3783	3129	3129
q14	288	296	284	284
q15	564	522	502	502
q16	654	670	657	657
q17	1238	1739	1247	1247
q18	7740	7555	7459	7459
q19	795	911	1114	911
q20	2008	2037	1900	1900
q21	5808	5206	4823	4823
q22	593	616	603	603
Total cold run time: 53998 ms
Total hot run time: 52259 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196980 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8b451f1de7d236a50ac840fe0a52787f6ee90d13, data reload: false

query1	1302	992	945	945
query2	6351	2430	2321	2321
query3	11136	4803	4760	4760
query4	33104	23847	23450	23450
query5	4032	601	456	456
query6	280	205	207	205
query7	3992	480	305	305
query8	292	231	246	231
query9	9549	2732	2730	2730
query10	447	297	250	250
query11	17936	15639	15264	15264
query12	166	112	104	104
query13	1564	554	401	401
query14	10060	7087	6981	6981
query15	248	230	185	185
query16	7346	618	438	438
query17	1488	756	582	582
query18	1975	395	294	294
query19	194	179	155	155
query20	123	112	118	112
query21	204	123	112	112
query22	4873	4841	4662	4662
query23	34362	33643	33645	33643
query24	6789	2373	2397	2373
query25	556	499	422	422
query26	808	274	159	159
query27	2542	466	339	339
query28	5970	2526	2511	2511
query29	647	591	483	483
query30	215	196	149	149
query31	1066	936	830	830
query32	88	60	56	56
query33	489	356	301	301
query34	779	856	512	512
query35	906	864	745	745
query36	1041	1063	954	954
query37	113	96	74	74
query38	4336	4265	4160	4160
query39	1554	1478	1457	1457
query40	216	116	98	98
query41	44	41	44	41
query42	111	98	100	98
query43	509	516	503	503
query44	1332	806	831	806
query45	186	172	172	172
query46	894	1070	671	671
query47	2010	2049	1981	1981
query48	387	408	318	318
query49	710	485	386	386
query50	644	693	409	409
query51	7251	7422	7192	7192
query52	100	101	95	95
query53	235	272	179	179
query54	482	485	421	421
query55	83	76	80	76
query56	254	253	241	241
query57	1302	1288	1168	1168
query58	257	221	227	221
query59	3250	3262	3228	3228
query60	279	272	266	266
query61	108	105	109	105
query62	875	806	766	766
query63	235	198	201	198
query64	3662	998	693	693
query65	3339	3277	3279	3277
query66	786	414	314	314
query67	16690	15946	15633	15633
query68	10239	743	485	485
query69	487	286	246	246
query70	1282	1131	1155	1131
query71	430	282	255	255
query72	5928	2709	3941	2709
query73	1362	754	375	375
query74	10445	9044	8801	8801
query75	4587	3177	2681	2681
query76	5546	1181	779	779
query77	1009	347	270	270
query78	10008	10348	10444	10348
query79	4041	898	597	597
query80	580	516	413	413
query81	502	274	233	233
query82	245	146	134	134
query83	200	160	142	142
query84	280	88	67	67
query85	730	353	370	353
query86	370	325	299	299
query87	4667	4414	4522	4414
query88	3770	2255	2233	2233
query89	441	329	293	293
query90	2151	188	187	187
query91	129	133	105	105
query92	66	55	48	48
query93	2863	871	507	507
query94	661	388	300	300
query95	326	265	251	251
query96	483	607	288	288
query97	2724	2855	2719	2719
query98	215	199	205	199
query99	1730	1573	1451	1451
Total cold run time: 303651 ms
Total hot run time: 196980 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.65 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8b451f1de7d236a50ac840fe0a52787f6ee90d13, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.03
query3	0.23	0.07	0.06
query4	1.61	0.11	0.11
query5	0.41	0.44	0.40
query6	1.14	0.66	0.65
query7	0.03	0.02	0.02
query8	0.04	0.03	0.04
query9	0.59	0.50	0.52
query10	0.56	0.56	0.56
query11	0.15	0.11	0.10
query12	0.14	0.11	0.11
query13	0.62	0.59	0.60
query14	2.83	2.73	2.76
query15	0.92	0.82	0.83
query16	0.37	0.38	0.39
query17	0.96	1.04	1.00
query18	0.22	0.21	0.19
query19	1.97	1.90	1.98
query20	0.02	0.01	0.02
query21	15.64	1.00	0.59
query22	0.76	0.81	0.90
query23	15.06	1.46	0.65
query24	2.61	1.07	1.05
query25	0.30	0.15	0.06
query26	0.20	0.15	0.13
query27	0.07	0.05	0.05
query28	13.98	1.55	1.04
query29	12.59	3.98	3.28
query30	0.25	0.09	0.06
query31	2.81	0.60	0.39
query32	3.22	0.55	0.45
query33	3.06	3.10	3.04
query34	16.56	5.21	4.52
query35	4.54	4.53	4.51
query36	0.65	0.50	0.49
query37	0.09	0.06	0.06
query38	0.04	0.04	0.03
query39	0.04	0.02	0.03
query40	0.17	0.13	0.13
query41	0.08	0.02	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.72 s
Total hot run time: 31.65 s

@LiBinfeng-01
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 27, 2024
@doris-robot
Copy link

TPC-H: Total hot run time: 32875 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8b451f1de7d236a50ac840fe0a52787f6ee90d13, data reload: false

------ Round 1 ----------------------------------
q1	17604	6229	6059	6059
q2	2053	305	170	170
q3	10465	1294	758	758
q4	10217	880	435	435
q5	7574	2226	2000	2000
q6	206	177	148	148
q7	903	773	607	607
q8	9245	1358	1186	1186
q9	5227	5013	4959	4959
q10	6780	2334	1875	1875
q11	472	292	259	259
q12	357	363	217	217
q13	17762	3601	2953	2953
q14	230	244	212	212
q15	554	504	498	498
q16	643	629	603	603
q17	600	864	330	330
q18	7262	6594	6474	6474
q19	2012	969	571	571
q20	303	312	187	187
q21	3041	2226	2061	2061
q22	357	324	313	313
Total cold run time: 103867 ms
Total hot run time: 32875 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6256	6266	6215	6215
q2	239	325	229	229
q3	2275	2631	2329	2329
q4	1426	1843	1401	1401
q5	4407	4794	4961	4794
q6	185	177	145	145
q7	2147	1979	1814	1814
q8	2584	2800	2681	2681
q9	7394	7261	7292	7261
q10	3083	3355	2805	2805
q11	586	533	513	513
q12	668	781	610	610
q13	3360	3704	3112	3112
q14	293	323	279	279
q15	568	503	543	503
q16	640	659	655	655
q17	1215	1719	1234	1234
q18	7758	7455	7245	7245
q19	830	1097	1036	1036
q20	1927	1996	1807	1807
q21	5496	5112	4924	4924
q22	607	625	575	575
Total cold run time: 53944 ms
Total hot run time: 52167 ms

@LiBinfeng-01
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32394 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 78829e45659d236c801d0ce3b7c069480dc4d85b, data reload: false

------ Round 1 ----------------------------------
q1	17589	6144	6036	6036
q2	2044	302	166	166
q3	10447	1251	756	756
q4	10555	868	432	432
q5	9652	2188	1980	1980
q6	221	180	148	148
q7	898	757	606	606
q8	9225	1368	1157	1157
q9	5201	4940	4893	4893
q10	6793	2326	1869	1869
q11	493	280	256	256
q12	336	361	242	242
q13	17817	3671	2934	2934
q14	243	236	217	217
q15	561	499	491	491
q16	645	601	580	580
q17	589	861	327	327
q18	6767	6285	6418	6285
q19	2311	984	559	559
q20	298	313	182	182
q21	2846	2165	1974	1974
q22	358	336	304	304
Total cold run time: 105889 ms
Total hot run time: 32394 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6355	6294	6230	6230
q2	234	324	226	226
q3	2238	2680	2296	2296
q4	1403	1827	1352	1352
q5	4329	4723	4900	4723
q6	188	181	143	143
q7	2050	1963	1809	1809
q8	2648	2817	2662	2662
q9	7285	7275	7285	7275
q10	3059	3331	2741	2741
q11	576	523	495	495
q12	701	808	624	624
q13	3358	3804	3049	3049
q14	294	294	288	288
q15	558	509	499	499
q16	666	682	643	643
q17	1211	1729	1244	1244
q18	7768	7456	7480	7456
q19	835	1041	1151	1041
q20	2012	2076	1957	1957
q21	5803	5192	4909	4909
q22	625	613	620	613
Total cold run time: 54196 ms
Total hot run time: 52275 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197896 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 78829e45659d236c801d0ce3b7c069480dc4d85b, data reload: false

query1	1308	930	958	930
query2	6449	2314	2337	2314
query3	10984	4608	4741	4608
query4	33024	24083	23475	23475
query5	4355	622	454	454
query6	301	210	187	187
query7	3987	483	312	312
query8	312	260	270	260
query9	9682	2736	2737	2736
query10	469	315	247	247
query11	17923	15970	14880	14880
query12	165	104	101	101
query13	1579	589	435	435
query14	9599	7970	7919	7919
query15	264	208	197	197
query16	7863	610	474	474
query17	1550	781	611	611
query18	2077	432	312	312
query19	212	190	160	160
query20	120	124	110	110
query21	205	136	109	109
query22	4527	4540	4580	4540
query23	34395	33690	34279	33690
query24	6498	2332	2406	2332
query25	484	451	387	387
query26	725	286	151	151
query27	2155	481	335	335
query28	5512	2491	2472	2472
query29	600	562	440	440
query30	202	183	150	150
query31	991	914	844	844
query32	75	57	59	57
query33	484	358	295	295
query34	787	872	535	535
query35	800	838	762	762
query36	1019	1070	962	962
query37	122	101	76	76
query38	4132	4243	4287	4243
query39	1519	1641	1470	1470
query40	243	115	102	102
query41	47	45	46	45
query42	119	97	102	97
query43	544	532	493	493
query44	1306	845	832	832
query45	181	176	172	172
query46	892	1066	656	656
query47	2003	2080	1948	1948
query48	404	412	327	327
query49	709	488	443	443
query50	629	694	398	398
query51	7330	7318	7295	7295
query52	101	101	87	87
query53	221	250	192	192
query54	489	505	437	437
query55	81	79	76	76
query56	271	250	252	250
query57	1251	1264	1171	1171
query58	236	228	235	228
query59	3213	3210	3130	3130
query60	286	275	259	259
query61	119	116	113	113
query62	845	795	739	739
query63	226	196	209	196
query64	2728	1034	713	713
query65	3349	3293	3294	3293
query66	701	415	319	319
query67	16596	15942	15615	15615
query68	9677	764	510	510
query69	483	298	252	252
query70	1202	1167	1137	1137
query71	441	288	251	251
query72	6271	3831	3841	3831
query73	1547	754	359	359
query74	10285	9327	9229	9229
query75	4543	3129	2648	2648
query76	5544	1207	773	773
query77	1021	377	277	277
query78	10043	10086	9365	9365
query79	6981	888	578	578
query80	753	570	424	424
query81	486	275	230	230
query82	256	153	120	120
query83	202	163	142	142
query84	282	94	68	68
query85	749	356	304	304
query86	343	318	282	282
query87	4501	4440	4533	4440
query88	4156	2211	2213	2211
query89	437	336	293	293
query90	2072	188	185	185
query91	132	140	105	105
query92	65	56	52	52
query93	3809	883	514	514
query94	736	375	290	290
query95	327	266	259	259
query96	499	589	284	284
query97	2737	2770	2661	2661
query98	224	211	198	198
query99	1650	1597	1426	1426
Total cold run time: 305029 ms
Total hot run time: 197896 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.25 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 78829e45659d236c801d0ce3b7c069480dc4d85b, data reload: false

query1	0.03	0.03	0.04
query2	0.07	0.03	0.03
query3	0.24	0.07	0.07
query4	1.61	0.10	0.10
query5	0.40	0.42	0.41
query6	1.14	0.66	0.64
query7	0.03	0.02	0.01
query8	0.04	0.03	0.03
query9	0.58	0.51	0.51
query10	0.56	0.56	0.56
query11	0.15	0.11	0.12
query12	0.13	0.12	0.11
query13	0.60	0.60	0.59
query14	2.84	2.73	2.71
query15	0.89	0.83	0.84
query16	0.40	0.39	0.39
query17	1.04	1.04	1.01
query18	0.23	0.22	0.21
query19	1.95	1.83	1.98
query20	0.01	0.01	0.02
query21	15.38	0.93	0.55
query22	0.75	0.70	0.65
query23	15.36	1.53	0.61
query24	3.54	1.07	1.38
query25	0.21	0.05	0.18
query26	0.37	0.16	0.15
query27	0.05	0.05	0.05
query28	13.27	1.58	1.05
query29	12.56	3.90	3.22
query30	0.24	0.10	0.06
query31	2.83	0.60	0.37
query32	3.23	0.55	0.47
query33	3.09	3.06	3.06
query34	16.72	5.16	4.49
query35	4.47	4.46	4.42
query36	0.66	0.49	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.16	0.14	0.13
query41	0.07	0.02	0.03
query42	0.04	0.03	0.02
query43	0.04	0.03	0.02
Total cold run time: 106.15 s
Total hot run time: 31.25 s

@LiBinfeng-01
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32439 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3dd27fc549f4776a88a0e9262c416e2df12a6d25, data reload: false

------ Round 1 ----------------------------------
q1	17581	6149	6039	6039
q2	2044	291	176	176
q3	10420	1246	706	706
q4	10208	876	433	433
q5	7524	2165	1964	1964
q6	202	179	146	146
q7	909	719	610	610
q8	9260	1331	1093	1093
q9	5119	4880	5034	4880
q10	6758	2281	1878	1878
q11	471	284	264	264
q12	348	349	215	215
q13	17764	3591	2959	2959
q14	245	244	210	210
q15	553	496	497	496
q16	631	631	581	581
q17	550	841	317	317
q18	6948	6382	6472	6382
q19	1233	971	557	557
q20	318	323	184	184
q21	2763	2178	2031	2031
q22	362	330	318	318
Total cold run time: 102211 ms
Total hot run time: 32439 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6190	6181	6229	6181
q2	230	332	226	226
q3	2202	2618	2316	2316
q4	1403	1814	1377	1377
q5	4338	4767	4671	4671
q6	183	176	139	139
q7	2126	2025	1848	1848
q8	2548	2740	2642	2642
q9	7295	7265	7144	7144
q10	3044	3367	2825	2825
q11	599	507	507	507
q12	656	751	606	606
q13	3363	3779	3122	3122
q14	275	295	271	271
q15	573	526	540	526
q16	639	691	652	652
q17	1198	1711	1254	1254
q18	7683	7527	7135	7135
q19	779	1070	1041	1041
q20	1884	1940	1845	1845
q21	5465	5125	4804	4804
q22	578	566	612	566
Total cold run time: 53251 ms
Total hot run time: 51698 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190309 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3dd27fc549f4776a88a0e9262c416e2df12a6d25, data reload: false

query1	969	370	369	369
query2	6524	2397	2297	2297
query3	6716	218	211	211
query4	34010	23639	23469	23469
query5	4351	632	464	464
query6	281	208	194	194
query7	4643	491	312	312
query8	319	254	248	248
query9	9754	2759	2751	2751
query10	476	335	256	256
query11	18135	15389	15255	15255
query12	159	113	111	111
query13	1673	560	423	423
query14	9887	7796	7290	7290
query15	242	209	189	189
query16	8442	612	450	450
query17	1597	765	597	597
query18	2153	405	306	306
query19	226	227	148	148
query20	117	113	111	111
query21	212	119	100	100
query22	4206	4523	4368	4368
query23	33980	33708	33364	33364
query24	6430	2351	2277	2277
query25	504	453	380	380
query26	768	277	153	153
query27	1990	466	342	342
query28	5074	2488	2453	2453
query29	593	528	415	415
query30	224	182	150	150
query31	962	886	840	840
query32	96	61	57	57
query33	501	350	290	290
query34	753	844	513	513
query35	824	843	726	726
query36	997	1023	946	946
query37	113	99	81	81
query38	4195	4027	4099	4027
query39	1536	1455	1420	1420
query40	206	114	100	100
query41	47	44	50	44
query42	122	108	114	108
query43	512	524	492	492
query44	1321	803	804	803
query45	175	172	170	170
query46	865	1038	666	666
query47	1914	1909	1862	1862
query48	377	408	322	322
query49	740	493	392	392
query50	639	639	385	385
query51	7196	7289	6953	6953
query52	102	101	91	91
query53	225	260	201	201
query54	480	490	397	397
query55	79	76	80	76
query56	255	249	231	231
query57	1216	1163	1113	1113
query58	235	224	229	224
query59	2958	3017	3016	3016
query60	292	269	260	260
query61	136	110	106	106
query62	884	785	743	743
query63	231	191	193	191
query64	3826	1000	641	641
query65	3315	3206	3199	3199
query66	857	413	306	306
query67	15961	15684	15550	15550
query68	9452	756	523	523
query69	501	350	254	254
query70	1200	1140	1077	1077
query71	440	289	257	257
query72	6264	3802	3898	3802
query73	837	744	361	361
query74	10392	8899	8895	8895
query75	4642	3172	2652	2652
query76	5614	1175	794	794
query77	1027	406	278	278
query78	10055	10255	9368	9368
query79	6420	885	585	585
query80	704	521	429	429
query81	485	266	237	237
query82	208	155	119	119
query83	192	164	154	154
query84	282	96	67	67
query85	740	374	305	305
query86	332	322	296	296
query87	4418	4541	4334	4334
query88	4266	2220	2222	2220
query89	438	348	303	303
query90	2035	186	181	181
query91	129	129	106	106
query92	65	58	51	51
query93	3750	879	532	532
query94	677	398	309	309
query95	322	262	243	243
query96	483	613	280	280
query97	2760	2814	2663	2663
query98	220	202	203	202
query99	1628	1547	1437	1437
Total cold run time: 300776 ms
Total hot run time: 190309 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.63 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3dd27fc549f4776a88a0e9262c416e2df12a6d25, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.03	0.03
query3	0.23	0.08	0.07
query4	1.59	0.11	0.11
query5	0.45	0.41	0.41
query6	1.18	0.65	0.65
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.55	0.54	0.51
query10	0.55	0.57	0.54
query11	0.15	0.11	0.11
query12	0.14	0.11	0.12
query13	0.60	0.61	0.60
query14	2.74	2.75	2.75
query15	0.90	0.83	0.81
query16	0.40	0.38	0.37
query17	1.00	1.04	1.05
query18	0.22	0.20	0.20
query19	1.83	1.87	2.02
query20	0.01	0.01	0.01
query21	15.36	0.91	0.58
query22	0.75	0.81	0.69
query23	15.21	1.39	0.60
query24	2.77	1.12	1.24
query25	0.16	0.17	0.11
query26	0.30	0.16	0.14
query27	0.07	0.06	0.05
query28	13.97	1.56	1.06
query29	12.61	3.98	3.24
query30	0.26	0.09	0.06
query31	2.83	0.62	0.37
query32	3.23	0.54	0.46
query33	3.06	3.11	3.14
query34	17.04	5.14	4.54
query35	4.61	4.45	4.51
query36	0.62	0.49	0.47
query37	0.09	0.06	0.06
query38	0.04	0.05	0.04
query39	0.04	0.03	0.02
query40	0.16	0.13	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.05 s
Total hot run time: 31.63 s

@LiBinfeng-01
Copy link
Contributor Author

run p0

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 30, 2024
sb.append("20");
} else if (year >= 70 && year <= 99) {
sb.append("19");
if (s.charAt(j) == '.') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why "201.01.01" is year 2020, but "201-01-01" is year 201

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this behavior is align to mysql

@englefly englefly merged commit 2466d08 into apache:master Dec 30, 2024
32 of 33 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 30, 2024
### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #35637 

Problem Summary:
When cast("201-01-01" as datetimev2(0)), The result is "2020-01-01" but
it is wrong. It should be result in "0201-01-01".
201 would be regarded as 20xy-0z as related pr show, it was a bug. But
actually it should not have this trasformation and result in
LiBinfeng-01 pushed a commit to LiBinfeng-01/doris that referenced this pull request Jan 7, 2025
Issue Number: close #xxx

Related PR: apache#35637

Problem Summary:
When cast("201-01-01" as datetimev2(0)), The result is "2020-01-01" but
it is wrong. It should be result in "0201-01-01".
201 would be regarded as 20xy-0z as related pr show, it was a bug. But
actually it should not have this trasformation and result in
LiBinfeng-01 pushed a commit to LiBinfeng-01/doris that referenced this pull request Jan 9, 2025
Issue Number: close #xxx

Related PR: apache#35637

Problem Summary:
When cast("201-01-01" as datetimev2(0)), The result is "2020-01-01" but
it is wrong. It should be result in "0201-01-01".
201 would be regarded as 20xy-0z as related pr show, it was a bug. But
actually it should not have this trasformation and result in
LiBinfeng-01 pushed a commit to LiBinfeng-01/doris that referenced this pull request Jan 9, 2025
Issue Number: close #xxx

Related PR: apache#35637

Problem Summary:
When cast("201-01-01" as datetimev2(0)), The result is "2020-01-01" but
it is wrong. It should be result in "0201-01-01".
201 would be regarded as 20xy-0z as related pr show, it was a bug. But
actually it should not have this trasformation and result in
morrySnow pushed a commit that referenced this pull request Jan 9, 2025
pick: #46065

Related PR: #35637

Problem Summary:
When cast("201-01-01" as datetimev2(0)), The result is "2020-01-01" but
it is wrong. It should be result in "0201-01-01".
201 would be regarded as 20xy-0z as related pr show, it was a bug. But
actually it should not have this trasformation and result in
morrySnow pushed a commit that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants