Skip to content

Conversation

@LiBinfeng-01
Copy link
Contributor

pick: #46065
What problem does this PR solve?
Issue Number: close #xxx

Related PR: #35637

Problem Summary:
When cast("201-01-01" as datetimev2(0)), The result is "2020-01-01" but it is wrong. It should be result in "0201-01-01".
201 would be regarded as 20xy-0z as related pr show, it was a bug. But actually it should not have this trasformation and result in

Release note
None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

LiBinfeng added 2 commits December 30, 2024 08:36
### What problem does this PR solve?

Issue Number: close #xxx

Related PR: apache#35637 

Problem Summary:
When cast("201-01-01" as datetimev2(0)), The result is "2020-01-01" but
it is wrong. It should be result in "0201-01-01".
201 would be regarded as 20xy-0z as related pr show, it was a bug. But
actually it should not have this trasformation and result in
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@LiBinfeng-01
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40584 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0557327a5a3f3be40020f91d7740534b9453f32d, data reload: false

------ Round 1 ----------------------------------
q1	17585	7403	7193	7193
q2	2061	176	165	165
q3	10671	1120	1112	1112
q4	10552	770	753	753
q5	7747	2838	2768	2768
q6	234	147	146	146
q7	955	611	606	606
q8	9347	1908	2016	1908
q9	6582	6481	6413	6413
q10	6988	2266	2275	2266
q11	480	261	256	256
q12	404	210	199	199
q13	17790	2979	2953	2953
q14	245	204	206	204
q15	559	526	521	521
q16	702	631	601	601
q17	975	595	584	584
q18	7136	6690	6601	6601
q19	1515	1158	961	961
q20	461	201	203	201
q21	3941	3258	3200	3200
q22	1086	973	1012	973
Total cold run time: 108016 ms
Total hot run time: 40584 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7251	7169	7189	7169
q2	325	237	234	234
q3	2871	2919	2945	2919
q4	2012	1761	1823	1761
q5	5697	5757	5735	5735
q6	229	140	143	140
q7	2304	1803	1811	1803
q8	3362	3534	3487	3487
q9	8703	8810	8761	8761
q10	3564	3539	3508	3508
q11	598	499	488	488
q12	811	604	599	599
q13	9701	3178	3158	3158
q14	292	270	272	270
q15	570	535	544	535
q16	721	682	674	674
q17	1878	1628	1590	1590
q18	8274	7713	7572	7572
q19	1666	1478	1626	1478
q20	2131	1836	1850	1836
q21	5653	5427	5517	5427
q22	1143	1026	1000	1000
Total cold run time: 69756 ms
Total hot run time: 60144 ms

@LiBinfeng-01
Copy link
Contributor Author

run p0

@doris-robot
Copy link

TPC-DS: Total hot run time: 197820 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0557327a5a3f3be40020f91d7740534b9453f32d, data reload: false

query1	1333	924	920	920
query2	6209	2049	2082	2049
query3	10812	4211	4215	4211
query4	66589	29091	23462	23462
query5	4868	447	443	443
query6	420	176	171	171
query7	5619	324	314	314
query8	317	234	231	231
query9	9227	2697	2677	2677
query10	478	272	271	271
query11	17242	15263	15843	15263
query12	161	108	103	103
query13	1536	443	444	443
query14	11109	7522	7771	7522
query15	197	183	187	183
query16	7147	518	491	491
query17	1085	585	591	585
query18	1869	334	327	327
query19	221	168	161	161
query20	118	112	112	112
query21	208	102	107	102
query22	4668	4595	4668	4595
query23	34593	34001	34339	34001
query24	6074	2923	2956	2923
query25	544	429	413	413
query26	652	171	174	171
query27	1902	352	356	352
query28	4214	2463	2453	2453
query29	704	479	454	454
query30	249	174	166	166
query31	1005	822	870	822
query32	66	53	53	53
query33	472	300	303	300
query34	925	520	545	520
query35	874	728	717	717
query36	1094	958	961	958
query37	113	73	74	73
query38	4079	4060	4063	4060
query39	1554	1489	1452	1452
query40	207	97	108	97
query41	51	49	54	49
query42	118	100	106	100
query43	547	486	504	486
query44	1196	839	822	822
query45	185	162	173	162
query46	1155	733	703	703
query47	1987	1880	1901	1880
query48	481	395	377	377
query49	735	392	393	392
query50	861	440	438	438
query51	7298	7208	7294	7208
query52	98	86	92	86
query53	255	181	190	181
query54	567	458	457	457
query55	74	77	75	75
query56	253	242	236	236
query57	1235	1111	1110	1110
query58	214	197	204	197
query59	3109	2977	2865	2865
query60	276	264	250	250
query61	106	138	106	106
query62	778	662	661	661
query63	221	202	198	198
query64	1350	667	642	642
query65	3250	3194	3214	3194
query66	717	319	299	299
query67	15681	15584	15539	15539
query68	4116	584	587	584
query69	429	268	273	268
query70	1186	1142	1110	1110
query71	384	259	261	259
query72	6375	3952	4077	3952
query73	751	347	364	347
query74	10193	8961	8966	8961
query75	3367	2633	2660	2633
query76	1871	1018	1050	1018
query77	485	271	270	270
query78	10527	9605	9542	9542
query79	1492	609	599	599
query80	877	446	427	427
query81	521	244	242	242
query82	1250	118	115	115
query83	239	143	139	139
query84	273	82	75	75
query85	882	307	284	284
query86	354	299	301	299
query87	4455	4343	4323	4323
query88	3842	2384	2330	2330
query89	456	302	291	291
query90	2013	190	186	186
query91	178	149	154	149
query92	66	48	50	48
query93	1872	557	562	557
query94	878	310	297	297
query95	368	259	261	259
query96	631	280	283	280
query97	3343	3199	3165	3165
query98	214	204	195	195
query99	1586	1295	1282	1282
Total cold run time: 319026 ms
Total hot run time: 197820 ms

@morrySnow morrySnow merged commit 5a27ebf into apache:branch-3.0 Jan 14, 2025
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants