Skip to content

Conversation

@xinghuayu007
Copy link
Contributor

Proposed changes

In LoadingTaskPlanner#Plan(): OlapTableSink olapTableSink = new OlapTableSink(table, tupleDesc, partitionIds); If the table does not has any partition, Preconditions.checkState will throw IllegalStateException, but the funtion only cath UserException, that will cause load job status can not be updated。
The issue: #4620

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

OlapTableSink olapTableSink;
try {
olapTableSink = new OlapTableSink(table, tupleDesc, partitionIds);
} catch (IllegalStateException e) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a good way to catch IllegalStateException here. Because it is a "Assertion" check in OlapTableSink.
We should check if partitionIds is empty before creating new OlapTableSink.

And by the way, there are severval place where the OlapTableSink's constructor is called, we should modify them too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok,I will check if partitionIds is empty before creating new OlapTableSink. And modify all where OlapTableSink's constructor is called.

@morningman morningman added the kind/fix Categorizes issue or PR as related to a bug. label Sep 19, 2020
@morningman morningman self-assigned this Sep 19, 2020
@morningman
Copy link
Contributor

Hi @xinghuayu007 , thanks for your PR, but I think #4658 has a more clear error msg.
So I approve that PR and will close this one.

@morningman morningman closed this Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants