[Bug] Fix that the partitions of a dynamic-partitioned table has not been created at the time of load or insert #4658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 23, 2020 15:15
Contributor
|
this bug has been fixed at PR: #4621 |
EmmyMiao87
reviewed
Sep 23, 2020
| // If this is a dynamic partitioned table, it will take some time to create the partition after the | ||
| // table is created, a exception needs to be thrown here | ||
| if (partitionIds.isEmpty()) { | ||
| throw new LoadException("data cannot be inserted into table with emtpy partition. " + |
Contributor
There was a problem hiding this comment.
It is best to guide users in the prompt to wait for a while because of dynamic partitioning
Contributor
There was a problem hiding this comment.
I agree. I think we can change the error msg like:
data cannot be inserted into table with emtpy partition... Use `SHOW PARTITIONS FROM tbl` to see the currenty partitions of this table.
And also change the msg in error code ERR_EMPTY_PARTITION_IN_TABLE
Member
Author
There was a problem hiding this comment.
ok. I will change the error msg.
6 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix #4657
when a dynamic partitioned table is created, it will take some time to create the partitions. A exception needs to be thrown when users try to load data into this table, otherwise the load will stuck in loading phase all the time.
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...