-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](metaCache)fix bug that names cache can not invalidate. #46287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 32483 ms |
TPC-DS: Total hot run time: 197470 ms |
ClickBench: Total hot run time: 31.09 s |
|
run buildall |
TPC-H: Total hot run time: 32812 ms |
TPC-DS: Total hot run time: 197436 ms |
ClickBench: Total hot run time: 30.88 s |
|
run buildall |
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 32609 ms |
TPC-DS: Total hot run time: 197467 ms |
ClickBench: Total hot run time: 31.25 s |
### What problem does this PR solve? Related PR: #41510 Problem Summary: In this pr#41510, namesCache changed from `LoadingCache<String, List<String>>` to `LoadingCache<String, List<Pair<String, String>>>`, but the `remove` method of this cache did not change, causing the hms event case to fail.
What problem does this PR solve?
Related PR: #41510
Problem Summary:
In this pr#41510, namesCache changed from
LoadingCache<String, List<String>>toLoadingCache<String, List<Pair<String, String>>>, but theremovemethod of this cache did not change, causing the hms event case to fail.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)