[fix](external catalog) Persisting the External Catalog comment field #46946

zy-kkk · 2025-01-14T02:56:23Z

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Since the comment field is not persisted, the comment will be lost after the FE is restarted after the comment is modified. This PR adds persistence to the comment.

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2025-01-14T02:56:29Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

zy-kkk · 2025-01-14T02:56:41Z

run buildall

doris-robot · 2025-01-14T03:39:41Z

TPC-H: Total hot run time: 32576 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 911ea768a0a3444a9f9eb579d0b663910da2ee52, data reload: false

------ Round 1 ----------------------------------
q1	17577	6153	6034	6034
q2	2049	302	173	173
q3	10594	1224	778	778
q4	10234	855	435	435
q5	7877	2166	1931	1931
q6	211	181	149	149
q7	891	764	618	618
q8	9236	1360	1162	1162
q9	5195	4888	4864	4864
q10	6778	2276	1855	1855
q11	486	293	270	270
q12	348	366	217	217
q13	17838	3695	3016	3016
q14	241	239	233	233
q15	558	517	498	498
q16	647	616	611	611
q17	576	840	321	321
q18	6816	6482	6372	6372
q19	1713	946	570	570
q20	310	314	191	191
q21	2830	2249	1973	1973
q22	357	324	305	305
Total cold run time: 103362 ms
Total hot run time: 32576 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6288	6220	6226	6220
q2	244	331	243	243
q3	2236	2633	2323	2323
q4	1400	1780	1364	1364
q5	4304	4747	4776	4747
q6	186	176	141	141
q7	2061	1920	1835	1835
q8	2659	2807	2695	2695
q9	7244	7140	7321	7140
q10	3035	3321	2727	2727
q11	565	520	520	520
q12	678	819	623	623
q13	3450	3869	3289	3289
q14	274	300	277	277
q15	597	525	513	513
q16	690	688	650	650
q17	1203	1753	1269	1269
q18	7888	7440	7409	7409
q19	807	1087	1076	1076
q20	2012	2068	1876	1876
q21	5622	4980	5146	4980
q22	618	618	603	603
Total cold run time: 54061 ms
Total hot run time: 52520 ms

doris-robot · 2025-01-14T03:51:56Z

TPC-DS: Total hot run time: 195107 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 911ea768a0a3444a9f9eb579d0b663910da2ee52, data reload: false

query1	1353	965	944	944
query2	6391	2341	2236	2236
query3	10973	4903	4596	4596
query4	33197	23636	23152	23152
query5	4552	653	477	477
query6	309	211	203	203
query7	4001	521	319	319
query8	358	280	274	274
query9	9711	2700	2681	2681
query10	487	321	256	256
query11	17942	15138	15001	15001
query12	157	108	112	108
query13	1561	527	394	394
query14	9975	7186	7720	7186
query15	226	203	205	203
query16	8393	672	443	443
query17	1637	802	638	638
query18	2052	438	354	354
query19	270	199	195	195
query20	128	129	118	118
query21	223	137	109	109
query22	4549	4522	4402	4402
query23	34198	33081	33038	33038
query24	6491	2329	2364	2329
query25	544	489	413	413
query26	782	306	164	164
query27	2123	500	342	342
query28	5484	2486	2472	2472
query29	581	618	461	461
query30	224	188	159	159
query31	977	877	820	820
query32	78	60	62	60
query33	499	380	332	332
query34	766	944	512	512
query35	822	850	744	744
query36	1024	1043	976	976
query37	132	112	87	87
query38	4172	4145	4186	4145
query39	1480	1453	1437	1437
query40	202	125	112	112
query41	64	63	63	63
query42	129	108	110	108
query43	529	538	507	507
query44	1430	825	834	825
query45	185	182	169	169
query46	931	1102	658	658
query47	1913	1978	1871	1871
query48	399	419	340	340
query49	770	543	435	435
query50	723	703	398	398
query51	7060	7003	7067	7003
query52	104	104	99	99
query53	236	266	195	195
query54	508	531	451	451
query55	87	85	84	84
query56	275	280	269	269
query57	1245	1211	1145	1145
query58	269	246	252	246
query59	3144	3196	3128	3128
query60	333	301	292	292
query61	148	150	148	148
query62	863	811	729	729
query63	234	196	192	192
query64	2840	1181	824	824
query65	3294	3289	3225	3225
query66	825	443	332	332
query67	16062	15788	15424	15424
query68	7698	731	529	529
query69	508	305	262	262
query70	1243	1139	1111	1111
query71	450	295	253	253
query72	6680	3007	4138	3007
query73	672	796	354	354
query74	10073	9097	8967	8967
query75	4204	3172	2694	2694
query76	3682	1252	870	870
query77	780	365	274	274
query78	10062	10004	9452	9452
query79	3125	885	608	608
query80	687	556	483	483
query81	492	288	237	237
query82	618	161	120	120
query83	183	180	162	162
query84	257	95	77	77
query85	847	415	420	415
query86	355	315	307	307
query87	4422	4300	4339	4300
query88	4426	2198	2150	2150
query89	427	328	297	297
query90	1858	194	191	191
query91	147	153	121	121
query92	70	63	64	63
query93	1431	882	549	549
query94	664	432	298	298
query95	354	270	266	266
query96	490	660	286	286
query97	2889	2929	2779	2779
query98	221	203	199	199
query99	1676	1514	1374	1374
Total cold run time: 295315 ms
Total hot run time: 195107 ms

doris-robot · 2025-01-14T03:57:16Z

ClickBench: Total hot run time: 31.47 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 911ea768a0a3444a9f9eb579d0b663910da2ee52, data reload: false

query1	0.03	0.05	0.02
query2	0.07	0.03	0.04
query3	0.25	0.06	0.07
query4	1.61	0.10	0.10
query5	0.42	0.42	0.42
query6	1.13	0.65	0.65
query7	0.03	0.02	0.02
query8	0.04	0.04	0.03
query9	0.60	0.49	0.50
query10	0.55	0.57	0.56
query11	0.15	0.10	0.10
query12	0.15	0.11	0.11
query13	0.60	0.62	0.59
query14	2.73	2.75	2.80
query15	0.90	0.83	0.83
query16	0.38	0.38	0.37
query17	1.07	1.06	1.03
query18	0.23	0.21	0.21
query19	1.83	1.77	2.02
query20	0.02	0.01	0.01
query21	15.36	0.87	0.57
query22	0.75	0.76	0.68
query23	15.35	1.49	0.62
query24	3.04	1.07	1.04
query25	0.22	0.15	0.08
query26	0.28	0.14	0.13
query27	0.05	0.06	0.06
query28	14.08	1.55	1.05
query29	12.59	4.07	3.42
query30	0.24	0.08	0.06
query31	2.84	0.60	0.38
query32	3.23	0.55	0.46
query33	3.08	3.12	3.09
query34	16.93	5.11	4.45
query35	4.50	4.47	4.43
query36	0.65	0.50	0.49
query37	0.09	0.07	0.06
query38	0.05	0.03	0.03
query39	0.04	0.02	0.02
query40	0.16	0.13	0.13
query41	0.07	0.02	0.02
query42	0.03	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.45 s
Total hot run time: 31.47 s

zy-kkk · 2025-01-14T08:21:02Z

run buildall

doris-robot · 2025-01-14T09:20:55Z

TPC-H: Total hot run time: 32678 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 13e7a57852619df6a01d1c589bf9aed321ff7289, data reload: false

------ Round 1 ----------------------------------
q1	17582	6152	6050	6050
q2	2051	303	170	170
q3	10414	1256	759	759
q4	10260	873	429	429
q5	8161	2189	1995	1995
q6	205	181	148	148
q7	887	762	615	615
q8	9255	1400	1268	1268
q9	5250	4804	4886	4804
q10	6717	2287	1820	1820
q11	467	295	255	255
q12	345	366	213	213
q13	17792	3723	3118	3118
q14	223	227	212	212
q15	585	526	524	524
q16	640	599	583	583
q17	559	856	326	326
q18	6892	6376	6494	6376
q19	2897	945	524	524
q20	303	315	184	184
q21	2674	2186	2002	2002
q22	357	335	303	303
Total cold run time: 104516 ms
Total hot run time: 32678 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6361	6267	6222	6222
q2	243	340	238	238
q3	2275	2631	2345	2345
q4	1361	1804	1338	1338
q5	4344	4750	4838	4750
q6	190	178	145	145
q7	2087	1949	1844	1844
q8	2597	2838	2719	2719
q9	7255	7246	7258	7246
q10	3059	3301	2729	2729
q11	591	545	483	483
q12	720	792	624	624
q13	3470	3901	3393	3393
q14	281	306	275	275
q15	575	544	507	507
q16	647	696	644	644
q17	1226	1750	1296	1296
q18	7842	7506	7386	7386
q19	760	1150	1080	1080
q20	2007	2051	1890	1890
q21	5627	5060	5069	5060
q22	642	611	547	547
Total cold run time: 54160 ms
Total hot run time: 52761 ms

doris-robot · 2025-01-14T09:33:36Z

TPC-DS: Total hot run time: 195487 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 13e7a57852619df6a01d1c589bf9aed321ff7289, data reload: false

query1	1307	947	945	945
query2	6308	2035	2033	2033
query3	10945	4507	4410	4410
query4	60875	29468	23232	23232
query5	5377	584	483	483
query6	437	194	194	194
query7	5559	508	322	322
query8	333	233	227	227
query9	8186	2756	2727	2727
query10	439	297	243	243
query11	17191	15226	15534	15226
query12	166	115	112	112
query13	1431	545	435	435
query14	10983	7240	7263	7240
query15	240	203	187	187
query16	7283	610	470	470
query17	1118	747	565	565
query18	1951	427	301	301
query19	204	171	155	155
query20	132	109	105	105
query21	205	119	99	99
query22	4331	4701	4404	4404
query23	34784	34068	33866	33866
query24	5653	2307	2293	2293
query25	470	455	404	404
query26	674	263	157	157
query27	1917	463	334	334
query28	3984	2490	2459	2459
query29	533	564	435	435
query30	210	191	156	156
query31	952	863	809	809
query32	74	58	59	58
query33	426	344	332	332
query34	748	876	498	498
query35	836	863	727	727
query36	1006	1040	953	953
query37	127	95	71	71
query38	4399	4332	4279	4279
query39	1515	1454	1452	1452
query40	197	119	98	98
query41	49	46	48	46
query42	145	102	100	100
query43	501	515	493	493
query44	1369	849	854	849
query45	185	176	169	169
query46	873	1055	675	675
query47	1898	1919	1853	1853
query48	389	394	342	342
query49	715	501	423	423
query50	640	668	385	385
query51	7138	6958	6974	6958
query52	103	103	100	100
query53	223	267	187	187
query54	485	503	411	411
query55	89	85	87	85
query56	270	295	252	252
query57	1123	1149	1079	1079
query58	235	227	250	227
query59	2969	3139	2811	2811
query60	273	256	247	247
query61	117	113	118	113
query62	847	744	702	702
query63	218	187	180	180
query64	1720	1050	665	665
query65	3254	3177	3159	3159
query66	653	416	304	304
query67	16168	15806	15432	15432
query68	5020	826	534	534
query69	522	293	249	249
query70	1194	1129	1149	1129
query71	428	288	255	255
query72	5966	3852	3835	3835
query73	793	759	356	356
query74	10174	9202	9115	9115
query75	3270	3212	2676	2676
query76	3772	1156	748	748
query77	517	379	347	347
query78	10175	9939	9352	9352
query79	3704	796	576	576
query80	1761	529	443	443
query81	555	280	232	232
query82	1031	147	120	120
query83	254	171	159	159
query84	285	90	79	79
query85	778	358	314	314
query86	463	316	303	303
query87	4490	4409	4442	4409
query88	4709	2212	2174	2174
query89	417	324	290	290
query90	1541	188	189	188
query91	133	138	119	119
query92	68	62	53	53
query93	2990	899	543	543
query94	863	406	305	305
query95	332	305	255	255
query96	499	612	292	292
query97	2850	2876	2739	2739
query98	248	193	200	193
query99	1555	1478	1362	1362
Total cold run time: 317512 ms
Total hot run time: 195487 ms

doris-robot · 2025-01-14T09:38:55Z

ClickBench: Total hot run time: 31.01 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 13e7a57852619df6a01d1c589bf9aed321ff7289, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.04
query3	0.24	0.07	0.07
query4	1.61	0.10	0.11
query5	0.40	0.40	0.40
query6	1.17	0.66	0.65
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.58	0.48	0.52
query10	0.54	0.55	0.54
query11	0.14	0.10	0.10
query12	0.14	0.12	0.11
query13	0.60	0.61	0.59
query14	2.70	2.74	2.73
query15	0.91	0.83	0.82
query16	0.38	0.37	0.38
query17	1.01	1.01	1.06
query18	0.23	0.21	0.20
query19	1.91	1.85	2.02
query20	0.01	0.01	0.01
query21	15.35	0.96	0.59
query22	0.74	0.80	0.64
query23	15.32	1.41	0.55
query24	3.32	1.72	0.84
query25	0.28	0.09	0.23
query26	0.20	0.16	0.13
query27	0.05	0.05	0.06
query28	13.66	1.48	1.04
query29	12.52	4.01	3.29
query30	0.25	0.09	0.06
query31	2.83	0.60	0.38
query32	3.24	0.56	0.46
query33	2.97	2.99	3.01
query34	16.54	5.18	4.51
query35	4.54	4.49	4.49
query36	0.62	0.49	0.47
query37	0.10	0.07	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.17	0.12	0.12
query41	0.08	0.03	0.02
query42	0.04	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.67 s
Total hot run time: 31.01 s

zy-kkk · 2025-01-15T16:22:25Z

run buildall

doris-robot · 2025-01-15T17:13:09Z

TPC-H: Total hot run time: 32100 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 769315ac547aada8694d525d089d878c0f2af568, data reload: false

------ Round 1 ----------------------------------
q1	17584	5488	5391	5391
q2	2044	299	181	181
q3	10428	1204	743	743
q4	10219	987	536	536
q5	7707	2398	2168	2168
q6	187	168	133	133
q7	900	758	613	613
q8	9220	1325	1137	1137
q9	5204	4867	4847	4847
q10	6865	2326	1857	1857
q11	474	275	253	253
q12	341	364	225	225
q13	17782	3653	3111	3111
q14	223	232	206	206
q15	527	478	459	459
q16	633	619	579	579
q17	562	859	320	320
q18	6812	6547	6321	6321
q19	2900	941	531	531
q20	299	311	190	190
q21	2759	2150	1992	1992
q22	361	338	307	307
Total cold run time: 104031 ms
Total hot run time: 32100 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5610	5491	5425	5425
q2	252	330	233	233
q3	2253	2655	2318	2318
q4	1421	1813	1375	1375
q5	4343	4758	4667	4667
q6	170	163	126	126
q7	2046	1944	1797	1797
q8	2612	2819	2717	2717
q9	7254	7191	7166	7166
q10	3005	3267	2787	2787
q11	580	523	488	488
q12	666	725	610	610
q13	3521	3945	3311	3311
q14	281	304	281	281
q15	514	493	477	477
q16	643	688	657	657
q17	1213	1720	1268	1268
q18	7617	7435	7450	7435
q19	818	1109	1077	1077
q20	1981	2067	1878	1878
q21	5730	5202	4810	4810
q22	626	623	621	621
Total cold run time: 53156 ms
Total hot run time: 51524 ms

doris-robot · 2025-01-15T17:25:40Z

TPC-DS: Total hot run time: 194147 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 769315ac547aada8694d525d089d878c0f2af568, data reload: false

query1	1302	952	931	931
query2	6311	2016	2052	2016
query3	10953	4554	4493	4493
query4	60852	29582	22948	22948
query5	5284	577	444	444
query6	400	189	174	174
query7	5535	519	301	301
query8	349	256	222	222
query9	8332	2712	2707	2707
query10	443	299	256	256
query11	17436	15161	15499	15161
query12	156	114	111	111
query13	1461	528	440	440
query14	10186	7348	6844	6844
query15	213	196	191	191
query16	7431	658	457	457
query17	1120	756	591	591
query18	1896	403	316	316
query19	204	185	164	164
query20	116	111	110	110
query21	208	122	98	98
query22	4394	4537	4573	4537
query23	33870	33320	33304	33304
query24	5810	2284	2272	2272
query25	490	464	401	401
query26	640	278	161	161
query27	1645	484	336	336
query28	4028	2528	2458	2458
query29	525	567	435	435
query30	210	191	151	151
query31	933	868	810	810
query32	70	60	54	54
query33	459	401	294	294
query34	745	888	510	510
query35	802	854	797	797
query36	1011	1048	955	955
query37	122	114	77	77
query38	4273	4328	4330	4328
query39	1506	1490	1452	1452
query40	210	114	102	102
query41	58	58	54	54
query42	116	100	98	98
query43	501	527	497	497
query44	1310	851	863	851
query45	188	181	166	166
query46	876	1059	653	653
query47	1937	1930	1869	1869
query48	397	397	337	337
query49	695	493	411	411
query50	672	673	404	404
query51	6954	7026	6918	6918
query52	105	97	107	97
query53	224	259	189	189
query54	481	509	431	431
query55	84	77	82	77
query56	263	268	247	247
query57	1243	1237	1213	1213
query58	240	240	237	237
query59	3044	3076	2832	2832
query60	263	257	261	257
query61	118	115	111	111
query62	728	709	645	645
query63	218	183	180	180
query64	1267	991	650	650
query65	3259	3093	3141	3093
query66	715	391	318	318
query67	15981	15427	15402	15402
query68	5039	818	537	537
query69	551	286	262	262
query70	1161	1076	1125	1076
query71	414	273	253	253
query72	6353	3837	3831	3831
query73	800	755	356	356
query74	10054	8907	9186	8907
query75	3283	3151	2678	2678
query76	3907	1180	761	761
query77	503	370	273	273
query78	10078	10051	9347	9347
query79	2404	798	592	592
query80	694	561	420	420
query81	509	280	296	280
query82	357	143	125	125
query83	181	170	163	163
query84	293	96	72	72
query85	728	338	309	309
query86	354	305	295	295
query87	4467	4518	4497	4497
query88	3486	2239	2193	2193
query89	394	322	300	300
query90	1614	191	194	191
query91	139	139	106	106
query92	61	55	53	53
query93	2148	891	538	538
query94	663	392	296	296
query95	327	261	252	252
query96	489	617	287	287
query97	2817	2882	2794	2794
query98	219	199	194	194
query99	1287	1353	1263	1263
Total cold run time: 309642 ms
Total hot run time: 194147 ms

doris-robot · 2025-01-15T17:30:59Z

ClickBench: Total hot run time: 30.64 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 769315ac547aada8694d525d089d878c0f2af568, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.04
query3	0.24	0.06	0.06
query4	1.62	0.10	0.10
query5	0.43	0.41	0.41
query6	1.17	0.67	0.66
query7	0.02	0.02	0.01
query8	0.04	0.04	0.03
query9	0.60	0.50	0.50
query10	0.55	0.57	0.55
query11	0.14	0.11	0.11
query12	0.14	0.11	0.11
query13	0.61	0.61	0.61
query14	2.81	2.76	2.73
query15	0.88	0.84	0.83
query16	0.39	0.39	0.39
query17	1.08	1.00	0.99
query18	0.23	0.21	0.20
query19	1.87	1.72	1.94
query20	0.02	0.02	0.01
query21	15.41	0.95	0.62
query22	0.77	0.96	0.67
query23	15.17	1.48	0.63
query24	2.94	1.80	1.06
query25	0.15	0.17	0.09
query26	0.30	0.15	0.13
query27	0.05	0.05	0.05
query28	13.95	1.02	0.42
query29	12.62	3.94	3.23
query30	0.25	0.09	0.07
query31	2.84	0.59	0.39
query32	3.23	0.55	0.46
query33	2.98	3.01	3.07
query34	16.74	5.14	4.45
query35	4.52	4.47	4.55
query36	0.66	0.48	0.49
query37	0.10	0.06	0.06
query38	0.05	0.04	0.04
query39	0.04	0.02	0.02
query40	0.17	0.13	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.04 s
Total hot run time: 30.64 s

github-actions · 2025-01-16T06:44:40Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-01-16T06:44:42Z

PR approved by anyone and no changes requested.

…#46946) Since the comment field is not persisted, the comment will be lost after the FE is restarted after the comment is modified. This PR adds persistence to the comment.

…apache#46946) Since the comment field is not persisted, the comment will be lost after the FE is restarted after the comment is modified. This PR adds persistence to the comment.

…omment field… (#47569) cherry-pick (#46946)

…apache#46946) Since the comment field is not persisted, the comment will be lost after the FE is restarted after the comment is modified. This PR adds persistence to the comment.

…#46946) Since the comment field is not persisted, the comment will be lost after the FE is restarted after the comment is modified. This PR adds persistence to the comment.

…omment field #46946 (#47270) Cherry-picked from #46946 Co-authored-by: zy-kkk <zhongyk10@gmail.com>

zy-kkk added 2 commits January 16, 2025 00:22

[fix](external catalog) Persisting the External Catalog comment field

4778230

add ut

769315a

zy-kkk force-pushed the fix_catalog_comment branch from 13e7a57 to 769315a Compare January 15, 2025 16:22

morningman added dev/2.1.x dev/3.0.x labels Jan 16, 2025

morningman approved these changes Jan 16, 2025

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 16, 2025

github-actions bot added the reviewed label Jan 16, 2025

hubgeter approved these changes Jan 16, 2025

View reviewed changes

CalvinKirs approved these changes Jan 16, 2025

View reviewed changes

zy-kkk merged commit eab52d6 into apache:master Jan 21, 2025
29 of 30 checks passed

zy-kkk deleted the fix_catalog_comment branch January 21, 2025 07:26

github-actions bot mentioned this pull request Jan 21, 2025

branch-3.0: [fix](external catalog) Persisting the External Catalog comment field #46946 #47270

Merged

github-actions bot added the dev/2.1.x-conflict label Jan 21, 2025

zy-kkk mentioned this pull request Feb 7, 2025

branch-2.1: [fix](external catalog) Persisting the External Catalog comment field… #47569

Merged

morningman pushed a commit that referenced this pull request Feb 12, 2025

branch-2.1: [fix](external catalog) Persisting the External Catalog c…

3ca0fc3

…omment field… (#47569) cherry-pick (#46946)

morningman added dev/2.1.9-merged and removed dev/2.1.x dev/2.1.x-conflict labels Feb 12, 2025

morningman added the usercase Important user case type label label Feb 24, 2025

dataroaring pushed a commit that referenced this pull request Feb 25, 2025

branch-3.0: [fix](external catalog) Persisting the External Catalog c…

a215a63

…omment field #46946 (#47270) Cherry-picked from #46946 Co-authored-by: zy-kkk <zhongyk10@gmail.com>

dataroaring added dev/3.0.5-merged and removed dev/3.0.x labels Feb 25, 2025

yiguolei mentioned this pull request Mar 25, 2025

2.1.9 Release Note #49443

Closed

gavinchou mentioned this pull request Apr 23, 2025

Release Notes 3.0.5 #50333

Closed

[fix](external catalog) Persisting the External Catalog comment field #46946

[fix](external catalog) Persisting the External Catalog comment field #46946

Uh oh!

Conversation

zy-kkk commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented Jan 14, 2025

Uh oh!

zy-kkk commented Jan 14, 2025

Uh oh!

doris-robot commented Jan 14, 2025

Uh oh!

doris-robot commented Jan 14, 2025

Uh oh!

doris-robot commented Jan 14, 2025

Uh oh!

zy-kkk commented Jan 14, 2025

Uh oh!

doris-robot commented Jan 14, 2025

Uh oh!

doris-robot commented Jan 14, 2025

Uh oh!

doris-robot commented Jan 14, 2025

Uh oh!

zy-kkk commented Jan 15, 2025

Uh oh!

doris-robot commented Jan 15, 2025

Uh oh!

doris-robot commented Jan 15, 2025

Uh oh!

doris-robot commented Jan 15, 2025

Uh oh!

github-actions bot commented Jan 16, 2025

Uh oh!

github-actions bot commented Jan 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

zy-kkk commented Jan 14, 2025 •

edited

Loading