Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #46946

@github-actions github-actions bot requested a review from dataroaring as a code owner January 21, 2025 07:27
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jan 21, 2025
@hello-stephen
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41562 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e9bc13b5250e83f817fee3e95227e956d4e54817, data reload: false

------ Round 1 ----------------------------------
q1	17567	7438	7275	7275
q2	2068	172	160	160
q3	10558	1135	1165	1135
q4	10236	845	722	722
q5	8102	2905	2935	2905
q6	236	151	148	148
q7	1005	627	622	622
q8	9934	2045	2070	2045
q9	6889	6574	6557	6557
q10	8240	2334	2343	2334
q11	496	270	286	270
q12	435	228	224	224
q13	17873	3069	3049	3049
q14	246	228	215	215
q15	589	538	517	517
q16	703	626	612	612
q17	1036	581	634	581
q18	7789	6823	6662	6662
q19	1417	1051	1011	1011
q20	473	205	198	198
q21	4006	3335	3316	3316
q22	1104	1010	1004	1004
Total cold run time: 111002 ms
Total hot run time: 41562 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7226	7261	7316	7261
q2	336	247	237	237
q3	3191	3027	2932	2932
q4	2145	1822	1768	1768
q5	5730	5721	5714	5714
q6	229	143	140	140
q7	2250	1817	1787	1787
q8	3376	3543	3506	3506
q9	8900	8911	8825	8825
q10	3626	3561	3562	3561
q11	591	489	497	489
q12	815	596	638	596
q13	7392	3163	3200	3163
q14	300	268	282	268
q15	578	522	546	522
q16	735	685	653	653
q17	1836	1575	1601	1575
q18	8098	7745	7564	7564
q19	1659	1501	1539	1501
q20	2022	1817	1816	1816
q21	5395	5199	5284	5199
q22	1103	1015	1008	1008
Total cold run time: 67533 ms
Total hot run time: 60085 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191570 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e9bc13b5250e83f817fee3e95227e956d4e54817, data reload: false

query1	993	372	363	363
query2	6506	2075	2042	2042
query3	6710	216	227	216
query4	33896	23372	23485	23372
query5	4345	463	451	451
query6	273	177	180	177
query7	4623	307	323	307
query8	286	222	234	222
query9	9520	2676	2676	2676
query10	486	267	266	266
query11	18373	15268	15275	15268
query12	160	103	102	102
query13	1636	433	435	433
query14	9023	6664	6764	6664
query15	246	178	188	178
query16	8071	399	489	399
query17	1626	589	571	571
query18	2118	320	323	320
query19	245	162	156	156
query20	120	110	109	109
query21	213	106	106	106
query22	4359	4266	4147	4147
query23	37581	34068	34785	34068
query24	12561	2848	2903	2848
query25	570	412	423	412
query26	1152	173	174	173
query27	3008	351	351	351
query28	7667	2451	2420	2420
query29	681	465	451	451
query30	349	172	167	167
query31	1052	802	821	802
query32	102	58	61	58
query33	815	302	301	301
query34	962	523	544	523
query35	930	723	721	721
query36	1102	935	983	935
query37	220	82	77	77
query38	4090	3911	3819	3819
query39	1490	1444	1428	1428
query40	289	105	104	104
query41	54	51	52	51
query42	118	102	100	100
query43	536	494	494	494
query44	1312	802	802	802
query45	187	176	174	174
query46	1155	698	719	698
query47	1910	1828	1851	1828
query48	466	397	375	375
query49	1291	412	401	401
query50	822	430	426	426
query51	7142	7120	7171	7120
query52	103	90	90	90
query53	274	194	191	191
query54	997	466	462	462
query55	81	78	77	77
query56	293	257	268	257
query57	1232	1111	1104	1104
query58	264	233	225	225
query59	3101	2840	2916	2840
query60	286	245	256	245
query61	114	110	115	110
query62	860	697	684	684
query63	220	206	188	188
query64	5190	675	668	668
query65	3312	3235	3211	3211
query66	1288	312	350	312
query67	16084	15620	15514	15514
query68	4914	579	581	579
query69	439	276	266	266
query70	1098	1149	1120	1120
query71	453	261	258	258
query72	6024	4102	4003	4003
query73	766	347	364	347
query74	10644	8997	8898	8898
query75	3429	2665	2630	2630
query76	2912	1045	1062	1045
query77	525	274	269	269
query78	10571	9733	9712	9712
query79	1311	597	592	592
query80	1000	445	444	444
query81	556	243	251	243
query82	961	129	124	124
query83	226	148	152	148
query84	248	87	80	80
query85	1322	316	306	306
query86	345	314	294	294
query87	4452	4295	4362	4295
query88	3609	2400	2357	2357
query89	412	295	296	295
query90	2032	192	192	192
query91	183	148	177	148
query92	61	54	56	54
query93	1091	560	554	554
query94	1063	312	303	303
query95	368	258	264	258
query96	613	279	286	279
query97	3357	3135	3191	3135
query98	225	202	196	196
query99	1525	1312	1296	1296
Total cold run time: 303876 ms
Total hot run time: 191570 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.41 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e9bc13b5250e83f817fee3e95227e956d4e54817, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.06
query4	1.62	0.10	0.11
query5	0.53	0.52	0.53
query6	1.13	0.74	0.73
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.56	0.50	0.49
query10	0.55	0.55	0.57
query11	0.15	0.11	0.11
query12	0.16	0.12	0.11
query13	0.63	0.60	0.60
query14	3.11	2.97	2.97
query15	0.90	0.83	0.83
query16	0.38	0.37	0.39
query17	1.10	1.04	1.06
query18	0.23	0.21	0.21
query19	1.94	1.97	1.91
query20	0.01	0.01	0.02
query21	15.37	0.61	0.57
query22	2.58	2.55	2.04
query23	17.01	0.95	0.68
query24	3.06	1.14	1.41
query25	0.32	0.08	0.04
query26	0.41	0.13	0.14
query27	0.05	0.04	0.04
query28	10.34	1.12	1.07
query29	12.57	3.32	3.28
query30	0.24	0.06	0.07
query31	2.85	0.40	0.38
query32	3.25	0.46	0.45
query33	2.99	3.08	3.07
query34	17.19	4.48	4.44
query35	4.57	4.51	4.52
query36	0.68	0.49	0.49
query37	0.09	0.06	0.06
query38	0.05	0.03	0.04
query39	0.03	0.02	0.02
query40	0.16	0.12	0.13
query41	0.08	0.02	0.02
query42	0.04	0.03	0.02
query43	0.04	0.03	0.04
Total cold run time: 107.38 s
Total hot run time: 33.41 s

…#46946)

Since the comment field is not persisted, the comment will be lost after
the FE is restarted after the comment is modified. This PR adds
persistence to the comment.
@morningman morningman force-pushed the auto-pick-46946-branch-3.0 branch from e9bc13b to 7db36e3 Compare February 24, 2025 10:32
@morningman
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40540 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7db36e30ee9006e09affaa111d183b935fb4b288, data reload: false

------ Round 1 ----------------------------------
q1	17570	7288	7168	7168
q2	2058	180	187	180
q3	10581	1101	1165	1101
q4	10553	730	819	730
q5	7780	2843	2820	2820
q6	235	145	143	143
q7	980	608	603	603
q8	9348	1911	2011	1911
q9	6597	6394	6363	6363
q10	6982	2268	2328	2268
q11	470	271	258	258
q12	405	211	200	200
q13	17780	2954	2988	2954
q14	246	207	206	206
q15	572	520	523	520
q16	679	595	583	583
q17	966	537	540	537
q18	7117	6627	6672	6627
q19	1478	1060	1022	1022
q20	487	216	214	214
q21	3980	3178	3183	3178
q22	1101	954	1009	954
Total cold run time: 107965 ms
Total hot run time: 40540 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7201	7194	7155	7155
q2	339	232	226	226
q3	2886	2836	2946	2836
q4	2034	1724	1775	1724
q5	5703	5749	5753	5749
q6	223	141	140	140
q7	2215	1857	1799	1799
q8	3383	3573	3474	3474
q9	8787	8842	8795	8795
q10	3590	3580	3603	3580
q11	585	511	505	505
q12	787	625	598	598
q13	9461	3157	3159	3157
q14	298	268	284	268
q15	573	530	514	514
q16	690	646	641	641
q17	1818	1621	1592	1592
q18	8192	7861	7793	7793
q19	1660	1546	1508	1508
q20	2044	1864	1903	1864
q21	5501	5440	5393	5393
q22	1105	1073	1032	1032
Total cold run time: 69075 ms
Total hot run time: 60343 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197663 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7db36e30ee9006e09affaa111d183b935fb4b288, data reload: false

query1	1301	899	895	895
query2	6237	2102	2120	2102
query3	10844	4166	4257	4166
query4	61353	28894	23518	23518
query5	5284	441	433	433
query6	390	168	171	168
query7	5445	309	307	307
query8	299	237	222	222
query9	8363	2664	2647	2647
query10	466	269	252	252
query11	17506	15000	15774	15000
query12	156	104	108	104
query13	1487	456	432	432
query14	10843	7576	7598	7576
query15	202	185	172	172
query16	7163	489	416	416
query17	1234	586	577	577
query18	1923	342	308	308
query19	224	168	162	162
query20	117	111	112	111
query21	215	107	101	101
query22	4829	4605	4656	4605
query23	34636	34264	34215	34215
query24	6068	3021	2881	2881
query25	541	423	421	421
query26	654	170	166	166
query27	1820	369	367	367
query28	4075	2473	2425	2425
query29	710	473	415	415
query30	240	162	171	162
query31	1006	822	848	822
query32	67	56	55	55
query33	444	274	290	274
query34	922	501	503	501
query35	849	724	715	715
query36	1091	960	974	960
query37	116	64	64	64
query38	4142	3991	4101	3991
query39	1618	1467	1453	1453
query40	209	105	100	100
query41	63	55	52	52
query42	122	96	100	96
query43	538	507	499	499
query44	1172	821	843	821
query45	185	176	174	174
query46	1151	708	745	708
query47	2051	1957	1938	1938
query48	481	374	383	374
query49	737	398	395	395
query50	857	442	416	416
query51	7391	7210	7300	7210
query52	113	89	91	89
query53	255	183	177	177
query54	557	469	481	469
query55	80	77	80	77
query56	260	245	266	245
query57	1283	1154	1155	1154
query58	247	206	223	206
query59	3087	3008	2850	2850
query60	261	248	257	248
query61	109	107	106	106
query62	814	743	731	731
query63	219	189	184	184
query64	1366	670	635	635
query65	3262	3256	3172	3172
query66	707	295	322	295
query67	15941	15523	15655	15523
query68	4251	597	576	576
query69	428	261	258	258
query70	1197	1146	1131	1131
query71	346	286	247	247
query72	6375	4043	3915	3915
query73	756	348	362	348
query74	10291	8929	9017	8929
query75	3297	2623	2663	2623
query76	2164	1164	1083	1083
query77	483	264	266	264
query78	10622	9571	9585	9571
query79	1522	592	588	588
query80	881	434	427	427
query81	510	236	233	233
query82	1260	92	86	86
query83	243	146	148	146
query84	281	83	86	83
query85	919	308	291	291
query86	342	283	299	283
query87	4390	4278	4423	4278
query88	3878	2368	2353	2353
query89	424	290	287	287
query90	2020	183	184	183
query91	177	149	150	149
query92	66	49	50	49
query93	2024	561	553	553
query94	736	293	302	293
query95	349	269	258	258
query96	615	280	283	280
query97	3311	3209	3182	3182
query98	215	215	199	199
query99	1697	1412	1444	1412
Total cold run time: 314468 ms
Total hot run time: 197663 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.6 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7db36e30ee9006e09affaa111d183b935fb4b288, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.03	0.03
query3	0.23	0.06	0.06
query4	1.62	0.10	0.10
query5	0.53	0.50	0.50
query6	1.13	0.72	0.74
query7	0.02	0.01	0.02
query8	0.05	0.03	0.03
query9	0.57	0.50	0.52
query10	0.55	0.55	0.55
query11	0.14	0.10	0.11
query12	0.13	0.11	0.11
query13	0.60	0.60	0.59
query14	2.69	2.76	2.87
query15	0.89	0.82	0.83
query16	0.38	0.38	0.39
query17	1.01	1.07	0.98
query18	0.24	0.22	0.21
query19	1.98	1.86	2.04
query20	0.01	0.01	0.02
query21	15.36	0.62	0.59
query22	2.56	2.46	1.71
query23	17.03	0.86	0.77
query24	2.76	0.98	1.19
query25	0.14	0.12	0.32
query26	0.38	0.15	0.13
query27	0.05	0.05	0.04
query28	10.80	1.09	1.07
query29	12.58	3.21	3.18
query30	0.25	0.06	0.06
query31	2.86	0.38	0.36
query32	3.26	0.46	0.46
query33	2.98	3.03	3.06
query34	16.95	4.49	4.48
query35	4.57	4.47	4.54
query36	0.67	0.49	0.50
query37	0.10	0.06	0.06
query38	0.04	0.03	0.03
query39	0.03	0.02	0.03
query40	0.17	0.13	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.58 s
Total hot run time: 32.6 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 25, 2025
@github-actions
Copy link
Contributor Author

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor Author

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit a215a63 into branch-3.0 Feb 25, 2025
26 of 29 checks passed
@github-actions github-actions bot deleted the auto-pick-46946-branch-3.0 branch February 25, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants