-
Notifications
You must be signed in to change notification settings - Fork 3.7k
branch-3.0: [fix](external catalog) Persisting the External Catalog comment field #46946 #47270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 41562 ms |
TPC-DS: Total hot run time: 191570 ms |
ClickBench: Total hot run time: 33.41 s |
…#46946) Since the comment field is not persisted, the comment will be lost after the FE is restarted after the comment is modified. This PR adds persistence to the comment.
e9bc13b to
7db36e3
Compare
|
run buildall |
TPC-H: Total hot run time: 40540 ms |
TPC-DS: Total hot run time: 197663 ms |
ClickBench: Total hot run time: 32.6 s |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
Cherry-picked from #46946