Skip to content

Conversation

@wuwenchi
Copy link
Contributor

What problem does this PR solve?

Related PR: #46362

Problem Summary:

For the "target_path" field, when the location is of the S3 type, it should not be converted into the S3 schema.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wuwenchi
Copy link
Contributor Author

run buildall

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 17, 2025
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 32475 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6ac681bc2b0f035d0d151910818d1278a6ed0541, data reload: false

------ Round 1 ----------------------------------
q1	17574	5575	5428	5428
q2	2052	309	175	175
q3	10702	1269	731	731
q4	10204	979	553	553
q5	7546	2445	2136	2136
q6	191	170	134	134
q7	925	767	612	612
q8	9248	1383	1201	1201
q9	5262	4959	4913	4913
q10	6880	2349	1904	1904
q11	490	285	262	262
q12	343	363	229	229
q13	17763	3700	3111	3111
q14	227	237	213	213
q15	527	480	467	467
q16	642	609	598	598
q17	566	878	333	333
q18	7221	6427	6481	6427
q19	2926	959	538	538
q20	310	313	195	195
q21	3031	2199	2008	2008
q22	366	339	307	307
Total cold run time: 104996 ms
Total hot run time: 32475 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5637	5555	5528	5528
q2	237	330	239	239
q3	2295	2670	2331	2331
q4	1447	1826	1385	1385
q5	4389	4766	4871	4766
q6	167	160	128	128
q7	2138	1960	1850	1850
q8	2641	2835	2709	2709
q9	7361	7287	7381	7287
q10	3062	3314	2688	2688
q11	573	525	487	487
q12	674	768	633	633
q13	3567	3916	3352	3352
q14	298	308	275	275
q15	509	487	468	468
q16	665	694	660	660
q17	1246	1771	1254	1254
q18	7909	7512	7308	7308
q19	796	1133	1055	1055
q20	2007	2063	1890	1890
q21	5886	5067	5132	5067
q22	623	600	557	557
Total cold run time: 54127 ms
Total hot run time: 51917 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 195978 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6ac681bc2b0f035d0d151910818d1278a6ed0541, data reload: false

query1	1314	965	947	947
query2	6294	2132	2034	2034
query3	11128	4702	4542	4542
query4	32747	23465	23420	23420
query5	3473	594	439	439
query6	286	182	182	182
query7	3976	502	318	318
query8	281	232	218	218
query9	9286	2603	2577	2577
query10	456	310	251	251
query11	18148	15273	15347	15273
query12	155	107	104	104
query13	1552	523	413	413
query14	9528	7295	7003	7003
query15	262	210	194	194
query16	7940	640	535	535
query17	1607	744	619	619
query18	2170	423	341	341
query19	224	197	180	180
query20	128	130	117	117
query21	209	129	107	107
query22	4595	4443	4414	4414
query23	35130	33714	33491	33491
query24	6804	2344	2407	2344
query25	483	471	416	416
query26	782	280	160	160
query27	2150	473	334	334
query28	5613	2481	2459	2459
query29	647	576	433	433
query30	207	188	160	160
query31	963	877	832	832
query32	87	61	61	61
query33	542	354	313	313
query34	760	870	522	522
query35	814	835	772	772
query36	1011	1070	961	961
query37	126	109	77	77
query38	4414	4298	4301	4298
query39	1509	1459	1463	1459
query40	207	115	105	105
query41	52	56	50	50
query42	116	100	110	100
query43	524	533	513	513
query44	1363	809	818	809
query45	189	172	168	168
query46	873	1057	661	661
query47	1915	1945	1846	1846
query48	387	408	319	319
query49	719	482	425	425
query50	663	682	403	403
query51	7091	7086	7042	7042
query52	105	104	95	95
query53	229	251	194	194
query54	498	525	443	443
query55	88	81	83	81
query56	268	278	282	278
query57	1240	1221	1105	1105
query58	256	249	242	242
query59	3207	3363	3231	3231
query60	289	271	247	247
query61	119	113	121	113
query62	760	712	675	675
query63	228	190	190	190
query64	3498	1058	636	636
query65	3236	3181	3131	3131
query66	779	395	303	303
query67	16177	15767	15964	15767
query68	5261	841	539	539
query69	486	295	262	262
query70	1130	1147	1145	1145
query71	380	280	256	256
query72	5964	3897	3805	3805
query73	653	757	352	352
query74	10653	9015	9119	9015
query75	3242	3170	2705	2705
query76	3090	1175	777	777
query77	467	370	289	289
query78	10264	10058	9392	9392
query79	2989	852	601	601
query80	680	530	462	462
query81	514	280	238	238
query82	510	148	121	121
query83	178	173	150	150
query84	232	94	71	71
query85	771	343	310	310
query86	389	307	290	290
query87	4489	4486	4411	4411
query88	4932	2210	2146	2146
query89	418	329	283	283
query90	1777	186	191	186
query91	132	143	109	109
query92	74	57	53	53
query93	2197	884	534	534
query94	683	409	320	320
query95	325	269	257	257
query96	499	611	289	289
query97	2836	2869	2694	2694
query98	227	199	196	196
query99	1274	1354	1228	1228
Total cold run time: 290593 ms
Total hot run time: 195978 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.84 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6ac681bc2b0f035d0d151910818d1278a6ed0541, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.63	0.10	0.11
query5	0.41	0.42	0.43
query6	1.16	0.67	0.65
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.60	0.49	0.49
query10	0.56	0.56	0.55
query11	0.14	0.10	0.10
query12	0.15	0.12	0.12
query13	0.61	0.61	0.60
query14	2.75	2.89	2.75
query15	0.91	0.84	0.82
query16	0.39	0.39	0.36
query17	1.04	1.00	1.04
query18	0.23	0.21	0.21
query19	2.00	1.82	2.00
query20	0.01	0.01	0.02
query21	15.37	0.96	0.59
query22	0.77	0.99	0.65
query23	15.18	1.45	0.64
query24	2.86	0.99	1.57
query25	0.14	0.25	0.06
query26	0.28	0.15	0.15
query27	0.05	0.06	0.04
query28	14.22	0.99	0.42
query29	12.59	3.96	3.32
query30	0.25	0.09	0.06
query31	2.83	0.62	0.39
query32	3.23	0.55	0.46
query33	3.04	3.01	3.02
query34	16.41	5.24	4.54
query35	4.52	4.58	4.56
query36	0.64	0.49	0.49
query37	0.09	0.07	0.06
query38	0.04	0.03	0.03
query39	0.03	0.02	0.02
query40	0.16	0.14	0.12
query41	0.08	0.02	0.02
query42	0.04	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 105.83 s
Total hot run time: 30.84 s

@morningman morningman added usercase Important user case type label dev/2.1.x dev/3.0.x labels Jan 22, 2025
@morningman morningman merged commit 7d49851 into apache:master Jan 22, 2025
29 of 30 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 22, 2025
### What problem does this PR solve?

Related PR: #46362

Problem Summary:

For the "target_path" field, when the location is of the S3 type, it
should not be converted into the S3 schema.
wuwenchi added a commit to wuwenchi/doris that referenced this pull request Jan 23, 2025
Related PR: apache#46362

Problem Summary:

For the "target_path" field, when the location is of the S3 type, it
should not be converted into the S3 schema.
lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
### What problem does this PR solve?

Related PR: apache#46362

Problem Summary:

For the "target_path" field, when the location is of the S3 type, it
should not be converted into the S3 schema.
dataroaring pushed a commit that referenced this pull request Feb 22, 2025
…47162 (#47329)

Cherry-picked from #47162

Co-authored-by: wuwenchi <wuwenchi@selectdb.com>
@yiguolei yiguolei mentioned this pull request Mar 25, 2025
@gavinchou gavinchou mentioned this pull request Apr 23, 2025
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
### What problem does this PR solve?

Related PR: apache#46362

Problem Summary:

For the "target_path" field, when the location is of the S3 type, it
should not be converted into the S3 schema.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.9-merged dev/3.0.5-merged reviewed usercase Important user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants