Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #47162

### What problem does this PR solve?

Related PR: #46362

Problem Summary:

For the "target_path" field, when the location is of the S3 type, it
should not be converted into the S3 schema.
@github-actions github-actions bot requested a review from dataroaring as a code owner January 22, 2025 14:33
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jan 22, 2025
@hello-stephen
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41218 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 236619c2eb96a1103bb8e1814bae221e9e5bb9c1, data reload: false

------ Round 1 ----------------------------------
q1	17622	7660	7241	7241
q2	2063	179	163	163
q3	10543	1161	1204	1161
q4	10359	779	733	733
q5	7819	3011	2908	2908
q6	243	151	148	148
q7	982	637	625	625
q8	9434	1956	2011	1956
q9	6587	6416	6461	6416
q10	7210	2393	2351	2351
q11	491	265	273	265
q12	404	219	211	211
q13	17773	2998	3008	2998
q14	236	207	209	207
q15	563	536	519	519
q16	699	616	618	616
q17	980	640	536	536
q18	7234	6641	6752	6641
q19	1395	1068	1145	1068
q20	469	206	196	196
q21	4080	3271	3286	3271
q22	1142	1031	988	988
Total cold run time: 108328 ms
Total hot run time: 41218 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7250	7220	7205	7205
q2	326	237	233	233
q3	2982	2957	3053	2957
q4	2069	1911	1861	1861
q5	5747	5746	5758	5746
q6	230	149	143	143
q7	2308	1823	1725	1725
q8	3616	3524	3534	3524
q9	8917	8886	8775	8775
q10	3580	3600	3578	3578
q11	612	479	505	479
q12	817	612	612	612
q13	8448	3147	3202	3147
q14	302	276	289	276
q15	584	518	500	500
q16	737	681	687	681
q17	1829	1601	1586	1586
q18	8381	7525	7611	7525
q19	1674	1550	1512	1512
q20	2124	1838	1896	1838
q21	5491	5394	5348	5348
q22	1140	1060	1086	1060
Total cold run time: 69164 ms
Total hot run time: 60311 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197527 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 236619c2eb96a1103bb8e1814bae221e9e5bb9c1, data reload: false

query1	1239	921	914	914
query2	6237	2043	2102	2043
query3	10917	4354	4443	4354
query4	66561	28753	23444	23444
query5	4959	464	487	464
query6	430	189	197	189
query7	5662	309	310	309
query8	315	224	223	223
query9	9461	2683	2680	2680
query10	475	281	268	268
query11	17525	15164	15792	15164
query12	161	105	107	105
query13	1548	474	456	456
query14	10992	7071	6867	6867
query15	214	190	182	182
query16	7135	523	534	523
query17	1046	616	620	616
query18	1860	349	330	330
query19	256	182	167	167
query20	120	110	113	110
query21	208	107	106	106
query22	4826	4467	4389	4389
query23	34663	34554	34632	34554
query24	6135	2901	2919	2901
query25	564	407	410	407
query26	675	170	172	170
query27	1849	355	354	354
query28	4371	2483	2458	2458
query29	697	448	459	448
query30	250	162	170	162
query31	1003	825	829	825
query32	70	58	59	58
query33	470	300	278	278
query34	916	512	513	512
query35	871	735	731	731
query36	1094	931	961	931
query37	120	73	74	73
query38	4258	4037	4091	4037
query39	1533	1445	1412	1412
query40	195	95	96	95
query41	49	47	48	47
query42	110	99	99	99
query43	533	490	494	490
query44	1167	812	812	812
query45	179	159	161	159
query46	1157	729	695	695
query47	1929	1832	1861	1832
query48	469	369	368	368
query49	719	377	378	377
query50	811	417	420	417
query51	7260	7059	7225	7059
query52	105	92	88	88
query53	255	183	178	178
query54	563	450	458	450
query55	79	82	74	74
query56	273	236	242	236
query57	1226	1126	1114	1114
query58	215	209	201	201
query59	3131	2882	2971	2882
query60	288	253	253	253
query61	116	105	117	105
query62	757	660	676	660
query63	216	197	193	193
query64	1381	695	639	639
query65	3256	3235	3179	3179
query66	708	307	305	305
query67	15814	15654	15587	15587
query68	3611	583	588	583
query69	430	265	260	260
query70	1191	1078	1122	1078
query71	361	257	285	257
query72	6202	4076	4037	4037
query73	771	345	353	345
query74	10035	9064	9049	9049
query75	3374	2655	2632	2632
query76	1821	1067	1091	1067
query77	449	270	276	270
query78	10584	9781	9559	9559
query79	1262	586	603	586
query80	888	444	431	431
query81	507	244	244	244
query82	1280	117	114	114
query83	225	153	139	139
query84	284	83	78	78
query85	891	306	306	306
query86	347	298	308	298
query87	4432	4313	4309	4309
query88	3611	2376	2354	2354
query89	423	292	285	285
query90	2011	198	191	191
query91	184	149	149	149
query92	71	52	53	52
query93	1581	543	550	543
query94	803	288	304	288
query95	349	260	278	260
query96	627	280	283	280
query97	3299	3264	3199	3199
query98	213	203	195	195
query99	1635	1281	1313	1281
Total cold run time: 318399 ms
Total hot run time: 197527 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.05 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 236619c2eb96a1103bb8e1814bae221e9e5bb9c1, data reload: false

query1	0.04	0.03	0.03
query2	0.06	0.03	0.03
query3	0.24	0.07	0.06
query4	1.63	0.10	0.10
query5	0.52	0.51	0.50
query6	1.13	0.73	0.73
query7	0.02	0.01	0.01
query8	0.04	0.03	0.02
query9	0.55	0.52	0.49
query10	0.55	0.55	0.57
query11	0.15	0.10	0.11
query12	0.14	0.10	0.11
query13	0.62	0.60	0.59
query14	3.04	2.95	2.91
query15	0.89	0.84	0.82
query16	0.38	0.37	0.38
query17	0.98	0.96	1.00
query18	0.23	0.21	0.21
query19	1.89	1.74	1.96
query20	0.02	0.01	0.01
query21	15.36	0.60	0.60
query22	2.55	2.76	1.62
query23	17.26	0.96	0.72
query24	3.01	0.40	1.48
query25	0.23	0.08	0.18
query26	0.40	0.14	0.13
query27	0.07	0.05	0.04
query28	11.07	1.10	1.07
query29	12.57	3.33	3.29
query30	0.25	0.06	0.06
query31	2.87	0.37	0.40
query32	3.25	0.45	0.45
query33	3.03	3.05	3.05
query34	16.98	4.52	4.50
query35	4.55	4.55	4.60
query36	0.68	0.49	0.50
query37	0.09	0.06	0.06
query38	0.04	0.03	0.04
query39	0.04	0.02	0.03
query40	0.16	0.13	0.12
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 107.74 s
Total hot run time: 32.05 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 06302d2 into branch-3.0 Feb 22, 2025
23 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-47162-branch-3.0 branch February 22, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants