[fix](load) return DataQualityError when filtered rows exceeds limit #47617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
TPC-H: Total hot run time: 31865 ms |
TPC-DS: Total hot run time: 192159 ms |
ClickBench: Total hot run time: 30.22 s |
kaijchen
commented
Feb 12, 2025
Member
Author
|
run buildall |
TPC-H: Total hot run time: 31535 ms |
TPC-DS: Total hot run time: 183577 ms |
ClickBench: Total hot run time: 30.84 s |
|
TeamCity be ut coverage result: |
Member
Author
|
run buildall |
TPC-H: Total hot run time: 31806 ms |
TPC-DS: Total hot run time: 190925 ms |
ClickBench: Total hot run time: 30.67 s |
|
TeamCity be ut coverage result: |
Member
Author
|
run buildall |
TPC-H: Total hot run time: 31282 ms |
TPC-DS: Total hot run time: 189660 ms |
ClickBench: Total hot run time: 29.88 s |
|
TeamCity be ut coverage result: |
Member
Author
|
run buildall |
TPC-H: Total hot run time: 31545 ms |
TPC-DS: Total hot run time: 189477 ms |
ClickBench: Total hot run time: 30.26 s |
|
TeamCity be ut coverage result: |
dataroaring
reviewed
Feb 18, 2025
| auto st = _validate_data(state, block.get(), rows, filtered_rows, &stop_processing); | ||
| _num_filtered_rows += filtered_rows; | ||
| has_filtered_rows = filtered_rows > 0; | ||
| if (stop_processing) { |
Contributor
There was a problem hiding this comment.
Can we remove stop_processing?
Member
Author
|
run buildall |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Member
Author
|
run buildall |
TPC-H: Total hot run time: 32428 ms |
TPC-DS: Total hot run time: 192986 ms |
ClickBench: Total hot run time: 30.81 s |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
liaoxin01
approved these changes
Mar 14, 2025
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
Mar 20, 2025
…pache#47617) Issue Number: DORIS-17408 Problem Summary: When the load is canceled due to an excessive number of filtered rows in `CsvReader`, the end of stream flag is set, but an error is not returned. As a result, the following confusing message is shown to the user: ```json "Message": "[CANCELLED]cancelled: closed", ``` This PR addresses the issue by returning a `DataQualityError` in such cases. The updated message will be: ```json "Message": "[CANCELLED]cancelled: [DATA_QUALITY_ERROR]Encountered unqualified data, stop processing. cur path: .", ```
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
Mar 20, 2025
…pache#47617) Issue Number: DORIS-17408 Problem Summary: When the load is canceled due to an excessive number of filtered rows in `CsvReader`, the end of stream flag is set, but an error is not returned. As a result, the following confusing message is shown to the user: ```json "Message": "[CANCELLED]cancelled: closed", ``` This PR addresses the issue by returning a `DataQualityError` in such cases. The updated message will be: ```json "Message": "[CANCELLED]cancelled: [DATA_QUALITY_ERROR]Encountered unqualified data, stop processing. cur path: .", ```
This was referenced Mar 20, 2025
dataroaring
pushed a commit
that referenced
this pull request
Mar 25, 2025
yiguolei
pushed a commit
that referenced
this pull request
Apr 2, 2025
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…pache#47617) ### What problem does this PR solve? Issue Number: DORIS-17408 Problem Summary: When the load is canceled due to an excessive number of filtered rows in `CsvReader`, the end of stream flag is set, but an error is not returned. As a result, the following confusing message is shown to the user: ```json "Message": "[CANCELLED]cancelled: closed", ``` This PR addresses the issue by returning a `DataQualityError` in such cases. The updated message will be: ```json "Message": "[CANCELLED]cancelled: [DATA_QUALITY_ERROR]Encountered unqualified data, stop processing. cur path: .", ```
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: DORIS-17408
Problem Summary:
When the load is canceled due to an excessive number of filtered rows in
CsvReader, the end of stream flag is set, but an error is not returned. As a result, the following confusing message is shown to the user:This PR addresses the issue by returning a
DataQualityErrorin such cases. The updated message will be:Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)