-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](load) return DataQualityError when filtered rows exceeds limit (#47617) #49287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…pache#47617) Issue Number: DORIS-17408 Problem Summary: When the load is canceled due to an excessive number of filtered rows in `CsvReader`, the end of stream flag is set, but an error is not returned. As a result, the following confusing message is shown to the user: ```json "Message": "[CANCELLED]cancelled: closed", ``` This PR addresses the issue by returning a `DataQualityError` in such cases. The updated message will be: ```json "Message": "[CANCELLED]cancelled: [DATA_QUALITY_ERROR]Encountered unqualified data, stop processing. cur path: .", ```
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 40339 ms |
TPC-DS: Total hot run time: 198279 ms |
ClickBench: Total hot run time: 32.12 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
backport #47617