Skip to content

[fix](function)Fix split_by_regexp function integer parameter couldn't set bug. #47676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jibing-Li merged 1 commit into from
Feb 10, 2025
Merged

[fix](function)Fix split_by_regexp function integer parameter couldn't set bug. #47676

Jibing-Li merged 1 commit into from
Feb 10, 2025

Conversation

@Jibing-Li
Copy link
Contributor

@Jibing-Li Jibing-Li commented Feb 10, 2025 •
edited by morningman
Loading

What problem does this PR solve?

split_by_regexp function's third parameter doesn't support tinyint. This pr is to fix it.

mysql> select split_by_regexp('aa,bb,cc', ',', 1);
ERROR 1105 (HY000): errCode = 2, detailMessage = the third parameter of split_by_regexp function must be a positive constant: split_by_regexp('aa,bb,cc', ',', 1)

Related PR: #38259

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Feb 10, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Jibing-Li Jibing-Li marked this pull request as ready for review February 10, 2025 03:39
@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Feb 10, 2025

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Feb 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2025

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Feb 10, 2025

TPC-H: Total hot run time: 31709 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 71d07af295f6254e6b7d61d7035df22b852b469e, data reload: false

------ Round 1 ----------------------------------
q1	17578	5230	5017	5017
q2	2050	304	164	164
q3	10591	1263	765	765
q4	10205	1039	538	538
q5	7543	2406	2328	2328
q6	190	164	134	134
q7	902	748	593	593
q8	9304	1274	1150	1150
q9	4892	4762	4769	4762
q10	6827	2325	1893	1893
q11	500	270	252	252
q12	357	386	221	221
q13	17775	3674	3071	3071
q14	234	227	211	211
q15	496	472	441	441
q16	628	618	568	568
q17	599	882	354	354
q18	6761	6292	6319	6292
q19	1577	959	558	558
q20	337	325	191	191
q21	2838	2214	1909	1909
q22	366	325	297	297
Total cold run time: 102550 ms
Total hot run time: 31709 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5142	5153	5099	5099
q2	235	324	230	230
q3	2130	2693	2318	2318
q4	1442	1811	1336	1336
q5	4218	4115	4152	4115
q6	209	165	130	130
q7	1887	1815	1701	1701
q8	2613	2602	2598	2598
q9	7289	7198	7157	7157
q10	3026	3207	2778	2778
q11	589	525	505	505
q12	680	815	640	640
q13	3527	3983	3326	3326
q14	283	291	271	271
q15	499	482	448	448
q16	655	680	654	654
q17	1168	1596	1357	1357
q18	7568	7432	7297	7297
q19	856	885	955	885
q20	1999	2025	1854	1854
q21	5371	5064	4686	4686
q22	654	580	570	570
Total cold run time: 52040 ms
Total hot run time: 49955 ms

@doris-robot
Copy link

doris-robot commented Feb 10, 2025

TPC-DS: Total hot run time: 190250 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 71d07af295f6254e6b7d61d7035df22b852b469e, data reload: false

query1	1298	952	934	934
query2	6266	1909	1866	1866
query3	10993	4595	4440	4440
query4	52971	26189	23135	23135
query5	4985	637	461	461
query6	318	189	178	178
query7	4859	506	289	289
query8	293	239	246	239
query9	5496	2510	2510	2510
query10	419	332	263	263
query11	15223	15026	14872	14872
query12	153	110	105	105
query13	1026	486	366	366
query14	10286	6962	6772	6772
query15	215	205	188	188
query16	7193	661	497	497
query17	1073	699	594	594
query18	1729	404	307	307
query19	202	200	160	160
query20	128	119	125	119
query21	212	128	120	120
query22	4555	4397	4262	4262
query23	34383	33120	33529	33120
query24	5700	2434	2447	2434
query25	474	492	438	438
query26	707	288	176	176
query27	1709	486	346	346
query28	2768	2464	2389	2389
query29	599	560	429	429
query30	215	198	155	155
query31	904	869	829	829
query32	69	63	62	62
query33	429	381	301	301
query34	800	867	511	511
query35	815	835	765	765
query36	961	993	905	905
query37	130	110	82	82
query38	4273	4369	4330	4330
query39	1536	1441	1440	1440
query40	212	124	107	107
query41	58	55	54	54
query42	127	106	110	106
query43	518	513	504	504
query44	1362	820	827	820
query45	182	179	171	171
query46	910	1067	662	662
query47	1846	1875	1771	1771
query48	411	438	317	317
query49	707	555	446	446
query50	735	757	431	431
query51	4300	4299	4218	4218
query52	116	145	109	109
query53	246	263	184	184
query54	483	516	406	406
query55	87	81	81	81
query56	288	279	256	256
query57	1200	1184	1124	1124
query58	246	240	252	240
query59	2759	2977	2921	2921
query60	290	338	276	276
query61	117	111	116	111
query62	737	741	684	684
query63	236	192	197	192
query64	1760	1000	665	665
query65	3254	3165	3144	3144
query66	774	385	296	296
query67	15935	15577	15371	15371
query68	6034	760	499	499
query69	527	302	265	265
query70	1194	1078	1101	1078
query71	435	283	253	253
query72	5997	3750	3762	3750
query73	1294	749	338	338
query74	8978	9262	8884	8884
query75	3200	3155	2657	2657
query76	3856	1176	776	776
query77	511	372	286	286
query78	10134	10033	9378	9378
query79	3157	804	574	574
query80	837	507	550	507
query81	510	287	240	240
query82	1208	158	127	127
query83	191	167	153	153
query84	294	95	72	72
query85	768	339	294	294
query86	381	307	265	265
query87	4466	4525	4355	4355
query88	3662	2160	2158	2158
query89	408	316	277	277
query90	1595	188	190	188
query91	133	133	109	109
query92	73	64	56	56
query93	2762	1003	571	571
query94	834	399	288	288
query95	344	265	264	264
query96	481	556	271	271
query97	2815	2814	2740	2740
query98	224	213	203	203
query99	1319	1403	1318	1318
Total cold run time: 294883 ms
Total hot run time: 190250 ms

@doris-robot
Copy link

doris-robot commented Feb 10, 2025

ClickBench: Total hot run time: 30.11 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 71d07af295f6254e6b7d61d7035df22b852b469e, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.06	0.06
query4	1.61	0.10	0.10
query5	0.41	0.41	0.40
query6	1.18	0.66	0.64
query7	0.03	0.02	0.01
query8	0.04	0.03	0.03
query9	0.61	0.52	0.51
query10	0.58	0.59	0.58
query11	0.15	0.11	0.11
query12	0.14	0.11	0.11
query13	0.62	0.60	0.61
query14	2.68	2.79	2.72
query15	0.94	0.85	0.86
query16	0.37	0.36	0.37
query17	1.02	1.01	1.09
query18	0.21	0.19	0.20
query19	1.95	1.82	2.01
query20	0.02	0.00	0.02
query21	15.35	0.86	0.55
query22	0.79	1.05	0.62
query23	15.08	1.43	0.61
query24	8.09	0.88	0.37
query25	0.49	0.24	0.12
query26	0.63	0.17	0.14
query27	0.05	0.05	0.05
query28	9.23	0.84	0.42
query29	12.58	4.01	3.31
query30	0.27	0.09	0.06
query31	2.83	0.58	0.38
query32	3.22	0.54	0.47
query33	3.01	3.04	3.13
query34	15.74	5.16	4.51
query35	4.51	4.51	4.56
query36	0.66	0.50	0.47
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.18	0.13	0.13
query41	0.08	0.04	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.95 s
Total hot run time: 30.11 s

@Jibing-Li Jibing-Li merged commit fbdb4f4 into apache:master Feb 10, 2025
32 of 34 checks passed
@Jibing-Li Jibing-Li deleted the split branch February 10, 2025 07:36
@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Feb 10, 2025 •
edited
Loading

The related pr #38259 is not merged into 2.1.x or 3.0.x, so remove the branch pick label

lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
@Jibing-Li @lzyy2024
[fix](function)Fix split_by_regexp function integer parameter couldn'…
7446eec 
…t set bug. (apache#47676)

### What problem does this PR solve?

split_by_regexp function's third parameter doesn't support tinyint. This
pr is to fix it.

```
mysql> select split_by_regexp('aa,bb,cc', ',', 1);
ERROR 1105 (HY000): errCode = 2, detailMessage = the third parameter of split_by_regexp function must be a positive constant: split_by_regexp('aa,bb,cc', ',', 1)
```
zhangstar333 pushed a commit to zhangstar333/incubator-doris that referenced this pull request Apr 22, 2025
@Jibing-Li @zhangstar333
[fix](function)Fix split_by_regexp function integer parameter couldn'…
d00c555 
…t set bug. (apache#47676)

### What problem does this PR solve?

split_by_regexp function's third parameter doesn't support tinyint. This
pr is to fix it.

```
mysql> select split_by_regexp('aa,bb,cc', ',', 1);
ERROR 1105 (HY000): errCode = 2, detailMessage = the third parameter of split_by_regexp function must be a positive constant: split_by_regexp('aa,bb,cc', ',', 1)
```
@morningman morningman mentioned this pull request Apr 22, 2025
Merged
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@Jibing-Li
[fix](function)Fix split_by_regexp function integer parameter couldn'…
6030981 
…t set bug. (apache#47676)

### What problem does this PR solve?

split_by_regexp function's third parameter doesn't support tinyint. This
pr is to fix it.

```
mysql> select split_by_regexp('aa,bb,cc', ',', 1);
ERROR 1105 (HY000): errCode = 2, detailMessage = the third parameter of split_by_regexp function must be a positive constant: split_by_regexp('aa,bb,cc', ',', 1)
```
dataroaring pushed a commit that referenced this pull request Jun 18, 2025
@zhangstar333 @Jibing-Li
[cherry-pick](branch-30) support split_by_regexp (#38259) (#47676) (#…
d499904 
…50272)

bp (#38259) (#47676)
also need pick #51293

---------

Co-authored-by: James <lijibing@selectdb.com>
zhangstar333 pushed a commit to zhangstar333/incubator-doris that referenced this pull request Jun 20, 2025
@Jibing-Li @zhangstar333
[fix](function)Fix split_by_regexp function integer parameter couldn'…
966a91e 
…t set bug. (apache#47676)

### What problem does this PR solve?

split_by_regexp function's third parameter doesn't support tinyint. This
pr is to fix it.

```
mysql> select split_by_regexp('aa,bb,cc', ',', 1);
ERROR 1105 (HY000): errCode = 2, detailMessage = the third parameter of split_by_regexp function must be a positive constant: split_by_regexp('aa,bb,cc', ',', 1)
```
@zhangstar333 zhangstar333 mentioned this pull request Jun 20, 2025
Merged
16 tasks
morrySnow pushed a commit that referenced this pull request Jun 20, 2025
@zhangstar333 @Jibing-Li
[cherry-pick](branch-31) pick 4 prs #38259 #47676 #51293 #49381 (#52005)
d538b6f 
pick from master #38259 #47676 #51293 #49381 


Co-authored-by: James <lijibing@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starocean999 starocean999 starocean999 approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.7-merged dev/3.1.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Jibing-Li @Thearas @doris-robot @starocean999 @morrySnow @morningman @dataroaring