Skip to content

[cherry-pick](branch-30) support split_by_regexp (#38259) (#47676) #50272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 2 commits into from
Jun 18, 2025
Merged

[cherry-pick](branch-30) support split_by_regexp (#38259) (#47676) #50272

dataroaring merged 2 commits into from
Jun 18, 2025

Conversation

@zhangstar333
Copy link
Contributor

@zhangstar333 zhangstar333 commented Apr 22, 2025 •
edited
Loading

bp (#38259) (#47676)
also need pick #51293

zhangstar333 and others added 2 commits April 22, 2025 10:54
@zhangstar333
[Feature](function) support split_by_regexp function (apache#38259)
6828d3e 
docs link:
apache/doris-website#904

<!--Describe your changes.-->
@Jibing-Li @zhangstar333
[fix](function)Fix split_by_regexp function integer parameter couldn'…
d00c555 
…t set bug. (apache#47676)

### What problem does this PR solve?

split_by_regexp function's third parameter doesn't support tinyint. This
pr is to fix it.

```
mysql> select split_by_regexp('aa,bb,cc', ',', 1);
ERROR 1105 (HY000): errCode = 2, detailMessage = the third parameter of split_by_regexp function must be a positive constant: split_by_regexp('aa,bb,cc', ',', 1)
```
@Thearas
Copy link
Contributor

Thearas commented Apr 22, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangstar333
Copy link
Contributor Author

zhangstar333 commented Apr 22, 2025

run buildall

@morningman morningman changed the title [cherry-pick](branch-30) pick (#38259) (#47676) [cherry-pick](branch-30) support split_by_regexp (#38259) (#47676) Apr 22, 2025
@doris-robot
Copy link

doris-robot commented Apr 22, 2025

TeamCity cloud ut coverage result:
Function Coverage: 83.00% (1084/1306)
Line Coverage: 65.97% (17940/27194)
Region Coverage: 65.51% (8847/13505)
Branch Coverage: 55.47% (4779/8616)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d00c555161c6c704b164894b707a5a061856c22b_d00c555161c6c704b164894b707a5a061856c22b_cloud/report/index.html

@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 22, 2025

BE UT Coverage Report

Increment line coverage 6.94% (17/245) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 40.15% (10527/26219)
Line Coverage 30.83% (88660/287559)
Region Coverage 29.94% (45673/152528)
Branch Coverage 26.35% (23196/88028)

HappenLee
HappenLee approved these changes Jun 13, 2025
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 13, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2025

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Jun 18, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit d499904 into apache:branch-3.0 Jun 18, 2025
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HappenLee HappenLee HappenLee approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@zhangstar333 @Thearas @doris-robot @hello-stephen @HappenLee @dataroaring @Jibing-Li