[Fix](cloud-mow) Compaciton should release delete bitmap lock when abort fail #47766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmit or abort fail
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31420 ms |
TPC-DS: Total hot run time: 184540 ms |
ClickBench: Total hot run time: 29.91 s |
|
TeamCity be ut coverage result: |
Contributor
Author
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 31629 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 189201 ms |
ClickBench: Total hot run time: 30.45 s |
zhannngchen
reviewed
Feb 11, 2025
zhannngchen
reviewed
Feb 11, 2025
| << ",tablet_id=" << tablet_id << ",lock_id=" << lock_id | ||
| << ",st=" << st.to_string(); | ||
| } | ||
| return st; |
Contributor
There was a problem hiding this comment.
Why not return the status?
Contributor
Author
There was a problem hiding this comment.
remove_delete_bitmap_update_lock just try to release lock, some times it may fail, like lock id not found beacause lock is expired and loading task has already taken the lock, in this situation, we can do nothing, just print a warnning lock is enought, so no need to return a wrong statu
Contributor
Author
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 31361 ms |
TPC-DS: Total hot run time: 190200 ms |
ClickBench: Total hot run time: 30.23 s |
|
TeamCity be ut coverage result: |
zhannngchen
reviewed
Feb 12, 2025
Contributor
Author
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 31345 ms |
TPC-DS: Total hot run time: 183628 ms |
ClickBench: Total hot run time: 30.63 s |
|
TeamCity be ut coverage result: |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
luwei16
reviewed
Feb 13, 2025
| // will release if abort job successfully, but if abort failed, delete bitmap | ||
| // lock will not release, in this situation, be need to send this rpc to ms | ||
| // to try to release delete bitmap lock. | ||
| _engine.meta_mgr().remove_delete_bitmap_update_lock( |
Contributor
There was a problem hiding this comment.
"If the RPC to release the lock fails here, will the lock still not be released?"
Contributor
Author
There was a problem hiding this comment.
Yes, this pr just try to release lock, it may fail on TXN_KV_CONFICT, this problem has existed for a long time, if release rpc fail, this lock will be released when lock is expired.
Contributor
There was a problem hiding this comment.
@luwei16 It's ok if the rpc failed to release lock here, it's the same with rpc failed on commit phase.
luwei16
approved these changes
Feb 14, 2025
16 tasks
lzyy2024
pushed a commit
to lzyy2024/doris
that referenced
this pull request
Feb 21, 2025
…ort fail (apache#47766) ### What problem does this PR solve? When trigger cu or base compaciton with full compaction in the same time, compaciton may abort fail, delete bitmap lock will hold by the failed compaciton, in this situation, need to release delete bitmap lock.
Closed
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…ort fail (apache#47766) ### What problem does this PR solve? When trigger cu or base compaciton with full compaction in the same time, compaciton may abort fail, delete bitmap lock will hold by the failed compaciton, in this situation, need to release delete bitmap lock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When trigger cu or base compaciton with full compaction in the same time, compaciton may abort fail, delete bitmap lock will hold by the failed compaciton, in this situation, need to release delete bitmap lock.
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)