Skip to content

Conversation

@hust-hhb
Copy link
Contributor

pick pr #47766

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hust-hhb
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

TeamCity cloud ut coverage result:
Function Coverage: 82.36% (1060/1287)
Line Coverage: 65.90% (17587/26686)
Region Coverage: 65.41% (8665/13248)
Branch Coverage: 55.40% (4680/8448)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5b6d6e4cf979a5bdd4be4d036740a48fa4591ac3_5b6d6e4cf979a5bdd4be4d036740a48fa4591ac3_cloud/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 40875 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5b6d6e4cf979a5bdd4be4d036740a48fa4591ac3, data reload: false

------ Round 1 ----------------------------------
q1	17846	7416	7256	7256
q2	2084	176	173	173
q3	10585	1118	1195	1118
q4	10585	768	737	737
q5	7748	2889	2850	2850
q6	236	146	145	145
q7	993	610	606	606
q8	9357	1897	2028	1897
q9	6643	6415	6390	6390
q10	7006	2320	2297	2297
q11	463	261	262	261
q12	405	208	218	208
q13	17772	2987	3016	2987
q14	244	211	212	211
q15	570	531	525	525
q16	652	590	578	578
q17	970	619	551	551
q18	7294	6577	6714	6577
q19	1425	1133	1074	1074
q20	474	205	201	201
q21	3954	3285	3262	3262
q22	1102	975	971	971
Total cold run time: 108408 ms
Total hot run time: 40875 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7201	7185	7189	7185
q2	335	231	229	229
q3	2937	2962	2983	2962
q4	2036	1820	1784	1784
q5	5735	5728	5699	5699
q6	219	139	139	139
q7	2270	1808	1836	1808
q8	3341	3582	3518	3518
q9	8847	9001	8877	8877
q10	3623	3564	3596	3564
q11	597	511	504	504
q12	791	618	650	618
q13	9612	3115	3187	3115
q14	302	278	267	267
q15	569	520	533	520
q16	699	649	678	649
q17	1843	1659	1589	1589
q18	8367	7826	7482	7482
q19	1659	1612	1538	1538
q20	2103	1901	1901	1901
q21	5459	5367	5343	5343
q22	1166	1054	1027	1027
Total cold run time: 69711 ms
Total hot run time: 60318 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 199145 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5b6d6e4cf979a5bdd4be4d036740a48fa4591ac3, data reload: false

query1	1299	931	901	901
query2	6238	2128	2092	2092
query3	10860	4335	4401	4335
query4	66379	28758	23676	23676
query5	5032	474	444	444
query6	407	174	187	174
query7	5529	322	306	306
query8	312	225	229	225
query9	8713	2742	2692	2692
query10	476	269	259	259
query11	17505	15225	15904	15225
query12	165	113	108	108
query13	1504	438	435	435
query14	10133	7417	7204	7204
query15	201	184	179	179
query16	7067	470	466	466
query17	1109	594	568	568
query18	1840	322	321	321
query19	215	159	158	158
query20	116	116	114	114
query21	207	110	109	109
query22	4765	4498	4565	4498
query23	34756	34952	34924	34924
query24	6102	2919	2970	2919
query25	527	421	422	421
query26	668	174	174	174
query27	1777	364	369	364
query28	4001	2510	2462	2462
query29	724	483	476	476
query30	243	167	169	167
query31	1044	830	844	830
query32	78	62	66	62
query33	464	293	303	293
query34	925	529	527	527
query35	848	766	732	732
query36	1063	990	990	990
query37	130	75	78	75
query38	4070	3986	4001	3986
query39	1524	1488	1490	1488
query40	206	99	101	99
query41	51	46	47	46
query42	115	102	96	96
query43	553	529	509	509
query44	1192	826	837	826
query45	188	167	168	167
query46	1153	750	748	748
query47	1994	1868	1886	1868
query48	467	378	400	378
query49	714	389	378	378
query50	858	437	426	426
query51	7241	7288	7181	7181
query52	99	91	87	87
query53	260	181	181	181
query54	558	440	443	440
query55	78	75	73	73
query56	261	249	238	238
query57	1246	1123	1079	1079
query58	215	202	211	202
query59	3223	2989	3049	2989
query60	303	259	251	251
query61	106	116	111	111
query62	830	720	747	720
query63	215	187	184	184
query64	1367	682	643	643
query65	3287	3198	3188	3188
query66	682	305	333	305
query67	16070	15938	15533	15533
query68	4068	591	580	580
query69	455	281	260	260
query70	1177	1075	1115	1075
query71	359	265	276	265
query72	6079	4146	3953	3953
query73	775	354	359	354
query74	10378	9146	9117	9117
query75	3359	2631	2659	2631
query76	2063	1111	1059	1059
query77	503	277	265	265
query78	10506	9687	9550	9550
query79	1356	597	593	593
query80	1023	422	418	418
query81	528	242	243	242
query82	208	118	114	114
query83	163	146	147	146
query84	283	93	75	75
query85	998	298	327	298
query86	395	313	308	308
query87	4481	4303	4343	4303
query88	4083	2409	2367	2367
query89	410	290	297	290
query90	2008	188	183	183
query91	183	148	148	148
query92	65	53	48	48
query93	2068	557	553	553
query94	876	305	288	288
query95	354	257	259	257
query96	628	288	281	281
query97	3319	3184	3183	3183
query98	215	202	198	198
query99	1714	1433	1418	1418
Total cold run time: 317628 ms
Total hot run time: 199145 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.05 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5b6d6e4cf979a5bdd4be4d036740a48fa4591ac3, data reload: false

query1	0.04	0.03	0.02
query2	0.08	0.03	0.03
query3	0.24	0.07	0.06
query4	1.62	0.10	0.10
query5	0.53	0.52	0.53
query6	1.14	0.74	0.74
query7	0.01	0.01	0.02
query8	0.04	0.03	0.03
query9	0.57	0.51	0.50
query10	0.55	0.55	0.56
query11	0.15	0.10	0.11
query12	0.14	0.13	0.11
query13	0.60	0.59	0.60
query14	2.72	2.86	2.75
query15	0.91	0.83	0.83
query16	0.37	0.38	0.38
query17	0.99	1.07	1.06
query18	0.23	0.21	0.22
query19	1.98	1.81	2.02
query20	0.02	0.01	0.02
query21	15.36	0.60	0.58
query22	2.94	2.25	1.96
query23	17.14	1.01	0.90
query24	2.94	1.56	1.05
query25	0.24	0.09	0.26
query26	0.37	0.14	0.15
query27	0.04	0.04	0.04
query28	10.08	1.10	1.07
query29	12.58	3.23	3.23
query30	0.25	0.06	0.07
query31	2.84	0.39	0.37
query32	3.26	0.46	0.45
query33	3.00	2.96	3.06
query34	17.17	4.44	4.48
query35	4.49	4.49	4.50
query36	0.69	0.49	0.49
query37	0.09	0.06	0.07
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.17	0.13	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 106.8 s
Total hot run time: 33.05 s

Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 21, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit a731643 into apache:branch-3.0 Feb 22, 2025
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants