-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improve](load) print error string in local fs error messages #47918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
run buildall |
TPC-H: Total hot run time: 31471 ms |
TPC-DS: Total hot run time: 182846 ms |
ClickBench: Total hot run time: 30.7 s |
|
run buildall |
TPC-H: Total hot run time: 31208 ms |
TPC-DS: Total hot run time: 183332 ms |
ClickBench: Total hot run time: 30.61 s |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
TeamCity be ut coverage result: |
Issue Number: DORIS-18704 Problem Summary: Human-readable error messages should be displayed alongside the error code in local file system errors. Example (before): ``` [E-232]failed to write /path/be/storage/data/xxx/xxxx/xxxxx/xxxxxx.dat ``` Example (after): ``` [E-232]failed to write /path/be/storage/data/xxx/xxxx/xxxxx/xxxxxx.dat: No space left on device ``` The error message now includes a more informative description, providing users with a clearer understanding of the issue.
Issue Number: DORIS-18704 Problem Summary: Human-readable error messages should be displayed alongside the error code in local file system errors. Example (before): ``` [E-232]failed to write /path/be/storage/data/xxx/xxxx/xxxxx/xxxxxx.dat ``` Example (after): ``` [E-232]failed to write /path/be/storage/data/xxx/xxxx/xxxxx/xxxxxx.dat: No space left on device ``` The error message now includes a more informative description, providing users with a clearer understanding of the issue.
…#47918) Issue Number: DORIS-18704 Problem Summary: Human-readable error messages should be displayed alongside the error code in local file system errors. Example (before): ``` [E-232]failed to write /path/be/storage/data/xxx/xxxx/xxxxx/xxxxxx.dat ``` Example (after): ``` [E-232]failed to write /path/be/storage/data/xxx/xxxx/xxxxx/xxxxxx.dat: No space left on device ``` The error message now includes a more informative description, providing users with a clearer understanding of the issue.
…#47918) Issue Number: DORIS-18704 Problem Summary: Human-readable error messages should be displayed alongside the error code in local file system errors. Example (before): ``` [E-232]failed to write /path/be/storage/data/xxx/xxxx/xxxxx/xxxxxx.dat ``` Example (after): ``` [E-232]failed to write /path/be/storage/data/xxx/xxxx/xxxxx/xxxxxx.dat: No space left on device ``` The error message now includes a more informative description, providing users with a clearer understanding of the issue.
What problem does this PR solve?
Issue Number: DORIS-18704
Problem Summary:
Human-readable error messages should be displayed alongside the error code in local file system errors.
Example (before):
Example (after):
The error message now includes a more informative description, providing users with a clearer understanding of the issue.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)