Skip to content

Conversation

@kaijchen
Copy link
Member

@kaijchen kaijchen commented Feb 14, 2025

What problem does this PR solve?

Issue Number: DORIS-18704
Problem Summary:

Human-readable error messages should be displayed alongside the error code in local file system errors.

Example (before):

[E-232]failed to write /path/be/storage/data/xxx/xxxx/xxxxx/xxxxxx.dat

Example (after):

[E-232]failed to write /path/be/storage/data/xxx/xxxx/xxxxx/xxxxxx.dat: No space left on device

The error message now includes a more informative description, providing users with a clearer understanding of the issue.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@kaijchen
Copy link
Member Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31471 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 09834d895abff6d484d1bbe4eeac0cb2ccb6ffe7, data reload: false

------ Round 1 ----------------------------------
q1	17610	5206	5075	5075
q2	2048	300	170	170
q3	10402	1284	707	707
q4	10212	999	530	530
q5	7517	2408	2338	2338
q6	186	169	135	135
q7	899	745	605	605
q8	9318	1281	1111	1111
q9	4855	4839	4689	4689
q10	6805	2302	1871	1871
q11	468	277	264	264
q12	346	350	215	215
q13	17765	3663	3037	3037
q14	219	234	212	212
q15	500	472	465	465
q16	631	615	570	570
q17	568	885	341	341
q18	6898	6189	6232	6189
q19	1073	1083	522	522
q20	314	311	194	194
q21	2813	2069	1934	1934
q22	365	320	297	297
Total cold run time: 101812 ms
Total hot run time: 31471 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5139	5163	5149	5149
q2	234	326	229	229
q3	2153	2665	2278	2278
q4	1456	1831	1378	1378
q5	4255	4142	4177	4142
q6	210	160	123	123
q7	1873	1811	1634	1634
q8	2611	2694	2576	2576
q9	7237	7078	7073	7073
q10	3029	3127	2744	2744
q11	583	518	476	476
q12	684	766	625	625
q13	3400	3901	3213	3213
q14	272	289	280	280
q15	522	473	461	461
q16	625	689	628	628
q17	1198	1585	1342	1342
q18	7672	7340	7376	7340
q19	750	800	856	800
q20	1970	2077	1854	1854
q21	5280	4915	4931	4915
q22	601	567	573	567
Total cold run time: 51754 ms
Total hot run time: 49827 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 182846 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 09834d895abff6d484d1bbe4eeac0cb2ccb6ffe7, data reload: false

query1	963	404	359	359
query2	6528	1924	1900	1900
query3	6799	211	215	211
query4	26549	23274	22876	22876
query5	4353	663	466	466
query6	297	190	200	190
query7	4617	505	306	306
query8	292	240	230	230
query9	8614	2477	2468	2468
query10	460	314	261	261
query11	15289	15212	14902	14902
query12	164	104	103	103
query13	1659	517	368	368
query14	9480	6793	6529	6529
query15	217	191	172	172
query16	7618	631	444	444
query17	1172	685	553	553
query18	1963	389	296	296
query19	199	177	153	153
query20	118	115	111	111
query21	211	118	99	99
query22	4226	4285	4353	4285
query23	34361	33420	32822	32822
query24	7697	2379	2392	2379
query25	525	446	383	383
query26	1217	268	148	148
query27	2136	493	326	326
query28	3900	2393	2366	2366
query29	741	527	408	408
query30	234	183	159	159
query31	943	840	776	776
query32	70	63	62	62
query33	551	351	291	291
query34	784	861	484	484
query35	798	808	730	730
query36	935	999	877	877
query37	119	103	74	74
query38	4215	4245	4146	4146
query39	1459	1396	1394	1394
query40	206	121	104	104
query41	58	59	55	55
query42	124	102	101	101
query43	498	509	474	474
query44	1260	804	784	784
query45	182	169	164	164
query46	861	1032	649	649
query47	1785	1795	1737	1737
query48	373	413	304	304
query49	805	539	448	448
query50	681	739	419	419
query51	4145	4159	4174	4159
query52	113	108	109	108
query53	228	289	180	180
query54	484	478	400	400
query55	80	74	77	74
query56	282	268	258	258
query57	1116	1121	1079	1079
query58	241	236	245	236
query59	2653	2667	2581	2581
query60	275	257	246	246
query61	120	114	114	114
query62	803	723	656	656
query63	233	184	184	184
query64	4435	982	646	646
query65	3209	3141	3112	3112
query66	1084	410	303	303
query67	16120	15528	15344	15344
query68	5182	763	507	507
query69	460	296	264	264
query70	1217	1131	1015	1015
query71	406	289	253	253
query72	5736	3607	3786	3607
query73	726	730	348	348
query74	8911	9148	9055	9055
query75	3155	3155	2666	2666
query76	3202	1153	727	727
query77	499	363	271	271
query78	9966	10096	9246	9246
query79	1667	803	579	579
query80	638	519	443	443
query81	511	273	237	237
query82	193	126	93	93
query83	178	168	154	154
query84	245	87	78	78
query85	774	339	299	299
query86	376	302	296	296
query87	4462	4477	4247	4247
query88	2886	2202	2195	2195
query89	378	310	280	280
query90	1796	195	189	189
query91	138	137	109	109
query92	72	59	54	54
query93	1140	985	582	582
query94	628	395	292	292
query95	346	263	256	256
query96	472	551	266	266
query97	2745	2845	2741	2741
query98	218	218	206	206
query99	1304	1386	1265	1265
Total cold run time: 265554 ms
Total hot run time: 182846 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.7 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 09834d895abff6d484d1bbe4eeac0cb2ccb6ffe7, data reload: false

query1	0.04	0.04	0.06
query2	0.07	0.03	0.03
query3	0.24	0.06	0.06
query4	1.62	0.10	0.10
query5	0.42	0.42	0.40
query6	1.15	0.65	0.67
query7	0.02	0.02	0.02
query8	0.04	0.04	0.04
query9	0.60	0.52	0.54
query10	0.58	0.57	0.58
query11	0.15	0.10	0.10
query12	0.15	0.11	0.11
query13	0.61	0.59	0.61
query14	2.72	2.72	2.73
query15	0.92	0.86	0.86
query16	0.38	0.38	0.37
query17	1.01	1.06	1.03
query18	0.21	0.19	0.20
query19	1.88	1.79	1.97
query20	0.02	0.01	0.02
query21	15.35	0.89	0.55
query22	0.75	1.26	0.95
query23	14.70	1.36	0.66
query24	8.61	3.55	0.52
query25	0.29	0.20	0.21
query26	0.94	0.19	0.14
query27	0.05	0.05	0.05
query28	6.51	0.79	0.44
query29	12.67	4.00	3.33
query30	0.25	0.09	0.06
query31	2.83	0.58	0.38
query32	3.23	0.55	0.47
query33	2.96	3.01	3.03
query34	15.74	5.13	4.45
query35	4.51	4.50	4.53
query36	0.66	0.49	0.48
query37	0.08	0.06	0.06
query38	0.04	0.04	0.04
query39	0.03	0.02	0.02
query40	0.17	0.13	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 103.34 s
Total hot run time: 30.7 s

@kaijchen
Copy link
Member Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31208 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 09834d895abff6d484d1bbe4eeac0cb2ccb6ffe7, data reload: false

------ Round 1 ----------------------------------
q1	17574	5217	5070	5070
q2	2046	310	175	175
q3	10383	1374	712	712
q4	10209	992	531	531
q5	7475	2858	2327	2327
q6	188	167	136	136
q7	897	747	599	599
q8	9312	1295	981	981
q9	4907	4877	4492	4492
q10	6794	2309	1887	1887
q11	466	285	245	245
q12	353	350	209	209
q13	17764	3664	3084	3084
q14	215	230	203	203
q15	512	485	458	458
q16	613	621	582	582
q17	566	859	336	336
q18	6818	6241	6180	6180
q19	1085	933	519	519
q20	310	328	190	190
q21	2775	2166	1991	1991
q22	372	334	301	301
Total cold run time: 101634 ms
Total hot run time: 31208 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5115	5078	5106	5078
q2	228	318	235	235
q3	2118	2642	2232	2232
q4	1416	1835	1419	1419
q5	4221	4108	4134	4108
q6	201	159	121	121
q7	1847	1981	1667	1667
q8	2472	2571	2594	2571
q9	7266	7140	7003	7003
q10	2979	3160	2757	2757
q11	566	505	500	500
q12	652	805	598	598
q13	3542	4030	3283	3283
q14	293	299	262	262
q15	525	456	465	456
q16	642	670	643	643
q17	1127	1559	1315	1315
q18	7374	7306	7317	7306
q19	767	833	919	833
q20	1925	1989	1876	1876
q21	5390	4885	4951	4885
q22	641	580	543	543
Total cold run time: 51307 ms
Total hot run time: 49691 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 183332 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 09834d895abff6d484d1bbe4eeac0cb2ccb6ffe7, data reload: false

query1	964	388	366	366
query2	6518	1902	1904	1902
query3	6791	211	208	208
query4	26075	23251	23242	23242
query5	5757	675	468	468
query6	293	193	172	172
query7	4608	494	306	306
query8	303	237	234	234
query9	8632	2487	2503	2487
query10	533	313	259	259
query11	15480	15031	15025	15025
query12	155	109	107	107
query13	1644	506	395	395
query14	11318	6492	6671	6492
query15	251	188	179	179
query16	7657	615	442	442
query17	1535	731	564	564
query18	1912	402	304	304
query19	264	196	154	154
query20	122	114	112	112
query21	214	124	102	102
query22	4422	4625	4411	4411
query23	34168	33064	32823	32823
query24	6853	2349	2341	2341
query25	498	464	398	398
query26	1208	271	149	149
query27	2062	487	324	324
query28	4005	2390	2362	2362
query29	694	531	417	417
query30	229	186	152	152
query31	915	832	759	759
query32	74	60	57	57
query33	544	350	287	287
query34	770	842	523	523
query35	794	829	752	752
query36	956	984	890	890
query37	130	96	75	75
query38	4066	4210	3967	3967
query39	1429	1376	1377	1376
query40	200	113	101	101
query41	57	51	48	48
query42	142	107	101	101
query43	496	499	463	463
query44	1274	783	786	783
query45	178	164	157	157
query46	861	1023	644	644
query47	1744	1777	1737	1737
query48	369	407	305	305
query49	773	485	400	400
query50	678	729	434	434
query51	4121	4137	4148	4137
query52	104	104	95	95
query53	224	269	182	182
query54	495	485	408	408
query55	80	79	87	79
query56	269	259	251	251
query57	1104	1157	1061	1061
query58	244	221	235	221
query59	2679	2831	2631	2631
query60	279	273	292	273
query61	122	115	114	114
query62	782	714	687	687
query63	223	189	188	188
query64	4187	970	641	641
query65	3192	3095	3126	3095
query66	983	398	292	292
query67	15803	15495	15380	15380
query68	7719	761	504	504
query69	463	298	254	254
query70	1221	1109	1140	1109
query71	419	282	278	278
query72	5790	3502	3672	3502
query73	745	725	351	351
query74	8976	9140	8884	8884
query75	3119	3131	2683	2683
query76	3114	1174	747	747
query77	460	356	279	279
query78	9875	9962	9305	9305
query79	2932	794	602	602
query80	572	510	446	446
query81	512	274	241	241
query82	627	123	96	96
query83	176	166	149	149
query84	243	90	71	71
query85	746	351	291	291
query86	328	301	281	281
query87	4474	4563	4394	4394
query88	3790	2221	2202	2202
query89	397	303	291	291
query90	2099	192	189	189
query91	136	136	108	108
query92	76	58	54	54
query93	2089	996	578	578
query94	718	383	289	289
query95	337	265	249	249
query96	476	568	267	267
query97	2787	2828	2710	2710
query98	229	205	200	200
query99	1332	1413	1237	1237
Total cold run time: 273483 ms
Total hot run time: 183332 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.61 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 09834d895abff6d484d1bbe4eeac0cb2ccb6ffe7, data reload: false

query1	0.04	0.04	0.04
query2	0.07	0.03	0.03
query3	0.24	0.06	0.07
query4	1.62	0.10	0.10
query5	0.41	0.42	0.43
query6	1.14	0.67	0.69
query7	0.02	0.01	0.01
query8	0.04	0.03	0.02
query9	0.59	0.51	0.52
query10	0.57	0.57	0.57
query11	0.14	0.10	0.10
query12	0.15	0.11	0.11
query13	0.62	0.60	0.60
query14	2.68	2.71	2.72
query15	0.92	0.85	0.84
query16	0.37	0.37	0.39
query17	1.01	0.98	1.00
query18	0.21	0.19	0.19
query19	1.90	1.78	2.00
query20	0.01	0.02	0.01
query21	15.36	0.89	0.55
query22	0.74	1.26	1.15
query23	14.65	1.37	0.61
query24	11.32	1.00	0.45
query25	0.52	0.24	0.08
query26	0.74	0.19	0.14
query27	0.05	0.05	0.05
query28	7.18	0.77	0.44
query29	12.53	3.99	3.29
query30	0.26	0.09	0.05
query31	2.83	0.60	0.39
query32	3.23	0.55	0.46
query33	3.00	2.98	3.02
query34	15.85	5.14	4.53
query35	4.51	4.53	4.52
query36	0.67	0.50	0.49
query37	0.09	0.06	0.06
query38	0.06	0.04	0.03
query39	0.03	0.03	0.02
query40	0.17	0.13	0.13
query41	0.07	0.02	0.03
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.67 s
Total hot run time: 30.61 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 14, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 43.34% (11316/26112)
Line Coverage: 33.35% (95050/284987)
Region Coverage: 32.15% (48721/151565)
Branch Coverage: 27.96% (24568/87854)
Coverage Report: http://coverage.selectdb-in.cc/coverage/09834d895abff6d484d1bbe4eeac0cb2ccb6ffe7_09834d895abff6d484d1bbe4eeac0cb2ccb6ffe7/report/index.html

@dataroaring dataroaring merged commit a21338b into apache:master Feb 18, 2025
33 of 35 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 18, 2025
Issue Number: DORIS-18704
Problem Summary:

Human-readable error messages should be displayed alongside the error
code in local file system errors.

Example (before):

```
[E-232]failed to write /path/be/storage/data/xxx/xxxx/xxxxx/xxxxxx.dat
```

Example (after):

```
[E-232]failed to write /path/be/storage/data/xxx/xxxx/xxxxx/xxxxxx.dat: No space left on device
```

The error message now includes a more informative description, providing
users with a clearer understanding of the issue.
github-actions bot pushed a commit that referenced this pull request Feb 18, 2025
Issue Number: DORIS-18704
Problem Summary:

Human-readable error messages should be displayed alongside the error
code in local file system errors.

Example (before):

```
[E-232]failed to write /path/be/storage/data/xxx/xxxx/xxxxx/xxxxxx.dat
```

Example (after):

```
[E-232]failed to write /path/be/storage/data/xxx/xxxx/xxxxx/xxxxxx.dat: No space left on device
```

The error message now includes a more informative description, providing
users with a clearer understanding of the issue.
yiguolei pushed a commit that referenced this pull request Feb 19, 2025
…ages #47918 (#48010)

Cherry-picked from #47918

Co-authored-by: Kaijie Chen <chenkaijie@selectdb.com>
dataroaring pushed a commit that referenced this pull request Feb 19, 2025
…ages #47918 (#48009)

Cherry-picked from #47918

Co-authored-by: Kaijie Chen <chenkaijie@selectdb.com>
lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
…#47918)

Issue Number: DORIS-18704
Problem Summary:

Human-readable error messages should be displayed alongside the error
code in local file system errors.

Example (before):

```
[E-232]failed to write /path/be/storage/data/xxx/xxxx/xxxxx/xxxxxx.dat
```

Example (after):

```
[E-232]failed to write /path/be/storage/data/xxx/xxxx/xxxxx/xxxxxx.dat: No space left on device
```

The error message now includes a more informative description, providing
users with a clearer understanding of the issue.
@yiguolei yiguolei mentioned this pull request Mar 25, 2025
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
…#47918)

Issue Number: DORIS-18704
Problem Summary:

Human-readable error messages should be displayed alongside the error
code in local file system errors.

Example (before):

```
[E-232]failed to write /path/be/storage/data/xxx/xxxx/xxxxx/xxxxxx.dat
```

Example (after):

```
[E-232]failed to write /path/be/storage/data/xxx/xxxx/xxxxx/xxxxxx.dat: No space left on device
```

The error message now includes a more informative description, providing
users with a clearer understanding of the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.9-merged dev/3.0.5-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants