Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #47918

Issue Number: DORIS-18704
Problem Summary:

Human-readable error messages should be displayed alongside the error
code in local file system errors.

Example (before):

```
[E-232]failed to write /path/be/storage/data/xxx/xxxx/xxxxx/xxxxxx.dat
```

Example (after):

```
[E-232]failed to write /path/be/storage/data/xxx/xxxx/xxxxx/xxxxxx.dat: No space left on device
```

The error message now includes a more informative description, providing
users with a clearer understanding of the issue.
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Feb 18, 2025
@hello-stephen
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40815 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 83573c5151798247c1877f2d8048379a408b61ad, data reload: false

------ Round 1 ----------------------------------
q1	17592	7537	7263	7263
q2	2055	173	168	168
q3	10955	1070	1193	1070
q4	10470	712	794	712
q5	7757	2918	2816	2816
q6	238	150	146	146
q7	963	612	606	606
q8	9350	1980	2020	1980
q9	6619	6414	6383	6383
q10	7026	2324	2356	2324
q11	479	265	267	265
q12	402	215	207	207
q13	17790	2984	3009	2984
q14	250	224	211	211
q15	569	544	517	517
q16	665	592	572	572
q17	998	601	571	571
q18	7297	6650	6581	6581
q19	1404	1152	1073	1073
q20	489	219	199	199
q21	4051	3277	3170	3170
q22	1106	1016	997	997
Total cold run time: 108525 ms
Total hot run time: 40815 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7299	7183	7246	7183
q2	326	231	227	227
q3	2947	2974	2971	2971
q4	2032	1829	1783	1783
q5	5695	5747	5715	5715
q6	222	144	144	144
q7	2325	1834	1817	1817
q8	3378	3570	3548	3548
q9	8744	8989	8861	8861
q10	3609	3578	3576	3576
q11	597	504	498	498
q12	789	620	599	599
q13	9515	3169	3213	3169
q14	302	280	288	280
q15	585	519	515	515
q16	706	646	646	646
q17	1881	1618	1613	1613
q18	8211	7761	7537	7537
q19	1654	1500	1576	1500
q20	2103	1902	1874	1874
q21	5562	5210	5329	5210
q22	1129	1049	1054	1049
Total cold run time: 69611 ms
Total hot run time: 60315 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197188 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 83573c5151798247c1877f2d8048379a408b61ad, data reload: false

query1	1302	932	918	918
query2	6277	2077	2014	2014
query3	10807	4362	4167	4167
query4	66573	31029	23500	23500
query5	4892	442	448	442
query6	419	192	171	171
query7	5720	307	304	304
query8	298	213	218	213
query9	9285	2701	2695	2695
query10	476	277	249	249
query11	17009	15519	16239	15519
query12	159	104	103	103
query13	1580	449	453	449
query14	10570	7686	7012	7012
query15	221	187	186	186
query16	7166	470	471	470
query17	1066	565	567	565
query18	2051	306	305	305
query19	221	148	152	148
query20	121	112	112	112
query21	209	104	108	104
query22	4900	4691	4470	4470
query23	34411	34146	33851	33851
query24	6263	2927	2920	2920
query25	543	417	419	417
query26	659	174	169	169
query27	1877	354	364	354
query28	4289	2482	2446	2446
query29	717	463	452	452
query30	251	172	166	166
query31	994	829	835	829
query32	67	57	57	57
query33	434	339	304	304
query34	926	527	515	515
query35	864	738	732	732
query36	1103	973	979	973
query37	123	86	75	75
query38	4108	3989	4027	3989
query39	1551	1505	1479	1479
query40	207	102	102	102
query41	50	50	50	50
query42	112	105	99	99
query43	549	489	496	489
query44	1190	835	844	835
query45	187	176	167	167
query46	1164	735	755	735
query47	2084	1966	1983	1966
query48	495	395	401	395
query49	756	410	421	410
query50	843	422	423	422
query51	7283	7108	6945	6945
query52	97	89	89	89
query53	254	182	180	180
query54	549	443	444	443
query55	74	73	78	73
query56	267	243	248	243
query57	1249	1140	1112	1112
query58	210	200	206	200
query59	3208	2966	2891	2891
query60	310	261	253	253
query61	110	107	124	107
query62	855	731	709	709
query63	218	183	192	183
query64	1357	675	627	627
query65	3253	3142	3167	3142
query66	700	313	303	303
query67	16117	15565	15588	15565
query68	4124	601	556	556
query69	423	264	263	263
query70	1206	1100	1120	1100
query71	367	253	245	245
query72	6441	4080	4190	4080
query73	750	345	342	342
query74	10242	9109	9018	9018
query75	3372	2610	2681	2610
query76	1872	1043	1041	1041
query77	467	266	269	266
query78	10472	9545	9596	9545
query79	1546	602	598	598
query80	862	445	413	413
query81	529	243	235	235
query82	1200	119	118	118
query83	219	140	146	140
query84	283	83	79	79
query85	876	293	291	291
query86	349	287	297	287
query87	4477	4343	4245	4245
query88	3457	2395	2360	2360
query89	427	291	289	289
query90	1873	184	183	183
query91	186	147	149	147
query92	62	50	51	50
query93	1832	550	546	546
query94	755	287	302	287
query95	358	253	246	246
query96	609	276	273	273
query97	3361	3198	3159	3159
query98	219	200	192	192
query99	1767	1444	1405	1405
Total cold run time: 319233 ms
Total hot run time: 197188 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.39 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 83573c5151798247c1877f2d8048379a408b61ad, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.06
query4	1.63	0.10	0.10
query5	0.52	0.51	0.53
query6	1.14	0.73	0.73
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.57	0.49	0.50
query10	0.55	0.55	0.56
query11	0.14	0.10	0.10
query12	0.16	0.10	0.12
query13	0.62	0.60	0.59
query14	2.73	2.83	2.74
query15	0.89	0.81	0.81
query16	0.37	0.36	0.38
query17	1.06	1.05	1.06
query18	0.23	0.22	0.21
query19	1.90	1.81	1.96
query20	0.02	0.01	0.01
query21	15.36	0.58	0.58
query22	2.22	2.01	1.74
query23	17.09	1.05	0.85
query24	3.58	1.71	2.42
query25	0.32	0.11	0.06
query26	0.59	0.13	0.13
query27	0.04	0.05	0.04
query28	8.73	1.12	1.08
query29	12.57	3.25	3.23
query30	0.25	0.06	0.06
query31	2.85	0.40	0.40
query32	3.22	0.47	0.45
query33	3.02	3.03	3.05
query34	17.14	4.48	4.43
query35	4.50	4.52	4.48
query36	0.68	0.48	0.50
query37	0.09	0.06	0.07
query38	0.04	0.04	0.04
query39	0.03	0.02	0.03
query40	0.16	0.13	0.12
query41	0.08	0.03	0.02
query42	0.04	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 105.55 s
Total hot run time: 33.39 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 77ed97a into branch-3.0 Feb 19, 2025
22 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-47918-branch-3.0 branch February 19, 2025 03:13
@gavinchou gavinchou mentioned this pull request Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants