-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Fix](merge-on-write) should calculate delete bitmaps between segments before skip if tablet is in NOT_READY state in flush phase
#48056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix](merge-on-write) should calculate delete bitmaps between segments before skip if tablet is in NOT_READY state in flush phase
#48056
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 31769 ms |
TPC-DS: Total hot run time: 184031 ms |
ClickBench: Total hot run time: 30.25 s |
|
TeamCity be ut coverage result: |
zhannngchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
…s before skip if tablet is in `NOT_READY` state in flush phase (apache#48056) Problem Summary: considering the following situation: 1. heavy sc start on BE and change tablet's state to `NOT_READY` 2. load1 skip to calculate delete bitmaps in flush phase because the tablet's state is `NOT_READY` 3. heavy sc finished and change tablet's state to `RUNNING` 4. load1 calculate delete bitmaps in publish phase for converted historical rowsets If load1 write multi segments, this will cause duplicate key because it forget to calculate delete bitmaps between segments in any phase.
…s before skip if tablet is in `NOT_READY` state in flush phase (apache#48056) Problem Summary: considering the following situation: 1. heavy sc start on BE and change tablet's state to `NOT_READY` 2. load1 skip to calculate delete bitmaps in flush phase because the tablet's state is `NOT_READY` 3. heavy sc finished and change tablet's state to `RUNNING` 4. load1 calculate delete bitmaps in publish phase for converted historical rowsets If load1 write multi segments, this will cause duplicate key because it forget to calculate delete bitmaps between segments in any phase.
…s before skip if tablet is in `NOT_READY` state in flush phase (apache#48056) Problem Summary: considering the following situation: 1. heavy sc start on BE and change tablet's state to `NOT_READY` 2. load1 skip to calculate delete bitmaps in flush phase because the tablet's state is `NOT_READY` 3. heavy sc finished and change tablet's state to `RUNNING` 4. load1 calculate delete bitmaps in publish phase for converted historical rowsets If load1 write multi segments, this will cause duplicate key because it forget to calculate delete bitmaps between segments in any phase.
…s before skip if tablet is in `NOT_READY` state in flush phase (apache#48056) ### What problem does this PR solve? Problem Summary: considering the following situation: 1. heavy sc start on BE and change tablet's state to `NOT_READY` 2. load1 skip to calculate delete bitmaps in flush phase because the tablet's state is `NOT_READY` 3. heavy sc finished and change tablet's state to `RUNNING` 4. load1 calculate delete bitmaps in publish phase for converted historical rowsets If load1 write multi segments, this will cause duplicate key because it forget to calculate delete bitmaps between segments in any phase.
…s before skip if tablet is in `NOT_READY` state in flush phase (apache#48056) ### What problem does this PR solve? Problem Summary: considering the following situation: 1. heavy sc start on BE and change tablet's state to `NOT_READY` 2. load1 skip to calculate delete bitmaps in flush phase because the tablet's state is `NOT_READY` 3. heavy sc finished and change tablet's state to `RUNNING` 4. load1 calculate delete bitmaps in publish phase for converted historical rowsets If load1 write multi segments, this will cause duplicate key because it forget to calculate delete bitmaps between segments in any phase.
…s between segmens before skip if tablet is in `NOT_READY` state in flush phase (apache#48056) (apache#48089) (apache#334) pick apache#48056
What problem does this PR solve?
Problem Summary:
considering the following situation:
NOT_READYNOT_READYRUNNINGIf load1 write multi segments, this will cause duplicate key because it forget to calculate delete bitmaps between segments in any phase.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)