Skip to content

branch-2.1-pick: [Fix](merge-on-write) should calculate delete bitmaps between segmens before skip if tablet is in NOT_READY state in flush phase (#48056) #48089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 2 commits into from
Feb 21, 2025
Merged

branch-2.1-pick: [Fix](merge-on-write) should calculate delete bitmaps between segmens before skip if tablet is in NOT_READY state in flush phase (#48056) #48089

dataroaring merged 2 commits into from
Feb 21, 2025

Conversation

@bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Feb 19, 2025

pick #48056

@bobhan1
[Fix](merge-on-write) should calculate delete bitmaps between segment…
357c8e9 
…s before skip if tablet is in `NOT_READY` state in flush phase (apache#48056)

Problem Summary:

considering the following situation:
1. heavy sc start on BE and change tablet's state to `NOT_READY`
2. load1 skip to calculate delete bitmaps in flush phase because the
tablet's state is `NOT_READY`
3. heavy sc finished and change tablet's state to `RUNNING`
4. load1 calculate delete bitmaps in publish phase for converted
historical rowsets

If load1 write multi segments, this will cause duplicate key because it
forget to calculate delete bitmaps between segments in any phase.
@hello-stephen
Copy link
Contributor

hello-stephen commented Feb 19, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@bobhan1
Copy link
Contributor Author

bobhan1 commented Feb 19, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Feb 19, 2025

TeamCity be ut coverage result:
Function Coverage: 36.49% (9608/26327)
Line Coverage: 28.08% (79653/283621)
Region Coverage: 26.74% (40862/152791)
Branch Coverage: 23.50% (20710/88136)
Coverage Report: http://coverage.selectdb-in.cc/coverage/85a678ecc4bbc795259dfeb3687b017b644bbde8_85a678ecc4bbc795259dfeb3687b017b644bbde8/report/index.html

@dataroaring dataroaring merged commit bcd01c5 into apache:branch-2.1 Feb 21, 2025
18 of 19 checks passed
deardeng pushed a commit to deardeng/incubator-doris that referenced this pull request Dec 19, 2025
@bobhan1
branch-2.1-pick: [Fix](merge-on-write) should calculate delete bitmap…
5333f80 
…s between segmens before skip if tablet is in `NOT_READY` state in flush phase (apache#48056) (apache#48089) (apache#334)

pick apache#48056
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bobhan1 @hello-stephen @doris-robot @dataroaring