Skip to content

Conversation

@LiBinfeng-01
Copy link
Contributor

pick:#47966

Related PR: #40744#47228

Problem Summary:
When numeric function input or output out of boundary when fe folding constant, it would throw an exception before. Now
we change it to match with be execution result, which is NullLiteral

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…o match with be execution behavior (apache#47966)

Related PR: apache#40744apache#47228

Problem Summary:
When numeric function input or output out of boundary when fe folding
constant, it would throw an exception before. Now
we change it to match with be execution result, which is NullLiteral
@LiBinfeng-01
Copy link
Contributor Author

run buildall

@Thearas
Copy link
Contributor

Thearas commented Feb 24, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow morrySnow changed the title [fix](Nereids) change numeric arithmatic function boundary behavior to match with be execution behavior (#47966) branch-2.1: [fix](Nereids) change numeric arithmatic function boundary behavior to match with be execution behavior #47966 Feb 25, 2025
@yiguolei yiguolei merged commit 65e9dce into apache:branch-2.1 Feb 25, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants