Skip to content

[fix](Nereids) fix log bug and add more numeric arithmetic function cases #47228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 4 commits into from
Feb 11, 2025
Merged

[fix](Nereids) fix log bug and add more numeric arithmetic function cases #47228

morrySnow merged 4 commits into from
Feb 11, 2025

Conversation

@LiBinfeng-01
Copy link
Contributor

@LiBinfeng-01 LiBinfeng-01 commented Jan 20, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
fix log and fmod functions and add more cases

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 20, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@LiBinfeng-01
Copy link
Contributor Author

LiBinfeng-01 commented Jan 21, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jan 21, 2025

TPC-H: Total hot run time: 32455 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 58e41d9e35eb7d45387daeb613244e7200d13edd, data reload: false

------ Round 1 ----------------------------------
q1	17635	5468	5371	5371
q2	2056	321	173	173
q3	10741	1247	749	749
q4	10199	985	537	537
q5	7600	2373	2151	2151
q6	195	166	136	136
q7	908	767	605	605
q8	9240	1397	1191	1191
q9	5277	4911	4962	4911
q10	6838	2347	1913	1913
q11	491	291	254	254
q12	348	364	214	214
q13	17795	3695	3163	3163
q14	221	228	208	208
q15	513	478	469	469
q16	634	606	582	582
q17	587	875	321	321
q18	7171	6543	6478	6478
q19	2422	963	526	526
q20	300	316	191	191
q21	2771	2296	2000	2000
q22	376	336	312	312
Total cold run time: 104318 ms
Total hot run time: 32455 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5633	5510	5546	5510
q2	240	336	234	234
q3	2218	2641	2337	2337
q4	1458	1839	1362	1362
q5	4370	4765	4737	4737
q6	171	168	133	133
q7	2086	1958	1832	1832
q8	2613	2806	2724	2724
q9	7430	7262	7327	7262
q10	3043	3312	2822	2822
q11	581	514	483	483
q12	665	736	585	585
q13	3599	3919	3242	3242
q14	277	321	289	289
q15	518	486	468	468
q16	649	683	688	683
q17	1256	1779	1280	1280
q18	7679	7694	7450	7450
q19	797	1174	1077	1077
q20	2007	2088	1878	1878
q21	5744	5196	5107	5107
q22	588	607	569	569
Total cold run time: 53622 ms
Total hot run time: 52064 ms

@doris-robot
Copy link

doris-robot commented Jan 21, 2025

TPC-DS: Total hot run time: 195217 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 58e41d9e35eb7d45387daeb613244e7200d13edd, data reload: false

query1	1312	991	926	926
query2	6294	2137	2137	2137
query3	11059	4489	4524	4489
query4	61746	29998	22954	22954
query5	5428	603	464	464
query6	434	192	190	190
query7	5532	500	299	299
query8	344	243	244	243
query9	8429	2594	2602	2594
query10	480	310	252	252
query11	17564	15196	15402	15196
query12	175	116	105	105
query13	1456	541	437	437
query14	11113	7067	7580	7067
query15	248	197	193	193
query16	7228	681	484	484
query17	1092	734	588	588
query18	1809	425	325	325
query19	194	175	154	154
query20	124	111	112	111
query21	213	123	104	104
query22	4445	4858	4491	4491
query23	34309	33598	34136	33598
query24	5681	2366	2362	2362
query25	442	451	396	396
query26	672	292	171	171
query27	1875	487	330	330
query28	4010	2480	2461	2461
query29	537	566	424	424
query30	211	191	189	189
query31	945	899	840	840
query32	73	64	57	57
query33	437	381	303	303
query34	745	873	501	501
query35	811	826	775	775
query36	1001	1047	936	936
query37	128	105	78	78
query38	4399	4349	4260	4260
query39	1505	1487	1475	1475
query40	206	117	103	103
query41	54	52	50	50
query42	121	108	102	102
query43	534	557	519	519
query44	1347	844	835	835
query45	181	175	173	173
query46	899	1056	650	650
query47	1942	1916	1833	1833
query48	413	418	331	331
query49	725	506	413	413
query50	665	678	416	416
query51	7051	7148	6981	6981
query52	107	101	100	100
query53	228	258	187	187
query54	485	517	436	436
query55	83	78	81	78
query56	269	271	281	271
query57	1178	1145	1070	1070
query58	250	227	246	227
query59	3125	3154	3037	3037
query60	275	275	254	254
query61	121	117	119	117
query62	748	720	641	641
query63	229	192	186	186
query64	1311	1015	663	663
query65	3247	3150	3188	3150
query66	654	385	365	365
query67	15940	15594	15443	15443
query68	5080	761	521	521
query69	477	299	262	262
query70	1222	1186	1150	1150
query71	419	286	253	253
query72	5996	3875	3864	3864
query73	766	760	347	347
query74	9973	9086	9073	9073
query75	3224	3132	2665	2665
query76	3642	1207	764	764
query77	469	379	273	273
query78	10001	10061	9483	9483
query79	3272	789	605	605
query80	1531	535	476	476
query81	564	273	238	238
query82	691	157	118	118
query83	249	172	159	159
query84	283	108	75	75
query85	786	373	294	294
query86	466	276	305	276
query87	4448	4496	4357	4357
query88	4322	2158	2137	2137
query89	404	323	286	286
query90	1523	192	184	184
query91	134	138	110	110
query92	62	60	54	54
query93	2790	875	524	524
query94	808	395	287	287
query95	332	269	255	255
query96	498	616	277	277
query97	2852	2872	2786	2786
query98	223	198	207	198
query99	1315	1350	1276	1276
Total cold run time: 315710 ms
Total hot run time: 195217 ms

@doris-robot
Copy link

doris-robot commented Jan 21, 2025

ClickBench: Total hot run time: 30.95 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 58e41d9e35eb7d45387daeb613244e7200d13edd, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.04
query3	0.24	0.07	0.07
query4	1.62	0.10	0.10
query5	0.43	0.42	0.42
query6	1.17	0.66	0.65
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.58	0.52	0.50
query10	0.56	0.56	0.55
query11	0.15	0.10	0.10
query12	0.14	0.11	0.11
query13	0.61	0.58	0.62
query14	2.71	2.75	2.82
query15	0.89	0.83	0.83
query16	0.38	0.37	0.38
query17	1.02	1.01	1.03
query18	0.23	0.20	0.21
query19	1.86	1.87	1.93
query20	0.02	0.01	0.02
query21	15.35	0.91	0.57
query22	0.76	0.81	0.64
query23	15.25	1.50	0.52
query24	2.87	1.31	1.45
query25	0.13	0.14	0.11
query26	0.23	0.15	0.14
query27	0.05	0.04	0.06
query28	13.99	1.02	0.44
query29	12.59	3.92	3.23
query30	0.25	0.09	0.07
query31	2.82	0.59	0.39
query32	3.24	0.55	0.47
query33	3.00	2.99	2.99
query34	16.49	5.22	4.51
query35	4.61	4.55	4.50
query36	0.65	0.48	0.49
query37	0.09	0.06	0.06
query38	0.04	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.14
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.52 s
Total hot run time: 30.95 s

morrySnow
morrySnow previously approved these changes Jan 24, 2025
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2025

PR approved by anyone and no changes requested.

@LiBinfeng-01
Copy link
Contributor Author

LiBinfeng-01 commented Feb 10, 2025

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Feb 10, 2025
@doris-robot
Copy link

doris-robot commented Feb 10, 2025

TPC-H: Total hot run time: 31607 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 68d85fd47eb40afe854d2cfcec8029b3972268d0, data reload: false

------ Round 1 ----------------------------------
q1	17578	5204	5072	5072
q2	2042	301	165	165
q3	10415	1391	727	727
q4	10215	1004	564	564
q5	7526	2382	2428	2382
q6	185	171	136	136
q7	897	760	610	610
q8	9326	1272	1137	1137
q9	4902	4591	4853	4591
q10	6816	2309	1876	1876
q11	483	281	257	257
q12	348	362	216	216
q13	17772	3652	2988	2988
q14	227	228	203	203
q15	502	459	450	450
q16	638	606	600	600
q17	572	885	340	340
q18	6654	6300	6384	6300
q19	1085	970	560	560
q20	304	316	193	193
q21	2775	2109	1924	1924
q22	354	333	316	316
Total cold run time: 101616 ms
Total hot run time: 31607 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5120	5092	5140	5092
q2	232	322	231	231
q3	2172	2695	2309	2309
q4	1421	1815	1388	1388
q5	4220	4113	4107	4107
q6	211	163	124	124
q7	1862	1809	1637	1637
q8	2618	2654	2510	2510
q9	7285	7103	7079	7079
q10	2958	3268	2758	2758
q11	572	508	487	487
q12	682	759	615	615
q13	3541	3864	3216	3216
q14	272	301	270	270
q15	497	469	452	452
q16	658	679	632	632
q17	1125	1589	1339	1339
q18	7694	7336	7196	7196
q19	816	818	892	818
q20	1962	2017	1860	1860
q21	5452	4828	5134	4828
q22	651	592	577	577
Total cold run time: 52021 ms
Total hot run time: 49525 ms

@doris-robot
Copy link

doris-robot commented Feb 10, 2025

TPC-DS: Total hot run time: 183573 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 68d85fd47eb40afe854d2cfcec8029b3972268d0, data reload: false

query1	963	388	361	361
query2	6523	1921	1894	1894
query3	6799	216	213	213
query4	26540	23732	23088	23088
query5	4917	665	498	498
query6	299	205	183	183
query7	4633	494	305	305
query8	293	238	225	225
query9	8628	2480	2458	2458
query10	482	315	248	248
query11	15579	15136	14794	14794
query12	158	104	103	103
query13	1637	527	371	371
query14	9864	6463	6428	6428
query15	208	189	172	172
query16	7669	618	450	450
query17	1160	718	547	547
query18	1997	405	311	311
query19	192	190	158	158
query20	128	121	118	118
query21	213	124	104	104
query22	4241	4355	4280	4280
query23	33839	32869	32981	32869
query24	7665	2411	2388	2388
query25	565	467	413	413
query26	1224	269	157	157
query27	2120	489	336	336
query28	3871	2384	2384	2384
query29	715	526	409	409
query30	231	180	152	152
query31	921	861	768	768
query32	73	59	63	59
query33	576	360	290	290
query34	774	843	493	493
query35	790	811	739	739
query36	979	1003	915	915
query37	122	100	83	83
query38	4118	4079	4218	4079
query39	1488	1404	1468	1404
query40	199	114	101	101
query41	52	51	52	51
query42	122	102	100	100
query43	514	530	487	487
query44	1279	784	780	780
query45	174	169	159	159
query46	843	1041	641	641
query47	1785	1801	1711	1711
query48	375	415	291	291
query49	782	518	429	429
query50	676	716	425	425
query51	4153	4223	4084	4084
query52	108	116	100	100
query53	225	259	185	185
query54	480	487	405	405
query55	83	86	80	80
query56	261	257	247	247
query57	1104	1111	1066	1066
query58	237	238	236	236
query59	2686	2789	2743	2743
query60	275	259	258	258
query61	118	111	116	111
query62	853	726	649	649
query63	227	191	186	186
query64	4414	969	645	645
query65	3173	3105	3128	3105
query66	1041	425	310	310
query67	15800	15582	15587	15582
query68	8128	740	492	492
query69	462	297	261	261
query70	1112	1111	1121	1111
query71	412	295	271	271
query72	5601	3614	3733	3614
query73	759	747	340	340
query74	8826	8997	9000	8997
query75	3159	3156	2715	2715
query76	3311	1170	753	753
query77	507	365	269	269
query78	9877	10099	9299	9299
query79	2735	809	581	581
query80	590	529	445	445
query81	497	274	241	241
query82	704	149	120	120
query83	175	174	148	148
query84	249	89	78	78
query85	763	346	307	307
query86	377	380	298	298
query87	4378	4374	4389	4374
query88	3854	2179	2179	2179
query89	391	324	283	283
query90	1924	193	192	192
query91	135	137	109	109
query92	77	56	59	56
query93	1924	999	566	566
query94	719	407	280	280
query95	353	269	257	257
query96	482	558	269	269
query97	2796	2836	2742	2742
query98	239	204	197	197
query99	1331	1416	1315	1315
Total cold run time: 272080 ms
Total hot run time: 183573 ms

@doris-robot
Copy link

doris-robot commented Feb 10, 2025

ClickBench: Total hot run time: 30.51 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 68d85fd47eb40afe854d2cfcec8029b3972268d0, data reload: false

query1	0.04	0.03	0.02
query2	0.07	0.03	0.03
query3	0.24	0.06	0.07
query4	1.62	0.10	0.10
query5	0.42	0.43	0.39
query6	1.16	0.66	0.64
query7	0.02	0.02	0.02
query8	0.04	0.03	0.02
query9	0.57	0.51	0.53
query10	0.57	0.57	0.56
query11	0.15	0.10	0.11
query12	0.14	0.11	0.12
query13	0.60	0.61	0.60
query14	2.73	2.84	2.81
query15	0.93	0.84	0.85
query16	0.37	0.38	0.37
query17	1.02	1.04	1.06
query18	0.21	0.19	0.20
query19	1.90	1.86	2.01
query20	0.01	0.01	0.01
query21	15.38	0.94	0.57
query22	0.75	1.18	0.65
query23	14.94	1.37	0.62
query24	6.85	2.09	0.63
query25	0.49	0.21	0.18
query26	0.54	0.16	0.14
query27	0.05	0.04	0.05
query28	9.96	0.88	0.42
query29	12.54	3.98	3.30
query30	0.24	0.09	0.06
query31	2.81	0.59	0.38
query32	3.22	0.56	0.46
query33	2.99	3.09	3.00
query34	15.58	5.06	4.49
query35	4.54	4.54	4.52
query36	0.65	0.49	0.47
query37	0.10	0.07	0.06
query38	0.05	0.04	0.03
query39	0.03	0.03	0.02
query40	0.17	0.13	0.13
query41	0.08	0.03	0.02
query42	0.04	0.03	0.02
query43	0.03	0.02	0.02
Total cold run time: 104.84 s
Total hot run time: 30.51 s

@LiBinfeng-01
Copy link
Contributor Author

LiBinfeng-01 commented Feb 11, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Feb 11, 2025

TPC-H: Total hot run time: 31738 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit cd92a6d72728f897db82c710959ca4e748f2d35e, data reload: false

------ Round 1 ----------------------------------
q1	17623	5218	5123	5123
q2	2051	309	166	166
q3	10411	1363	712	712
q4	10219	1025	545	545
q5	7501	2377	2390	2377
q6	197	169	133	133
q7	915	746	609	609
q8	9312	1389	1078	1078
q9	4853	4635	4684	4635
q10	6795	2318	1878	1878
q11	484	280	258	258
q12	352	354	225	225
q13	17780	3658	3060	3060
q14	224	226	232	226
q15	514	471	455	455
q16	636	611	584	584
q17	594	874	360	360
q18	6589	6287	6304	6287
q19	1199	967	549	549
q20	320	328	205	205
q21	2900	2216	1949	1949
q22	370	345	324	324
Total cold run time: 101839 ms
Total hot run time: 31738 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5106	5151	5113	5113
q2	242	334	230	230
q3	2194	2630	2296	2296
q4	1482	1834	1411	1411
q5	4263	4146	4106	4106
q6	204	160	125	125
q7	1859	1825	1672	1672
q8	2684	2722	2578	2578
q9	7235	7113	7140	7113
q10	3039	3186	2806	2806
q11	591	501	488	488
q12	736	774	600	600
q13	3610	3931	3213	3213
q14	274	290	269	269
q15	511	470	454	454
q16	629	690	631	631
q17	1164	1553	1368	1368
q18	7541	7190	7125	7125
q19	880	825	890	825
q20	2044	2008	1872	1872
q21	5444	4986	4763	4763
q22	638	614	581	581
Total cold run time: 52370 ms
Total hot run time: 49639 ms

@doris-robot
Copy link

doris-robot commented Feb 11, 2025

TPC-DS: Total hot run time: 183388 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit cd92a6d72728f897db82c710959ca4e748f2d35e, data reload: false

query1	977	373	373	373
query2	6541	1803	1807	1803
query3	6790	216	223	216
query4	26600	23626	22941	22941
query5	4394	654	488	488
query6	307	209	194	194
query7	4619	496	308	308
query8	302	251	234	234
query9	8636	2489	2487	2487
query10	481	319	263	263
query11	15838	15307	15193	15193
query12	167	109	106	106
query13	1669	534	396	396
query14	11290	6164	6397	6164
query15	203	191	171	171
query16	7646	635	431	431
query17	1570	712	554	554
query18	1974	396	293	293
query19	210	184	154	154
query20	115	112	110	110
query21	208	132	103	103
query22	4239	4735	4344	4344
query23	34163	33023	32870	32870
query24	7064	2402	2354	2354
query25	524	440	381	381
query26	1238	262	151	151
query27	2078	498	327	327
query28	3980	2376	2387	2376
query29	704	531	409	409
query30	225	186	157	157
query31	943	882	766	766
query32	73	65	64	64
query33	551	384	301	301
query34	790	855	491	491
query35	804	803	737	737
query36	959	973	921	921
query37	125	102	74	74
query38	4077	4116	4069	4069
query39	1421	1407	1400	1400
query40	211	118	106	106
query41	52	51	52	51
query42	126	100	104	100
query43	493	511	462	462
query44	1333	784	795	784
query45	172	174	162	162
query46	861	1045	644	644
query47	1740	1773	1725	1725
query48	382	402	294	294
query49	787	510	428	428
query50	670	724	409	409
query51	4146	4173	4116	4116
query52	103	106	98	98
query53	226	253	180	180
query54	481	482	399	399
query55	87	81	87	81
query56	255	285	237	237
query57	1137	1147	1065	1065
query58	249	223	238	223
query59	2680	2704	2563	2563
query60	283	260	254	254
query61	124	118	115	115
query62	811	721	655	655
query63	224	186	185	185
query64	4226	977	651	651
query65	3188	3098	3147	3098
query66	1051	406	296	296
query67	15641	15516	15553	15516
query68	5061	792	569	569
query69	469	288	273	273
query70	1159	1153	1086	1086
query71	398	294	279	279
query72	6027	3599	3770	3599
query73	729	728	356	356
query74	9036	9139	8965	8965
query75	3123	3129	2682	2682
query76	3258	1165	743	743
query77	470	398	288	288
query78	9812	9914	9322	9322
query79	2032	817	585	585
query80	790	524	472	472
query81	510	284	244	244
query82	418	148	125	125
query83	162	177	154	154
query84	245	92	77	77
query85	748	351	299	299
query86	414	315	272	272
query87	4471	4464	4546	4464
query88	2863	2226	2180	2180
query89	381	319	287	287
query90	1830	198	193	193
query91	134	143	106	106
query92	68	62	58	58
query93	1670	1027	585	585
query94	712	416	300	300
query95	346	260	259	259
query96	477	550	264	264
query97	2750	2768	2736	2736
query98	237	217	205	205
query99	1342	1392	1290	1290
Total cold run time: 268376 ms
Total hot run time: 183388 ms

@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 11, 2025
@morrySnow morrySnow merged commit 538ce55 into apache:master Feb 11, 2025
27 of 30 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 11, 2025
[fix](Nereids) fix log bug and add more numeric arithmetic function c…
1d2bbde 
…ases (#47228)
@github-actions github-actions bot mentioned this pull request Feb 11, 2025
Closed
github-actions bot pushed a commit that referenced this pull request Feb 11, 2025
[fix](Nereids) fix log bug and add more numeric arithmetic function c…
ed41007 
…ases (#47228)
@github-actions github-actions bot mentioned this pull request Feb 11, 2025
Merged
yiguolei pushed a commit that referenced this pull request Feb 11, 2025
@github-actions
branch-2.1: [fix](Nereids) fix log bug and add more numeric arithmeti…
a121566 
…c function cases #47228 (#47749)

Cherry-picked from #47228

Co-authored-by: LiBinfeng <libinfeng@selectdb.com>
@LiBinfeng-01 LiBinfeng-01 mentioned this pull request Feb 13, 2025
Merged
16 tasks
dataroaring pushed a commit that referenced this pull request Feb 13, 2025
[fix](Nereids) fix log bug and add more numeric arithmetic function c…
4841019 
…ases #47228 (#47853)
@LiBinfeng-01 LiBinfeng-01 mentioned this pull request Feb 17, 2025
Merged
16 tasks
morrySnow pushed a commit that referenced this pull request Feb 19, 2025
[fix](Nereids) change numeric arithmatic function boundary behavior t…
cba955c 
…o match with be execution behavior (#47966)

### What problem does this PR solve?

Related PR: #40744， #47228

Problem Summary:
When numeric function input or output out of boundary when fe folding
constant, it would throw an exception before. Now
we change it to match with be execution result, which is NullLiteral
github-actions bot pushed a commit that referenced this pull request Feb 19, 2025
[fix](Nereids) change numeric arithmatic function boundary behavior t…
ca37c4c 
…o match with be execution behavior (#47966)

### What problem does this PR solve?

Related PR: #40744， #47228

Problem Summary:
When numeric function input or output out of boundary when fe folding
constant, it would throw an exception before. Now
we change it to match with be execution result, which is NullLiteral
morningman pushed a commit to morningman/doris that referenced this pull request Feb 20, 2025
@github-actions @morningman
branch-2.1: [fix](Nereids) fix log bug and add more numeric arithmeti…
481e507 
…c function cases apache#47228 (apache#47749)

Cherry-picked from apache#47228

Co-authored-by: LiBinfeng <libinfeng@selectdb.com>
lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
@lzyy2024
[fix](Nereids) fix log bug and add more numeric arithmetic function c…
48d8cd8 
…ases (apache#47228)
lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
@lzyy2024
[fix](Nereids) change numeric arithmatic function boundary behavior t…
6288236 
…o match with be execution behavior (apache#47966)

### What problem does this PR solve?

Related PR: apache#40744， apache#47228

Problem Summary:
When numeric function input or output out of boundary when fe folding
constant, it would throw an exception before. Now
we change it to match with be execution result, which is NullLiteral
LiBinfeng-01 pushed a commit to LiBinfeng-01/doris that referenced this pull request Feb 24, 2025
[fix](Nereids) change numeric arithmatic function boundary behavior t…
602d8c7 
…o match with be execution behavior (apache#47966)

Related PR: apache#40744， apache#47228

Problem Summary:
When numeric function input or output out of boundary when fe folding
constant, it would throw an exception before. Now
we change it to match with be execution result, which is NullLiteral
@LiBinfeng-01 LiBinfeng-01 mentioned this pull request Feb 24, 2025
Merged
16 tasks
LiBinfeng-01 pushed a commit to LiBinfeng-01/doris that referenced this pull request Feb 25, 2025
[fix](Nereids) change numeric arithmatic function boundary behavior t…
6a14f7a 
…o match with be execution behavior (apache#47966)

### What problem does this PR solve?

Related PR: apache#40744， apache#47228

Problem Summary:
When numeric function input or output out of boundary when fe folding
constant, it would throw an exception before. Now
we change it to match with be execution result, which is NullLiteral
@LiBinfeng-01 LiBinfeng-01 mentioned this pull request Feb 25, 2025
Merged
16 tasks
yiguolei pushed a commit that referenced this pull request Feb 25, 2025
branch-2.1: [fix](Nereids) change numeric arithmatic function boundar…
65e9dce 
…y behavior to match with be execution behavior #47966 (#48237)

pick:#47966

Related PR: #40744， #47228

Problem Summary:
When numeric function input or output out of boundary when fe folding
constant, it would throw an exception before. Now
we change it to match with be execution result, which is NullLiteral

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
dataroaring pushed a commit that referenced this pull request Feb 26, 2025
branch-3.0: [fix](Nereids) change numeric arithmatic function boundar…
c076491 
…y behavior to match with be execution behavior (#47966) (#48281)

pick:#47966
### What problem does this PR solve?

Related PR: #40744， #47228

Problem Summary:
When numeric function input or output out of boundary when fe folding
constant, it would throw an exception before. Now
we change it to match with be execution result, which is NullLiteral
@yiguolei yiguolei mentioned this pull request Mar 25, 2025
Closed
deardeng pushed a commit to deardeng/incubator-doris that referenced this pull request Apr 30, 2025
@morrySnow
branch-2.1: [fix](Nereids) fix log bug and add more numeric arithmeti…
9d49617 
…c function cases

Cherry-picked from apache#47228

Co-authored-by: LiBinfeng <libinfeng@selectdb.com>
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@koarz
[fix](Nereids) fix log bug and add more numeric arithmetic function c…
cf2f762 
…ases (apache#47228)
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@koarz
[fix](Nereids) change numeric arithmatic function boundary behavior t…
88462b4 
…o match with be execution behavior (apache#47966)

### What problem does this PR solve?

Related PR: apache#40744， apache#47228

Problem Summary:
When numeric function input or output out of boundary when fe folding
constant, it would throw an exception before. Now
we change it to match with be execution result, which is NullLiteral
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

+1 more reviewer

@aytrack aytrack aytrack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.9-merged dev/3.0.4-merged p0_w reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@LiBinfeng-01 @hello-stephen @doris-robot @aytrack @morrySnow @yiguolei @dataroaring