Skip to content

Conversation

@LiBinfeng-01
Copy link
Contributor

pick:#47966

What problem does this PR solve?

Related PR: #40744#47228

Problem Summary:
When numeric function input or output out of boundary when fe folding constant, it would throw an exception before. Now
we change it to match with be execution result, which is NullLiteral

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…o match with be execution behavior (apache#47966)

### What problem does this PR solve?

Related PR: apache#40744apache#47228

Problem Summary:
When numeric function input or output out of boundary when fe folding
constant, it would throw an exception before. Now
we change it to match with be execution result, which is NullLiteral
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@LiBinfeng-01
Copy link
Contributor Author

run buildall

@LiBinfeng-01 LiBinfeng-01 changed the title [fix](Nereids) change numeric arithmatic function boundary behavior to match with be execution behavior (#47966) branch-3.0: [fix](Nereids) change numeric arithmatic function boundary behavior to match with be execution behavior (#47966) Feb 25, 2025
@doris-robot
Copy link

TPC-H: Total hot run time: 40652 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6a14f7a40e7624abdc2b8aeea21735f69482f150, data reload: false

------ Round 1 ----------------------------------
q1	17712	7336	7183	7183
q2	2054	178	186	178
q3	10574	1090	1178	1090
q4	10458	773	727	727
q5	7744	2852	2882	2852
q6	232	149	147	147
q7	958	617	618	617
q8	9369	1907	2020	1907
q9	6593	6335	6369	6335
q10	7039	2298	2323	2298
q11	474	281	269	269
q12	407	213	216	213
q13	17780	3013	2986	2986
q14	241	222	207	207
q15	567	517	515	515
q16	686	588	584	584
q17	966	581	476	476
q18	7171	6682	6622	6622
q19	1407	1160	1040	1040
q20	502	213	229	213
q21	4055	3296	3203	3203
q22	1129	990	1016	990
Total cold run time: 108118 ms
Total hot run time: 40652 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7260	7159	7215	7159
q2	324	230	227	227
q3	2869	2876	2913	2876
q4	2059	1810	1830	1810
q5	5691	5666	5728	5666
q6	223	141	142	141
q7	2239	1801	1866	1801
q8	3334	3589	3557	3557
q9	8792	8886	8812	8812
q10	3602	3541	3570	3541
q11	590	507	506	506
q12	798	628	610	610
q13	10986	3202	3163	3163
q14	309	284	295	284
q15	571	541	519	519
q16	696	671	653	653
q17	1828	1640	1598	1598
q18	8125	7769	7819	7769
q19	1649	1545	1548	1545
q20	2062	1866	1854	1854
q21	5514	5353	5507	5353
q22	1124	1035	1034	1034
Total cold run time: 70645 ms
Total hot run time: 60478 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197196 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6a14f7a40e7624abdc2b8aeea21735f69482f150, data reload: false

query1	1276	905	915	905
query2	6250	2002	2011	2002
query3	10825	4330	4389	4330
query4	62023	28946	23343	23343
query5	5208	463	445	445
query6	390	174	175	174
query7	5500	317	329	317
query8	295	214	221	214
query9	8670	2698	2700	2698
query10	472	282	257	257
query11	17755	15309	15778	15309
query12	158	105	115	105
query13	1462	453	435	435
query14	11159	7451	6990	6990
query15	204	180	175	175
query16	7197	500	484	484
query17	1147	589	601	589
query18	1912	310	303	303
query19	204	155	153	153
query20	116	108	115	108
query21	201	99	106	99
query22	4670	4400	4900	4400
query23	34551	33740	34783	33740
query24	6363	2878	2886	2878
query25	510	396	398	396
query26	644	172	169	169
query27	1889	348	349	348
query28	4111	2503	2466	2466
query29	705	430	446	430
query30	257	166	161	161
query31	992	827	859	827
query32	72	54	57	54
query33	493	298	303	298
query34	917	516	517	516
query35	861	756	754	754
query36	1100	967	953	953
query37	113	69	74	69
query38	4121	4013	4006	4006
query39	1535	1490	1474	1474
query40	201	103	102	102
query41	54	52	54	52
query42	114	104	101	101
query43	546	503	490	490
query44	1223	857	846	846
query45	191	171	174	171
query46	1129	740	736	736
query47	1995	1947	1927	1927
query48	479	390	410	390
query49	744	402	419	402
query50	847	432	431	431
query51	7234	7136	7278	7136
query52	103	91	99	91
query53	266	185	181	181
query54	587	469	460	460
query55	78	82	78	78
query56	267	254	257	254
query57	1271	1156	1170	1156
query58	230	223	246	223
query59	3304	3036	2961	2961
query60	268	248	247	247
query61	105	104	107	104
query62	821	729	732	729
query63	216	181	186	181
query64	1387	670	637	637
query65	3252	3168	3196	3168
query66	647	298	296	296
query67	16078	15645	15586	15586
query68	4368	564	575	564
query69	417	259	261	259
query70	1112	1136	1097	1097
query71	323	253	259	253
query72	6316	4092	4040	4040
query73	746	348	359	348
query74	10262	9140	9242	9140
query75	3386	2632	2618	2618
query76	1937	1091	1051	1051
query77	473	273	263	263
query78	10549	9671	9500	9500
query79	2127	593	596	593
query80	1348	456	415	415
query81	524	241	240	240
query82	1251	88	87	87
query83	245	147	141	141
query84	288	75	75	75
query85	1013	295	288	288
query86	387	302	291	291
query87	4481	4203	4421	4203
query88	3960	2379	2371	2371
query89	420	288	289	288
query90	1903	187	182	182
query91	177	149	153	149
query92	61	50	51	50
query93	2831	556	551	551
query94	756	294	287	287
query95	357	252	251	251
query96	630	281	285	281
query97	3349	3194	3205	3194
query98	220	204	198	198
query99	1690	1418	1432	1418
Total cold run time: 317872 ms
Total hot run time: 197196 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.98 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6a14f7a40e7624abdc2b8aeea21735f69482f150, data reload: false

query1	0.03	0.03	0.02
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.62	0.10	0.10
query5	0.52	0.52	0.53
query6	1.13	0.73	0.73
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.56	0.50	0.50
query10	0.54	0.56	0.57
query11	0.14	0.10	0.11
query12	0.13	0.12	0.11
query13	0.61	0.61	0.59
query14	2.72	2.86	2.85
query15	0.90	0.82	0.83
query16	0.39	0.39	0.40
query17	1.03	1.00	1.04
query18	0.24	0.21	0.22
query19	1.96	1.90	2.01
query20	0.02	0.01	0.01
query21	15.36	0.59	0.60
query22	3.22	2.08	1.48
query23	16.89	0.78	1.03
query24	3.13	1.54	0.47
query25	0.27	0.25	0.05
query26	0.41	0.13	0.12
query27	0.04	0.05	0.04
query28	10.70	1.10	1.09
query29	12.63	3.18	3.22
query30	0.24	0.06	0.06
query31	2.88	0.38	0.38
query32	3.26	0.46	0.45
query33	2.97	2.98	2.96
query34	17.23	4.47	4.46
query35	4.49	4.53	4.54
query36	0.67	0.48	0.50
query37	0.09	0.06	0.06
query38	0.04	0.03	0.04
query39	0.03	0.03	0.02
query40	0.16	0.12	0.12
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.76 s
Total hot run time: 31.98 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit c076491 into apache:branch-3.0 Feb 26, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants