Skip to content

Conversation

@eldenmoon
Copy link
Member

What problem does this PR solve?

Reuse TabletIndex like TabletColumn

related PR #42448
Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@eldenmoon
Copy link
Member Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31767 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 136db1c6467c9ff271ad089c098cf3dfb26a35aa, data reload: false

------ Round 1 ----------------------------------
q1	17606	5182	5092	5092
q2	2051	308	173	173
q3	10389	1263	775	775
q4	10209	1038	534	534
q5	7541	2437	2344	2344
q6	192	164	132	132
q7	876	752	605	605
q8	9292	1283	1152	1152
q9	4934	4800	4672	4672
q10	6817	2321	1899	1899
q11	479	277	256	256
q12	345	359	221	221
q13	17763	3728	3061	3061
q14	224	225	212	212
q15	506	476	446	446
q16	633	613	603	603
q17	585	881	343	343
q18	6916	6205	6252	6205
q19	1340	945	555	555
q20	320	331	193	193
q21	2770	2174	1982	1982
q22	372	334	312	312
Total cold run time: 102160 ms
Total hot run time: 31767 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5149	5129	5093	5093
q2	232	334	236	236
q3	2180	2714	2320	2320
q4	1508	1854	1414	1414
q5	4252	4172	4171	4171
q6	206	163	125	125
q7	1896	1844	1714	1714
q8	2612	2622	2585	2585
q9	7286	7303	7248	7248
q10	3010	3215	2795	2795
q11	597	525	475	475
q12	693	793	600	600
q13	3450	3974	3236	3236
q14	278	306	268	268
q15	504	472	464	464
q16	657	684	669	669
q17	1143	1626	1328	1328
q18	7909	7448	7371	7371
q19	810	888	1094	888
q20	1996	2022	1879	1879
q21	5492	5164	4653	4653
q22	650	598	541	541
Total cold run time: 52510 ms
Total hot run time: 50073 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191881 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 136db1c6467c9ff271ad089c098cf3dfb26a35aa, data reload: false

query1	1305	981	931	931
query2	6332	1884	1879	1879
query3	11172	4598	4549	4549
query4	54729	25124	23290	23290
query5	5133	526	481	481
query6	338	222	181	181
query7	4966	496	299	299
query8	328	249	243	243
query9	5986	2561	2574	2561
query10	442	311	269	269
query11	15168	15083	15376	15083
query12	163	111	107	107
query13	1093	532	399	399
query14	10257	7201	7093	7093
query15	211	199	195	195
query16	7116	668	444	444
query17	1089	739	611	611
query18	1549	444	317	317
query19	200	253	160	160
query20	126	121	120	120
query21	201	126	103	103
query22	4648	4572	4497	4497
query23	33852	33208	33478	33208
query24	5765	2472	2430	2430
query25	451	467	395	395
query26	724	273	156	156
query27	1796	511	340	340
query28	2791	2507	2462	2462
query29	572	544	424	424
query30	216	189	152	152
query31	890	850	872	850
query32	75	64	62	62
query33	454	345	315	315
query34	790	865	513	513
query35	825	820	774	774
query36	948	998	909	909
query37	119	103	79	79
query38	4153	4082	4411	4082
query39	1486	1435	1472	1435
query40	199	141	109	109
query41	133	49	50	49
query42	128	105	103	103
query43	502	522	489	489
query44	1313	829	810	810
query45	189	180	166	166
query46	892	1071	660	660
query47	1824	1873	1831	1831
query48	380	417	317	317
query49	717	520	433	433
query50	748	764	419	419
query51	4268	4315	4212	4212
query52	110	110	103	103
query53	237	259	197	197
query54	506	509	419	419
query55	98	79	79	79
query56	269	273	278	273
query57	1166	1172	1132	1132
query58	241	240	241	240
query59	2925	2861	2885	2861
query60	299	275	269	269
query61	120	126	122	122
query62	763	753	648	648
query63	233	200	204	200
query64	2040	1050	676	676
query65	3432	3223	3222	3222
query66	713	396	292	292
query67	15908	15662	15305	15305
query68	7113	887	524	524
query69	528	289	266	266
query70	1158	1148	1107	1107
query71	486	303	272	272
query72	5740	3644	3765	3644
query73	1400	753	360	360
query74	9091	8921	9107	8921
query75	3636	3187	2700	2700
query76	4231	1174	747	747
query77	590	368	279	279
query78	10063	10129	9263	9263
query79	2077	882	599	599
query80	581	539	452	452
query81	516	287	242	242
query82	466	122	100	100
query83	174	170	150	150
query84	286	93	72	72
query85	797	355	303	303
query86	407	305	302	302
query87	4476	4513	4483	4483
query88	3601	2205	2188	2188
query89	394	313	289	289
query90	1815	198	197	197
query91	144	144	108	108
query92	79	66	57	57
query93	1725	1060	587	587
query94	663	392	308	308
query95	348	266	260	260
query96	490	557	277	277
query97	3373	3374	3329	3329
query98	220	206	197	197
query99	1361	1400	1264	1264
Total cold run time: 296841 ms
Total hot run time: 191881 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.53 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 136db1c6467c9ff271ad089c098cf3dfb26a35aa, data reload: false

query1	0.03	0.04	0.04
query2	0.07	0.04	0.03
query3	0.23	0.07	0.06
query4	1.63	0.10	0.10
query5	0.54	0.53	0.54
query6	1.20	0.72	0.73
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.58	0.53	0.51
query10	0.58	0.58	0.58
query11	0.15	0.10	0.11
query12	0.15	0.12	0.11
query13	0.62	0.59	0.59
query14	2.82	2.69	2.69
query15	0.92	0.85	0.85
query16	0.37	0.39	0.37
query17	1.05	1.00	1.06
query18	0.22	0.20	0.20
query19	1.89	1.78	1.97
query20	0.01	0.01	0.01
query21	15.37	0.93	0.53
query22	0.76	1.04	0.61
query23	15.11	1.36	0.62
query24	6.87	1.84	0.69
query25	0.53	0.23	0.13
query26	0.65	0.17	0.15
query27	0.05	0.06	0.05
query28	9.74	0.82	0.41
query29	12.58	3.93	3.26
query30	0.24	0.09	0.07
query31	2.82	0.59	0.39
query32	3.24	0.56	0.46
query33	3.07	3.01	3.04
query34	15.88	5.20	4.50
query35	4.59	4.54	4.54
query36	0.66	0.49	0.48
query37	0.10	0.06	0.07
query38	0.06	0.04	0.04
query39	0.04	0.02	0.03
query40	0.17	0.14	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 105.81 s
Total hot run time: 30.53 s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 44.64% (11902/26665)
Line Coverage: 34.08% (99500/291928)
Region Coverage: 33.25% (50913/153141)
Branch Coverage: 28.80% (25551/88734)
Coverage Report: http://coverage.selectdb-in.cc/coverage/136db1c6467c9ff271ad089c098cf3dfb26a35aa_136db1c6467c9ff271ad089c098cf3dfb26a35aa/report/index.html
Increment Report: http://coverage.selectdb-in.cc/coverage/136db1c6467c9ff271ad089c098cf3dfb26a35aa_136db1c6467c9ff271ad089c098cf3dfb26a35aa/increment_report/index.html

@eldenmoon
Copy link
Member Author

run buildall

@eldenmoon
Copy link
Member Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31864 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 64e703a3ff886e778fe5d0ddadf46a80f6aad0c3, data reload: false

------ Round 1 ----------------------------------
q1	17608	5250	5073	5073
q2	2053	310	172	172
q3	10558	1251	744	744
q4	10212	1057	557	557
q5	7521	2397	2365	2365
q6	197	174	142	142
q7	926	754	616	616
q8	9292	1313	1119	1119
q9	4940	4755	4946	4755
q10	6831	2325	1903	1903
q11	481	283	268	268
q12	350	354	221	221
q13	17798	3714	3105	3105
q14	230	230	214	214
q15	518	457	476	457
q16	646	617	582	582
q17	590	867	346	346
q18	6617	6351	6228	6228
q19	1670	949	550	550
q20	318	328	194	194
q21	2796	2171	1942	1942
q22	354	349	311	311
Total cold run time: 102506 ms
Total hot run time: 31864 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5215	5149	5160	5149
q2	241	330	236	236
q3	2169	2695	2281	2281
q4	1415	1831	1350	1350
q5	4275	4128	4134	4128
q6	212	167	127	127
q7	1863	1820	1750	1750
q8	2679	2669	2550	2550
q9	7249	7192	7215	7192
q10	3022	3238	2771	2771
q11	576	532	547	532
q12	687	813	619	619
q13	3389	3925	3363	3363
q14	296	295	270	270
q15	511	470	469	469
q16	673	704	638	638
q17	1173	1623	1356	1356
q18	7677	7271	7285	7271
q19	842	896	1144	896
q20	2012	2045	1949	1949
q21	5476	4978	4852	4852
q22	632	584	547	547
Total cold run time: 52284 ms
Total hot run time: 50296 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190783 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 64e703a3ff886e778fe5d0ddadf46a80f6aad0c3, data reload: false

query1	1316	925	935	925
query2	6321	1882	1866	1866
query3	11110	4541	4603	4541
query4	25267	23539	22987	22987
query5	3721	646	492	492
query6	287	200	194	194
query7	3984	502	319	319
query8	297	243	248	243
query9	8476	2514	2515	2514
query10	469	322	256	256
query11	15357	15255	15070	15070
query12	162	109	107	107
query13	1551	531	378	378
query14	8758	6562	6395	6395
query15	204	184	178	178
query16	7226	612	440	440
query17	1171	685	538	538
query18	1951	434	312	312
query19	198	189	155	155
query20	131	120	118	118
query21	206	139	141	139
query22	4295	4568	4245	4245
query23	34289	33639	33496	33496
query24	7926	2457	2436	2436
query25	535	473	388	388
query26	1188	273	158	158
query27	2680	485	341	341
query28	4612	2473	2423	2423
query29	759	606	464	464
query30	225	202	169	169
query31	939	869	833	833
query32	81	68	67	67
query33	583	375	320	320
query34	819	887	528	528
query35	814	859	790	790
query36	980	1005	915	915
query37	121	103	82	82
query38	4164	4169	4296	4169
query39	1506	1428	1492	1428
query40	225	121	112	112
query41	58	56	57	56
query42	131	112	110	110
query43	515	511	499	499
query44	1367	808	798	798
query45	190	174	171	171
query46	898	1086	670	670
query47	1847	1882	1775	1775
query48	393	442	305	305
query49	778	513	452	452
query50	691	754	426	426
query51	4314	4347	4269	4269
query52	113	111	95	95
query53	241	261	196	196
query54	482	524	423	423
query55	82	82	85	82
query56	276	268	266	266
query57	1212	1187	1111	1111
query58	269	241	247	241
query59	2721	2917	2634	2634
query60	296	279	259	259
query61	121	120	119	119
query62	794	736	680	680
query63	235	196	193	193
query64	4226	1019	653	653
query65	3317	3244	3275	3244
query66	1014	450	311	311
query67	16632	15453	15351	15351
query68	9830	901	514	514
query69	474	301	262	262
query70	1221	1110	1099	1099
query71	452	300	263	263
query72	5121	3606	3778	3606
query73	801	751	356	356
query74	8978	8918	9053	8918
query75	4223	3189	2698	2698
query76	4706	1178	751	751
query77	985	381	285	285
query78	9939	10148	9326	9326
query79	2068	834	590	590
query80	596	523	444	444
query81	485	279	245	245
query82	240	125	99	99
query83	219	171	156	156
query84	294	91	81	81
query85	751	347	318	318
query86	330	326	290	290
query87	4416	4493	4434	4434
query88	2866	2239	2236	2236
query89	424	323	293	293
query90	2174	194	196	194
query91	138	141	176	141
query92	69	59	65	59
query93	1812	1078	571	571
query94	670	400	311	311
query95	350	266	270	266
query96	490	575	269	269
query97	3284	3423	3295	3295
query98	221	204	227	204
query99	1387	1414	1289	1289
Total cold run time: 278131 ms
Total hot run time: 190783 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.26 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 64e703a3ff886e778fe5d0ddadf46a80f6aad0c3, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.03
query3	0.23	0.07	0.07
query4	1.61	0.11	0.10
query5	0.56	0.57	0.55
query6	1.22	0.72	0.72
query7	0.02	0.01	0.02
query8	0.05	0.04	0.03
query9	0.60	0.53	0.54
query10	0.56	0.58	0.57
query11	0.16	0.11	0.11
query12	0.14	0.13	0.11
query13	0.61	0.60	0.60
query14	2.66	2.72	2.80
query15	0.92	0.86	0.85
query16	0.38	0.39	0.38
query17	1.04	1.04	1.02
query18	0.22	0.20	0.20
query19	1.93	1.85	2.02
query20	0.01	0.01	0.01
query21	15.38	0.94	0.56
query22	0.76	1.04	0.77
query23	14.94	1.40	0.62
query24	6.86	2.33	0.92
query25	0.48	0.24	0.08
query26	0.60	0.16	0.14
query27	0.06	0.05	0.05
query28	9.68	0.83	0.44
query29	12.56	3.96	3.30
query30	0.25	0.10	0.07
query31	2.82	0.61	0.38
query32	3.23	0.55	0.46
query33	3.02	3.04	3.04
query34	15.68	5.18	4.58
query35	4.59	4.57	4.55
query36	0.68	0.51	0.49
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.04	0.03	0.02
query40	0.18	0.13	0.12
query41	0.08	0.03	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.13 s
Total hot run time: 31.26 s

@eldenmoon
Copy link
Member Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31689 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 78a1d688a5c6a2e40e42e1a991337ad3125e7ff1, data reload: false

------ Round 1 ----------------------------------
q1	17582	5169	5096	5096
q2	2058	316	178	178
q3	10381	1282	752	752
q4	10203	1049	543	543
q5	7546	2424	2326	2326
q6	192	172	139	139
q7	910	758	609	609
q8	9296	1302	1123	1123
q9	5102	4656	4695	4656
q10	6821	2308	1909	1909
q11	486	281	255	255
q12	357	361	229	229
q13	17758	3768	3077	3077
q14	231	229	213	213
q15	531	482	459	459
q16	636	615	606	606
q17	599	894	340	340
q18	6955	6331	6168	6168
q19	1220	965	547	547
q20	323	328	196	196
q21	2899	2159	1953	1953
q22	371	338	315	315
Total cold run time: 102457 ms
Total hot run time: 31689 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5142	5145	5296	5145
q2	242	330	234	234
q3	2199	2673	2331	2331
q4	1471	1859	1399	1399
q5	4270	4155	4199	4155
q6	216	166	125	125
q7	1904	1874	1728	1728
q8	2637	2656	2590	2590
q9	7275	7220	7185	7185
q10	3020	3213	2819	2819
q11	582	526	491	491
q12	672	775	629	629
q13	3426	4031	3292	3292
q14	290	308	269	269
q15	505	467	446	446
q16	666	693	648	648
q17	1159	1634	1358	1358
q18	7655	7329	7349	7329
q19	841	871	921	871
q20	2011	2061	1898	1898
q21	5566	5102	4772	4772
q22	621	587	559	559
Total cold run time: 52370 ms
Total hot run time: 50273 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190496 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 78a1d688a5c6a2e40e42e1a991337ad3125e7ff1, data reload: false

query1	1303	920	966	920
query2	6226	1897	1853	1853
query3	10962	4516	4554	4516
query4	54203	24851	23166	23166
query5	5019	556	493	493
query6	313	202	201	201
query7	4892	511	294	294
query8	319	259	247	247
query9	5535	2649	2646	2646
query10	388	306	259	259
query11	15157	15058	14811	14811
query12	159	113	113	113
query13	1045	544	391	391
query14	10739	6699	6336	6336
query15	207	210	171	171
query16	7130	680	493	493
query17	1107	757	610	610
query18	1571	423	333	333
query19	206	194	169	169
query20	170	120	124	120
query21	209	128	112	112
query22	4468	4457	4420	4420
query23	34212	33209	33148	33148
query24	5689	2442	2437	2437
query25	460	485	406	406
query26	747	313	154	154
query27	2250	496	333	333
query28	2777	2516	2495	2495
query29	586	564	438	438
query30	211	192	166	166
query31	925	900	872	872
query32	74	65	60	60
query33	499	364	306	306
query34	785	879	508	508
query35	818	832	742	742
query36	999	1010	913	913
query37	124	111	79	79
query38	4128	4219	4191	4191
query39	1487	1429	1439	1429
query40	206	113	108	108
query41	55	51	49	49
query42	129	109	98	98
query43	508	523	487	487
query44	1325	811	848	811
query45	183	176	163	163
query46	889	1074	655	655
query47	1832	1870	1804	1804
query48	389	431	321	321
query49	724	522	419	419
query50	710	757	422	422
query51	4283	4275	4267	4267
query52	115	108	95	95
query53	228	260	192	192
query54	493	497	423	423
query55	90	83	76	76
query56	296	287	283	283
query57	1141	1176	1121	1121
query58	242	239	244	239
query59	2758	2855	2763	2763
query60	293	286	280	280
query61	124	121	117	117
query62	737	739	705	705
query63	235	189	192	189
query64	2193	1066	762	762
query65	3356	3235	3272	3235
query66	774	425	303	303
query67	15915	15622	15290	15290
query68	8027	874	512	512
query69	546	302	263	263
query70	1155	1098	1096	1096
query71	490	292	268	268
query72	5750	3612	3834	3612
query73	1478	763	363	363
query74	9327	9135	8745	8745
query75	3816	3164	2679	2679
query76	4228	1168	754	754
query77	630	381	284	284
query78	10215	10084	9310	9310
query79	2739	824	589	589
query80	671	535	452	452
query81	512	272	240	240
query82	606	180	97	97
query83	298	170	152	152
query84	306	90	71	71
query85	783	358	304	304
query86	391	310	316	310
query87	4484	4472	4363	4363
query88	3553	2242	2231	2231
query89	427	323	284	284
query90	1842	197	194	194
query91	134	141	107	107
query92	71	62	55	55
query93	1884	1068	595	595
query94	730	406	309	309
query95	360	271	265	265
query96	481	565	282	282
query97	3354	3400	3216	3216
query98	232	212	198	198
query99	1459	1404	1268	1268
Total cold run time: 299301 ms
Total hot run time: 190496 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.5 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 78a1d688a5c6a2e40e42e1a991337ad3125e7ff1, data reload: false

query1	0.04	0.05	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.07
query4	1.62	0.11	0.10
query5	0.56	0.55	0.54
query6	1.19	0.70	0.73
query7	0.02	0.02	0.01
query8	0.04	0.04	0.03
query9	0.58	0.55	0.51
query10	0.55	0.57	0.58
query11	0.16	0.10	0.10
query12	0.14	0.11	0.12
query13	0.61	0.60	0.61
query14	2.84	2.70	2.70
query15	0.94	0.85	0.87
query16	0.38	0.37	0.38
query17	1.02	1.08	1.02
query18	0.21	0.20	0.19
query19	1.92	1.83	1.96
query20	0.01	0.01	0.01
query21	15.38	0.91	0.55
query22	0.76	1.20	0.60
query23	15.01	1.41	0.63
query24	6.67	1.55	1.55
query25	0.49	0.36	0.08
query26	0.64	0.16	0.13
query27	0.06	0.05	0.04
query28	10.04	0.87	0.44
query29	12.54	3.93	3.29
query30	0.25	0.09	0.07
query31	2.83	0.59	0.40
query32	3.23	0.54	0.46
query33	3.00	3.06	3.12
query34	15.83	5.15	4.52
query35	4.48	4.53	4.49
query36	0.67	0.50	0.48
query37	0.09	0.07	0.07
query38	0.05	0.04	0.04
query39	0.02	0.02	0.02
query40	0.16	0.14	0.15
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 105.47 s
Total hot run time: 31.5 s

@doris-robot
Copy link

BE UT Coverage Report


Increment line coverage 56.80% (71/125) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 44.78% (11938/26662)
Line Coverage 34.21% (99886/291967)
Region Coverage 33.37% (51119/153205)
Branch Coverage 28.92% (25669/88772)

Copy link
Contributor

@csun5285 csun5285 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@eldenmoon
Copy link
Member Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31889 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7119a69fb097c93654f5987b950a782475e85ce9, data reload: false

------ Round 1 ----------------------------------
q1	17606	5237	5081	5081
q2	2051	310	181	181
q3	10380	1389	720	720
q4	10218	1038	546	546
q5	7561	2382	2368	2368
q6	190	169	134	134
q7	891	758	600	600
q8	9291	1296	1143	1143
q9	4946	4765	4933	4765
q10	6835	2300	1898	1898
q11	478	263	270	263
q12	352	351	218	218
q13	17762	3741	3128	3128
q14	234	228	217	217
q15	511	475	465	465
q16	633	632	585	585
q17	566	858	341	341
q18	6750	6261	6241	6241
q19	1862	959	553	553
q20	314	320	191	191
q21	2785	2238	1948	1948
q22	361	334	303	303
Total cold run time: 102577 ms
Total hot run time: 31889 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5187	5125	5153	5125
q2	246	333	237	237
q3	2143	2710	2313	2313
q4	1433	1828	1368	1368
q5	4275	4134	4222	4134
q6	200	164	123	123
q7	1908	1871	1793	1793
q8	2645	2668	2729	2668
q9	7342	7187	7072	7072
q10	3009	3199	2771	2771
q11	576	510	493	493
q12	688	810	605	605
q13	3594	3933	3236	3236
q14	270	309	287	287
q15	509	476	454	454
q16	629	670	637	637
q17	1141	1634	1356	1356
q18	7636	7346	7358	7346
q19	776	802	823	802
q20	2044	2030	1906	1906
q21	5434	5016	4996	4996
q22	622	587	569	569
Total cold run time: 52307 ms
Total hot run time: 50291 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186228 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7119a69fb097c93654f5987b950a782475e85ce9, data reload: false

query1	1004	416	376	376
query2	6532	1934	1925	1925
query3	6788	216	211	211
query4	26956	23687	23602	23602
query5	4299	670	562	562
query6	305	212	221	212
query7	4615	536	306	306
query8	325	279	236	236
query9	8619	2550	2565	2550
query10	458	348	275	275
query11	15914	15176	16310	15176
query12	169	110	127	110
query13	1640	512	381	381
query14	10229	6739	6877	6739
query15	215	194	181	181
query16	7320	644	461	461
query17	1177	701	576	576
query18	1959	395	295	295
query19	187	182	159	159
query20	119	128	116	116
query21	207	119	101	101
query22	4336	4332	4539	4332
query23	34479	33555	33068	33068
query24	7773	2428	2448	2428
query25	556	478	415	415
query26	1227	273	163	163
query27	2109	508	333	333
query28	3870	2430	2410	2410
query29	758	571	452	452
query30	244	189	162	162
query31	965	889	806	806
query32	76	66	65	65
query33	589	362	316	316
query34	784	855	504	504
query35	802	819	775	775
query36	953	994	891	891
query37	124	104	86	86
query38	4287	4475	4093	4093
query39	1438	1388	1417	1388
query40	216	119	108	108
query41	58	57	54	54
query42	187	104	102	102
query43	514	516	493	493
query44	1342	808	812	808
query45	176	173	165	165
query46	869	1048	656	656
query47	1726	1775	1707	1707
query48	374	424	298	298
query49	785	500	414	414
query50	684	732	425	425
query51	4173	4163	4106	4106
query52	116	105	101	101
query53	233	271	196	196
query54	571	491	430	430
query55	81	82	78	78
query56	267	283	262	262
query57	1096	1143	1060	1060
query58	252	244	237	237
query59	2717	2790	2754	2754
query60	286	290	287	287
query61	124	123	120	120
query62	802	699	662	662
query63	230	198	187	187
query64	4241	1020	679	679
query65	3255	3234	3179	3179
query66	1090	382	299	299
query67	15814	15508	15262	15262
query68	8539	900	523	523
query69	459	308	271	271
query70	1212	1135	1133	1133
query71	471	292	281	281
query72	5511	3575	3791	3575
query73	793	740	355	355
query74	9222	9102	9050	9050
query75	4019	3160	2724	2724
query76	3699	1174	748	748
query77	762	388	283	283
query78	10089	10243	9208	9208
query79	2547	847	615	615
query80	654	549	462	462
query81	522	283	253	253
query82	698	128	106	106
query83	195	178	155	155
query84	274	96	75	75
query85	775	385	377	377
query86	386	309	275	275
query87	4522	4575	4325	4325
query88	3578	2232	2219	2219
query89	398	327	283	283
query90	1854	194	197	194
query91	136	140	108	108
query92	77	63	64	63
query93	1737	1081	577	577
query94	674	403	311	311
query95	363	275	263	263
query96	491	557	264	264
query97	3333	3419	3296	3296
query98	232	210	194	194
query99	1443	1422	1296	1296
Total cold run time: 276351 ms
Total hot run time: 186228 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.08 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7119a69fb097c93654f5987b950a782475e85ce9, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.61	0.10	0.10
query5	0.56	0.55	0.53
query6	1.18	0.72	0.72
query7	0.03	0.01	0.02
query8	0.04	0.03	0.03
query9	0.58	0.54	0.52
query10	0.57	0.59	0.58
query11	0.15	0.11	0.11
query12	0.14	0.11	0.12
query13	0.60	0.60	0.60
query14	2.93	2.82	2.70
query15	0.92	0.85	0.86
query16	0.38	0.38	0.38
query17	1.00	1.02	1.03
query18	0.22	0.20	0.20
query19	1.92	1.77	2.03
query20	0.01	0.02	0.01
query21	15.35	0.86	0.56
query22	0.75	1.22	0.96
query23	14.74	1.43	0.62
query24	7.28	1.18	0.71
query25	0.52	0.34	0.09
query26	0.47	0.16	0.14
query27	0.05	0.04	0.05
query28	9.95	0.85	0.43
query29	12.64	3.92	3.28
query30	0.25	0.09	0.07
query31	2.81	0.59	0.39
query32	3.24	0.55	0.46
query33	2.96	3.08	3.07
query34	15.87	5.19	4.54
query35	4.60	4.56	4.57
query36	0.67	0.51	0.48
query37	0.09	0.07	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.03
query40	0.18	0.13	0.13
query41	0.08	0.03	0.02
query42	0.04	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.83 s
Total hot run time: 31.08 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 60.00% (75/125) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.85% (12246/26709)
Line Coverage 35.35% (103533/292859)
Region Coverage 34.52% (53043/153663)
Branch Coverage 30.22% (26874/88920)

Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

PR approved by at least one committer and no changes requested.

@eldenmoon eldenmoon merged commit e24ab70 into apache:master Mar 5, 2025
24 of 26 checks passed
@eldenmoon eldenmoon deleted the opt-index-schema branch March 5, 2025 09:58
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Mar 28, 2025
Reuse TabletIndex like TabletColumn

related PR apache#42448
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants