Skip to content

Branch 3.1 [Feature](Variant) support variant sparse feature and schema template with multi indexes #52172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 7 commits into from
Jun 26, 2025
Merged

Branch 3.1 [Feature](Variant) support variant sparse feature and schema template with multi indexes #52172

morrySnow merged 7 commits into from
Jun 26, 2025

Conversation

@eldenmoon
Copy link
Member

@eldenmoon eldenmoon commented Jun 24, 2025 •
edited
Loading

What problem does this PR solve?

cherry-pick from https://github.com/apache/doris/pull/51623/files

also pick #48273

manual pick and code maybe different

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@eldenmoon eldenmoon requested a review from morrySnow as a code owner June 24, 2025 03:08
@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 24, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@eldenmoon eldenmoon force-pushed the branch-3.1-variant-feature branch from 8dbabb1 to b3a8a30 Compare June 24, 2025 03:13
@eldenmoon
Copy link
Member Author

eldenmoon commented Jun 24, 2025

run buildall

@eldenmoon eldenmoon force-pushed the branch-3.1-variant-feature branch from b3a8a30 to fb154a2 Compare June 24, 2025 03:15
@eldenmoon
Copy link
Member Author

eldenmoon commented Jun 24, 2025

run buildall

@eldenmoon eldenmoon force-pushed the branch-3.1-variant-feature branch from fb154a2 to b21b46a Compare June 24, 2025 03:19
@eldenmoon
Copy link
Member Author

eldenmoon commented Jun 24, 2025

run buildall

@eldenmoon eldenmoon force-pushed the branch-3.1-variant-feature branch from b21b46a to 3ba8a85 Compare June 24, 2025 03:26
@eldenmoon
Copy link
Member Author

eldenmoon commented Jun 24, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jun 24, 2025

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.23% (1117/1342)
Line Coverage 66.44% (18972/28553)
Region Coverage 66.21% (9419/14227)
Branch Coverage 56.16% (5098/9078)

@eldenmoon
Copy link
Member Author

eldenmoon commented Jun 24, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jun 24, 2025

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.20% (1119/1345)
Line Coverage 66.49% (19008/28586)
Region Coverage 66.23% (9430/14239)
Branch Coverage 56.26% (5108/9080)

@eldenmoon eldenmoon force-pushed the branch-3.1-variant-feature branch 2 times, most recently from 31fe561 to 7c8ca09 Compare June 24, 2025 16:19
@eldenmoon
Copy link
Member Author

eldenmoon commented Jun 24, 2025

run buildall

@eldenmoon eldenmoon force-pushed the branch-3.1-variant-feature branch from 7c8ca09 to e524a50 Compare June 24, 2025 16:23
@eldenmoon
Copy link
Member Author

eldenmoon commented Jun 24, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 24, 2025

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.25% (1123/1349)
Line Coverage 66.86% (19365/28962)
Region Coverage 66.52% (9580/14402)
Branch Coverage 56.54% (5207/9210)

@eldenmoon
Copy link
Member Author

eldenmoon commented Jun 25, 2025

run buildall

@eldenmoon eldenmoon changed the title Branch 3.1 variant feature Branch 3.1 [Feature](Variant) support variant sparse feature and schema template with multi indexes Jun 25, 2025
@doris-robot
Copy link

doris-robot commented Jun 25, 2025

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.25% (1123/1349)
Line Coverage 66.75% (19332/28962)
Region Coverage 66.44% (9569/14402)
Branch Coverage 56.48% (5202/9210)

@eldenmoon
Copy link
Member Author

eldenmoon commented Jun 25, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 25, 2025

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.25% (1123/1349)
Line Coverage 66.85% (19361/28962)
Region Coverage 66.46% (9572/14402)
Branch Coverage 56.53% (5206/9210)

@eldenmoon eldenmoon force-pushed the branch-3.1-variant-feature branch from be2d029 to 90a91d3 Compare June 25, 2025 16:57
@eldenmoon
Copy link
Member Author

eldenmoon commented Jun 25, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 25, 2025

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.25% (1123/1349)
Line Coverage 66.80% (19348/28962)
Region Coverage 66.55% (9585/14402)
Branch Coverage 56.56% (5209/9210)

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 25, 2025

BE UT Coverage Report

Increment line coverage 80.19% (4250/5300) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 44.45% (12081/27180)
Line Coverage 35.16% (105332/299596)
Region Coverage 34.07% (54200/159095)
Branch Coverage 30.81% (28414/92230)

@eldenmoon eldenmoon force-pushed the branch-3.1-variant-feature branch from 90a91d3 to e08ae7a Compare June 26, 2025 03:07
@eldenmoon
Copy link
Member Author

eldenmoon commented Jun 26, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 26, 2025

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.43% (1128/1352)
Line Coverage 67.21% (19630/29207)
Region Coverage 66.88% (9678/14470)
Branch Coverage 56.84% (5263/9260)

@eldenmoon
Copy link
Member Author

eldenmoon commented Jun 26, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jun 26, 2025

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.43% (1128/1352)
Line Coverage 67.21% (19630/29207)
Region Coverage 66.88% (9678/14470)
Branch Coverage 56.85% (5264/9260)

@doris-robot
Copy link

doris-robot commented Jun 26, 2025

BE UT Coverage Report

Increment line coverage 80.19% (4250/5300) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 44.85% (12293/27409)
Line Coverage 35.85% (108719/303221)
Region Coverage 34.89% (56274/161302)
Branch Coverage 31.97% (30490/95364)

@morrySnow morrySnow merged commit c302687 into apache:branch-3.1 Jun 26, 2025
18 of 21 checks passed
@eldenmoon eldenmoon deleted the branch-3.1-variant-feature branch June 26, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eldenmoon @hello-stephen @doris-robot @morrySnow