-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](column) fix ColumnWithTypeAndName::get_nested use-after-free when input Const(Nullable) column #48288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](column) fix ColumnWithTypeAndName::get_nested use-after-free when input Const(Nullable) column #48288
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 31645 ms |
TPC-DS: Total hot run time: 190904 ms |
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 31.17 s |
…en input Const(Nullable) column (apache#48288) ### What problem does this PR solve? error code ``` ColumnPtr nested_column = column; if (column) { nested_column = nested_column->convert_to_full_column_if_const(); const auto* source_column = assert_cast<const ColumnNullable*>(nested_column.get()); nested_column = source_column->get_nested_column_ptr(); ``` If column is a const(nullable) column, execute: nested_column = nested_column->convert_to_full_column_if_const(); nested_column points to a new nullable column. Execute: const auto* source_column = assert_cast<const ColumnNullable*>(nested_column.get()); source_column, this raw pointer, points to the new nullable column (but does not have ownership). Execute: nested_column = source_column->get_nested_column_ptr(); nested_column points to the nested column of the new nullable column, and the original nullable column is released. ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [x] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [x] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [x] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [x] Confirm the release note - [x] Confirm test cases - [x] Confirm document - [x] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
…en input Const(Nullable) column (apache#48288) ### What problem does this PR solve? error code ``` ColumnPtr nested_column = column; if (column) { nested_column = nested_column->convert_to_full_column_if_const(); const auto* source_column = assert_cast<const ColumnNullable*>(nested_column.get()); nested_column = source_column->get_nested_column_ptr(); ``` If column is a const(nullable) column, execute: nested_column = nested_column->convert_to_full_column_if_const(); nested_column points to a new nullable column. Execute: const auto* source_column = assert_cast<const ColumnNullable*>(nested_column.get()); source_column, this raw pointer, points to the new nullable column (but does not have ownership). Execute: nested_column = source_column->get_nested_column_ptr(); nested_column points to the nested column of the new nullable column, and the original nullable column is released. ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [x] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [x] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [x] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [x] Confirm the release note - [x] Confirm test cases - [x] Confirm document - [x] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
…en input Const(Nullable) column (#48288) ### What problem does this PR solve? error code ``` ColumnPtr nested_column = column; if (column) { nested_column = nested_column->convert_to_full_column_if_const(); const auto* source_column = assert_cast<const ColumnNullable*>(nested_column.get()); nested_column = source_column->get_nested_column_ptr(); ``` If column is a const(nullable) column, execute: nested_column = nested_column->convert_to_full_column_if_const(); nested_column points to a new nullable column. Execute: const auto* source_column = assert_cast<const ColumnNullable*>(nested_column.get()); source_column, this raw pointer, points to the new nullable column (but does not have ownership). Execute: nested_column = source_column->get_nested_column_ptr(); nested_column points to the nested column of the new nullable column, and the original nullable column is released. ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [x] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [x] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [x] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [x] Confirm the release note - [x] Confirm test cases - [x] Confirm document - [x] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
…en input Const(Nullable) column (#48288) ### What problem does this PR solve? error code ``` ColumnPtr nested_column = column; if (column) { nested_column = nested_column->convert_to_full_column_if_const(); const auto* source_column = assert_cast<const ColumnNullable*>(nested_column.get()); nested_column = source_column->get_nested_column_ptr(); ``` If column is a const(nullable) column, execute: nested_column = nested_column->convert_to_full_column_if_const(); nested_column points to a new nullable column. Execute: const auto* source_column = assert_cast<const ColumnNullable*>(nested_column.get()); source_column, this raw pointer, points to the new nullable column (but does not have ownership). Execute: nested_column = source_column->get_nested_column_ptr(); nested_column points to the nested column of the new nullable column, and the original nullable column is released. ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [x] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [x] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [x] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [x] Confirm the release note - [x] Confirm test cases - [x] Confirm document - [x] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
…en input Const(Nullable) column (apache#48288) ### What problem does this PR solve? error code ``` ColumnPtr nested_column = column; if (column) { nested_column = nested_column->convert_to_full_column_if_const(); const auto* source_column = assert_cast<const ColumnNullable*>(nested_column.get()); nested_column = source_column->get_nested_column_ptr(); ``` If column is a const(nullable) column, execute: nested_column = nested_column->convert_to_full_column_if_const(); nested_column points to a new nullable column. Execute: const auto* source_column = assert_cast<const ColumnNullable*>(nested_column.get()); source_column, this raw pointer, points to the new nullable column (but does not have ownership). Execute: nested_column = source_column->get_nested_column_ptr(); nested_column points to the nested column of the new nullable column, and the original nullable column is released. ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [x] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [x] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [x] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [x] Confirm the release note - [x] Confirm test cases - [x] Confirm document - [x] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
…en input Const(Nullable) column apache#48288 (apache#3827) apache#48288
…en input Const(Nullable) column (apache#48288) ### What problem does this PR solve? error code ``` ColumnPtr nested_column = column; if (column) { nested_column = nested_column->convert_to_full_column_if_const(); const auto* source_column = assert_cast<const ColumnNullable*>(nested_column.get()); nested_column = source_column->get_nested_column_ptr(); ``` If column is a const(nullable) column, execute: nested_column = nested_column->convert_to_full_column_if_const(); nested_column points to a new nullable column. Execute: const auto* source_column = assert_cast<const ColumnNullable*>(nested_column.get()); source_column, this raw pointer, points to the new nullable column (but does not have ownership). Execute: nested_column = source_column->get_nested_column_ptr(); nested_column points to the nested column of the new nullable column, and the original nullable column is released. ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [x] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [x] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [x] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [x] Confirm the release note - [x] Confirm test cases - [x] Confirm document - [x] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
What problem does this PR solve?
error code
If column is a const(nullable) column,
execute: nested_column = nested_column->convert_to_full_column_if_const();
nested_column points to a new nullable column.
Execute: const auto* source_column = assert_cast<const ColumnNullable*>(nested_column.get());
source_column, this raw pointer, points to the new nullable column (but does not have ownership).
Execute: nested_column = source_column->get_nested_column_ptr();
nested_column points to the nested column of the new nullable column, and the original nullable column is released.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)