-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[opt](vault) Check hdfs connectivity when creating hdfs storage vault #48369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
#48351 当前pr依赖48351的bugfix先合入 |
TPC-H: Total hot run time: 32072 ms |
TPC-DS: Total hot run time: 185016 ms |
ClickBench: Total hot run time: 30.81 s |
07a9c0d to
cd1ff86
Compare
|
run buildall |
TPC-H: Total hot run time: 31764 ms |
TPC-DS: Total hot run time: 184582 ms |
ClickBench: Total hot run time: 30.31 s |
|
run feut |
cd1ff86 to
6e159b8
Compare
|
run buildall |
TPC-H: Total hot run time: 31644 ms |
TPC-DS: Total hot run time: 190703 ms |
ClickBench: Total hot run time: 30.62 s |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| newProperties, "=", true, false, true, false)); | ||
| } | ||
| } catch (IOException e) { | ||
| LOG.warn("checkConnectivity failed, properties:{}", new PrintableMap<>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'd better print vault name in log
22c87b8
6e159b8 to
22c87b8
Compare
hust-hhb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
If you just want to check the connection, you can do it this way. However, if you want to check whether the cluster is available, it's best to create a file, randomly write a string of characters, and then close the file, because if the datanode is down, creating a directory is ok in hdfs. |
|
run buildall |
TPC-H: Total hot run time: 32745 ms |
TPC-DS: Total hot run time: 184721 ms |
ClickBench: Total hot run time: 31.44 s |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
…#48369) When creating an HDFS storage vault, perform connection and permission checks to avoid outputting error messages that could cause the storage vault to throw errors during usage after creation.
…apache#48369) When creating an HDFS storage vault, perform connection and permission checks to avoid outputting error messages that could cause the storage vault to throw errors during usage after creation.
What problem does this PR solve?
When creating an HDFS storage vault, perform connection and permission checks to avoid outputting error messages that could cause the storage vault to throw errors during usage after creation.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)