-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Fix](remote-fs)Change closed Field to Instance-Level to Avoid Global Shutdown Issues in RemoteFileSystem #48351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix](remote-fs)Change closed Field to Instance-Level to Avoid Global Shutdown Issues in RemoteFileSystem #48351
Conversation
… Shutdown Issues in RemoteFileSystem ### PR Description: Change Background: The closed field in the current RemoteFileSystem class is static, meaning it is shared globally across all instances of the class. This design leads to issues when multiple parts of the application use RemoteFileSystem and attempt to close it. Once one instance is closed, the static closed field is set to true, causing other instances to incorrectly report that the file system is unavailable. This can cause confusion and inconsistent behavior, especially when multiple threads are involved. ### Change Details: closed Field: The closed field has been moved from a static field to an instance-level field. This ensures that each RemoteFileSystem instance maintains its own shutdown status, eliminating the problem of shared state between instances.
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
swjtu-zhanglei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 31820 ms |
TPC-DS: Total hot run time: 184182 ms |
ClickBench: Total hot run time: 30.69 s |
|
run p0 |
|
run cloudp0 |
|
run p0 |
… Shutdown Issues in RemoteFileSystem (#48351) ### PR Description: Change Background: The closed field in the current RemoteFileSystem class is static, meaning it is shared globally across all instances of the class. This design leads to issues when multiple parts of the application use RemoteFileSystem and attempt to close it. Once one instance is closed, the static closed field is set to true, causing other instances to incorrectly report that the file system is unavailable. This can cause confusion and inconsistent behavior, especially when multiple threads are involved. ### Change Details: closed Field: The closed field has been moved from a static field to an instance-level field. This ensures that each RemoteFileSystem instance maintains its own shutdown status, eliminating the problem of shared state between instances.
… Shutdown Issues in RemoteFileSystem (#48351) ### PR Description: Change Background: The closed field in the current RemoteFileSystem class is static, meaning it is shared globally across all instances of the class. This design leads to issues when multiple parts of the application use RemoteFileSystem and attempt to close it. Once one instance is closed, the static closed field is set to true, causing other instances to incorrectly report that the file system is unavailable. This can cause confusion and inconsistent behavior, especially when multiple threads are involved. ### Change Details: closed Field: The closed field has been moved from a static field to an instance-level field. This ensures that each RemoteFileSystem instance maintains its own shutdown status, eliminating the problem of shared state between instances.
… Shutdown Issues in RemoteFileSystem (apache#48351) ### PR Description: Change Background: The closed field in the current RemoteFileSystem class is static, meaning it is shared globally across all instances of the class. This design leads to issues when multiple parts of the application use RemoteFileSystem and attempt to close it. Once one instance is closed, the static closed field is set to true, causing other instances to incorrectly report that the file system is unavailable. This can cause confusion and inconsistent behavior, especially when multiple threads are involved. ### Change Details: closed Field: The closed field has been moved from a static field to an instance-level field. This ensures that each RemoteFileSystem instance maintains its own shutdown status, eliminating the problem of shared state between instances.
… Shutdown Issues in RemoteFileSystem (apache#48351) ### PR Description: Change Background: The closed field in the current RemoteFileSystem class is static, meaning it is shared globally across all instances of the class. This design leads to issues when multiple parts of the application use RemoteFileSystem and attempt to close it. Once one instance is closed, the static closed field is set to true, causing other instances to incorrectly report that the file system is unavailable. This can cause confusion and inconsistent behavior, especially when multiple threads are involved. ### Change Details: closed Field: The closed field has been moved from a static field to an instance-level field. This ensures that each RemoteFileSystem instance maintains its own shutdown status, eliminating the problem of shared state between instances.
… Shutdown Issues in RemoteFileSystem (apache#48351) ### PR Description: Change Background: The closed field in the current RemoteFileSystem class is static, meaning it is shared globally across all instances of the class. This design leads to issues when multiple parts of the application use RemoteFileSystem and attempt to close it. Once one instance is closed, the static closed field is set to true, causing other instances to incorrectly report that the file system is unavailable. This can cause confusion and inconsistent behavior, especially when multiple threads are involved. ### Change Details: closed Field: The closed field has been moved from a static field to an instance-level field. This ensures that each RemoteFileSystem instance maintains its own shutdown status, eliminating the problem of shared state between instances.
… Shutdown Issues in RemoteFileSystem (apache#48351) ### PR Description: Change Background: The closed field in the current RemoteFileSystem class is static, meaning it is shared globally across all instances of the class. This design leads to issues when multiple parts of the application use RemoteFileSystem and attempt to close it. Once one instance is closed, the static closed field is set to true, causing other instances to incorrectly report that the file system is unavailable. This can cause confusion and inconsistent behavior, especially when multiple threads are involved. ### Change Details: closed Field: The closed field has been moved from a static field to an instance-level field. This ensures that each RemoteFileSystem instance maintains its own shutdown status, eliminating the problem of shared state between instances.
PR Description:
Change Background:
The closed field in the current RemoteFileSystem class is static, meaning it is shared globally across all instances of the class. This design leads to issues when multiple parts of the application use RemoteFileSystem and attempt to close it. Once one instance is closed, the static closed field is set to true, causing other instances to incorrectly report that the file system is unavailable. This can cause confusion and inconsistent behavior, especially when multiple threads are involved.
Change Details:
closed Field: The closed field has been moved from a static field to an instance-level field. This ensures that each RemoteFileSystem instance maintains its own shutdown status, eliminating the problem of shared state between instances.
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)