Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #48351

… Shutdown Issues in RemoteFileSystem (#48351)

### PR Description:
Change Background:
The closed field in the current RemoteFileSystem class is static,
meaning it is shared globally across all instances of the class. This
design leads to issues when multiple parts of the application use
RemoteFileSystem and attempt to close it. Once one instance is closed,
the static closed field is set to true, causing other instances to
incorrectly report that the file system is unavailable. This can cause
confusion and inconsistent behavior, especially when multiple threads
are involved.

### Change Details:
closed Field: The closed field has been moved from a static field to an
instance-level field. This ensures that each RemoteFileSystem instance
maintains its own shutdown status, eliminating the problem of shared
state between instances.
@Thearas
Copy link
Contributor

Thearas commented Feb 26, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Feb 26, 2025
@Thearas
Copy link
Contributor

Thearas commented Feb 26, 2025

run buildall

@morningman morningman merged commit 11d8030 into branch-2.1 Feb 26, 2025
18 of 19 checks passed
@github-actions github-actions bot deleted the auto-pick-48351-branch-2.1 branch February 26, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants