Skip to content

branch-3.0: [improve](load) improve error message in commit #48316 #48436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Feb 28, 2025
Merged

branch-3.0: [improve](load) improve error message in commit #48316 #48436

dataroaring merged 1 commit into from
Feb 28, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Feb 27, 2025

Cherry-picked from #48316

@kaijchen
[improve](load) improve error message in commit (#48316)
feb72e9 
In a 3-replica setup, when the BE detects a write error on one replica,
it continues submitting the commit information. If the FE checks the
commit status and finds that one of the two successful replicas is
missing the previous version, an error is returned. However, since the
BE does not report the failure reason, the FE's error message does not
provide details on the underlying cause.

This PR improves the error message for this scenario. It advises users
to check the BE logs and SHOW TABLET for more detailed error reasons and
suggests retrying the operation later.
@Thearas
Copy link
Contributor

Thearas commented Feb 27, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Feb 27, 2025
@Thearas
Copy link
Contributor

Thearas commented Feb 27, 2025

run buildall

dataroaring
dataroaring approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 28, 2025
@github-actions
Copy link
Contributor Author

github-actions bot commented Feb 28, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor Author

github-actions bot commented Feb 28, 2025

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit c67d4ca into branch-3.0 Feb 28, 2025
22 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-48316-branch-3.0 branch February 28, 2025 09:34
@gavinchou gavinchou mentioned this pull request Apr 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Thearas @dataroaring @kaijchen