Skip to content

branch-3.0: [improve](load) improve error message in commit #48316 #48436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 1 commit into from
Feb 28, 2025
Merged

branch-3.0: [improve](load) improve error message in commit #48316 #48436

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,7 @@ private void checkCommitStatus(List<Table> tableList, TransactionState transacti

String errMsg = String.format("Failed to commit txn %s, cause tablet %s succ replica num %s"
+ " < load required replica num %s. table %s, partition: [ id=%s, commit version %s"
+ ", visible version %s ], this tablet detail: %s",
+ ", visible version %s ], this tablet detail: %s. Please try again later.",
transactionId, tablet.getId(), successReplicaNum, loadRequiredReplicaNum, tableId,
partition.getId(), partition.getCommittedVersion(), partition.getVisibleVersion(),
writeDetail);
Expand All @@ -659,14 +659,14 @@ private String getTabletWriteDetail(List<Replica> tabletSuccReplicas, List<Repli
.collect(Collectors.toList())));
}
if (!tabletWriteFailedReplicas.isEmpty()) {
writeDetail += String.format("%s replicas write data failed: { %s }; ",
writeDetail += String.format("%s replicas write data failed: { %s }, please check BE log for details; ",
tabletWriteFailedReplicas.size(), Joiner.on(", ").join(
tabletWriteFailedReplicas.stream().map(replica -> replica.toStringSimple(true))
.collect(Collectors.toList())));
}
if (!tabletVersionFailedReplicas.isEmpty()) {
writeDetail += String.format("%s replicas write data succ but miss previous "
+ "version: { %s }.",
+ "version: { %s }, please check output of SHOW TABLET for details",
tabletVersionFailedReplicas.size(), Joiner.on(",").join(
tabletVersionFailedReplicas.stream().map(replica -> replica.toStringSimple(true))
.collect(Collectors.toList())));
Expand Down
Loading