Skip to content

branch-2.1: [fix](jdbc catalog) Use factory methods to return mapped types instead 2 #48541 #48586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 1 commit into from
Mar 4, 2025
Merged

branch-2.1: [fix](jdbc catalog) Use factory methods to return mapped types instead 2 #48541 #48586

morningman merged 1 commit into from
Mar 4, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Mar 3, 2025

Cherry-picked from #48541

@zy-kkk
[fix](jdbc catalog) Use factory methods to return mapped types instea…
8f261f9 
…d 2 (#48541)

Related PR: #46623

Problem Summary:

We should use factory methods to create types instead of returning a
type directly, because the returned type is static and final, which will
cause problems with length setting.


external_table_p0/jdbc/type_test/select/test_doris_all_types_select.groovy
will occasionally fail due to this problem
@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 3, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Mar 3, 2025
@dataroaring dataroaring reopened this Mar 3, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 3, 2025

run buildall

@morningman morningman merged commit ad16958 into branch-2.1 Mar 4, 2025
19 checks passed
@github-actions github-actions bot deleted the auto-pick-48541-branch-2.1 branch March 4, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hello-stephen @morningman @dataroaring @zy-kkk