-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](jdbc catalog) Use factory methods to return mapped types instead 2 #48541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
morningman
approved these changes
Mar 3, 2025
Contributor
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 31758 ms |
TPC-DS: Total hot run time: 190810 ms |
ClickBench: Total hot run time: 30.53 s |
morningman
approved these changes
Mar 3, 2025
wuwenchi
approved these changes
Mar 3, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Mar 3, 2025
…d 2 (#48541) Related PR: #46623 Problem Summary: We should use factory methods to create types instead of returning a type directly, because the returned type is static and final, which will cause problems with length setting. external_table_p0/jdbc/type_test/select/test_doris_all_types_select.groovy will occasionally fail due to this problem
github-actions bot
pushed a commit
that referenced
this pull request
Mar 3, 2025
…d 2 (#48541) Related PR: #46623 Problem Summary: We should use factory methods to create types instead of returning a type directly, because the returned type is static and final, which will cause problems with length setting. external_table_p0/jdbc/type_test/select/test_doris_all_types_select.groovy will occasionally fail due to this problem
Closed
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…d 2 (apache#48541) Related PR: apache#46623 Problem Summary: We should use factory methods to create types instead of returning a type directly, because the returned type is static and final, which will cause problems with length setting. external_table_p0/jdbc/type_test/select/test_doris_all_types_select.groovy will occasionally fail due to this problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by one committer.
dev/2.1.9-merged
dev/3.0.5-merged
p0_test
reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: #46623
Problem Summary:
We should use factory methods to create types instead of returning a type directly, because the returned type is static and final, which will cause problems with length setting.
external_table_p0/jdbc/type_test/select/test_doris_all_types_select.groovy
will occasionally fail due to this problem