Skip to content

Conversation

@zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented Mar 3, 2025

Related PR: #46623

Problem Summary:

We should use factory methods to create types instead of returning a type directly, because the returned type is static and final, which will cause problems with length setting.

external_table_p0/jdbc/type_test/select/test_doris_all_types_select.groovy
will occasionally fail due to this problem

@Thearas
Copy link
Contributor

Thearas commented Mar 3, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zy-kkk
Copy link
Member Author

zy-kkk commented Mar 3, 2025

run buildall

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2025

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 31758 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4bd917cb7bd1fa39ff644871bd10f9154059a02d, data reload: false

------ Round 1 ----------------------------------
q1	17593	5280	5085	5085
q2	2045	296	168	168
q3	10407	1263	733	733
q4	10204	1012	529	529
q5	7529	2420	2288	2288
q6	187	167	131	131
q7	898	748	605	605
q8	9309	1217	1052	1052
q9	4839	4869	4827	4827
q10	6804	2300	1882	1882
q11	496	278	254	254
q12	346	361	229	229
q13	17755	3686	3089	3089
q14	250	225	212	212
q15	522	469	452	452
q16	630	628	588	588
q17	583	847	335	335
q18	6767	6233	6411	6233
q19	1208	962	540	540
q20	321	332	203	203
q21	2827	2275	2024	2024
q22	364	342	299	299
Total cold run time: 101884 ms
Total hot run time: 31758 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5125	5114	5148	5114
q2	233	333	230	230
q3	2198	2719	2334	2334
q4	1432	1837	1419	1419
q5	4194	4070	4131	4070
q6	202	164	124	124
q7	1858	1804	1687	1687
q8	2606	2528	2650	2528
q9	7204	7140	7142	7140
q10	3024	3239	2818	2818
q11	590	526	508	508
q12	688	772	621	621
q13	3413	3890	3288	3288
q14	279	292	268	268
q15	512	479	476	476
q16	659	687	630	630
q17	1145	1560	1347	1347
q18	7563	7327	7239	7239
q19	785	766	910	766
q20	1973	2039	1866	1866
q21	5454	5064	4725	4725
q22	626	583	562	562
Total cold run time: 51763 ms
Total hot run time: 49760 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190810 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4bd917cb7bd1fa39ff644871bd10f9154059a02d, data reload: false

query1	1318	933	943	933
query2	6405	1906	1867	1867
query3	11186	4708	4595	4595
query4	57652	24719	23390	23390
query5	5251	488	463	463
query6	360	178	183	178
query7	5076	498	293	293
query8	325	239	244	239
query9	6552	2523	2542	2523
query10	443	295	259	259
query11	15142	15055	14853	14853
query12	165	112	108	108
query13	1163	531	378	378
query14	10232	7566	6876	6876
query15	214	196	200	196
query16	7043	668	495	495
query17	1081	722	615	615
query18	1072	408	326	326
query19	212	202	163	163
query20	133	125	125	125
query21	207	130	109	109
query22	4261	4649	4308	4308
query23	34001	33346	33325	33325
query24	5760	2417	2426	2417
query25	458	457	386	386
query26	698	285	159	159
query27	1781	493	331	331
query28	2926	2465	2408	2408
query29	538	565	418	418
query30	217	210	156	156
query31	873	870	804	804
query32	72	62	58	58
query33	450	355	301	301
query34	786	849	503	503
query35	823	839	768	768
query36	963	969	909	909
query37	114	98	76	76
query38	4181	4149	4244	4149
query39	1482	1486	1467	1467
query40	221	115	103	103
query41	52	53	56	53
query42	124	109	111	109
query43	492	525	486	486
query44	1304	832	811	811
query45	181	179	169	169
query46	876	1067	653	653
query47	1881	1863	1786	1786
query48	395	415	307	307
query49	696	500	429	429
query50	710	764	423	423
query51	4294	4255	4308	4255
query52	109	105	104	104
query53	253	256	191	191
query54	478	509	444	444
query55	87	80	76	76
query56	272	275	287	275
query57	1179	1172	1098	1098
query58	244	240	241	240
query59	2747	2919	2712	2712
query60	283	286	252	252
query61	137	117	120	117
query62	744	754	703	703
query63	242	190	204	190
query64	1444	1029	740	740
query65	3340	3274	3256	3256
query66	686	391	298	298
query67	15908	15378	15288	15288
query68	7606	867	495	495
query69	551	353	264	264
query70	1216	1096	1105	1096
query71	495	288	267	267
query72	5757	3537	3707	3537
query73	1187	702	354	354
query74	8952	8992	8770	8770
query75	3614	3181	2681	2681
query76	4158	1158	724	724
query77	622	372	277	277
query78	10159	10145	9325	9325
query79	2793	828	592	592
query80	799	539	437	437
query81	515	281	246	246
query82	674	121	95	95
query83	174	169	158	158
query84	293	89	86	86
query85	798	407	295	295
query86	420	292	288	288
query87	4402	4558	4380	4380
query88	3589	2238	2179	2179
query89	413	320	295	295
query90	1797	193	189	189
query91	134	136	109	109
query92	71	59	56	56
query93	2339	1052	563	563
query94	662	404	283	283
query95	344	269	256	256
query96	484	561	265	265
query97	3378	3417	3300	3300
query98	229	204	197	197
query99	1430	1406	1256	1256
Total cold run time: 301050 ms
Total hot run time: 190810 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.53 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4bd917cb7bd1fa39ff644871bd10f9154059a02d, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.03	0.03
query3	0.22	0.07	0.07
query4	1.61	0.10	0.10
query5	0.56	0.55	0.55
query6	1.20	0.72	0.71
query7	0.02	0.01	0.02
query8	0.04	0.04	0.04
query9	0.59	0.53	0.53
query10	0.57	0.58	0.57
query11	0.15	0.10	0.10
query12	0.15	0.12	0.11
query13	0.61	0.60	0.60
query14	2.68	2.70	2.73
query15	0.92	0.85	0.84
query16	0.40	0.39	0.38
query17	1.03	1.04	1.02
query18	0.22	0.20	0.20
query19	1.88	1.79	1.97
query20	0.01	0.01	0.01
query21	15.36	0.93	0.54
query22	0.75	1.12	0.75
query23	14.87	1.36	0.63
query24	6.64	1.57	0.35
query25	0.54	0.17	0.12
query26	0.71	0.15	0.14
query27	0.06	0.05	0.05
query28	9.93	0.93	0.42
query29	12.57	3.93	3.32
query30	0.24	0.09	0.06
query31	2.81	0.57	0.38
query32	3.22	0.56	0.46
query33	2.98	3.03	3.06
query34	15.89	5.14	4.55
query35	4.53	4.55	4.53
query36	0.71	0.50	0.49
query37	0.09	0.06	0.07
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.17	0.13	0.13
query41	0.07	0.02	0.02
query42	0.04	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 105.27 s
Total hot run time: 30.53 s

@morningman morningman merged commit 8def32d into apache:master Mar 3, 2025
31 of 33 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 3, 2025
…d 2 (#48541)

Related PR: #46623

Problem Summary:

We should use factory methods to create types instead of returning a
type directly, because the returned type is static and final, which will
cause problems with length setting.


external_table_p0/jdbc/type_test/select/test_doris_all_types_select.groovy
will occasionally fail due to this problem
github-actions bot pushed a commit that referenced this pull request Mar 3, 2025
…d 2 (#48541)

Related PR: #46623

Problem Summary:

We should use factory methods to create types instead of returning a
type directly, because the returned type is static and final, which will
cause problems with length setting.


external_table_p0/jdbc/type_test/select/test_doris_all_types_select.groovy
will occasionally fail due to this problem
@zy-kkk zy-kkk added p0_test and removed p0_b labels Mar 4, 2025
morningman pushed a commit that referenced this pull request Mar 4, 2025
…types instead 2 #48541 (#48586)

Cherry-picked from #48541

Co-authored-by: zy-kkk <zhongyk10@gmail.com>
dataroaring pushed a commit that referenced this pull request Mar 4, 2025
…types instead 2 #48541 (#48585)

Cherry-picked from #48541

Co-authored-by: zy-kkk <zhongyk10@gmail.com>
@gavinchou gavinchou mentioned this pull request Apr 23, 2025
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
…d 2 (apache#48541)

Related PR: apache#46623

Problem Summary:

We should use factory methods to create types instead of returning a
type directly, because the returned type is static and final, which will
cause problems with length setting.


external_table_p0/jdbc/type_test/select/test_doris_all_types_select.groovy
will occasionally fail due to this problem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.9-merged dev/3.0.5-merged p0_test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants