-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix] (inverted index) Fix UTF-8 4-byte truncation issue and add configuration to control correct term writing #48657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…iguration to control correct term writing
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
…iguration to control correct term writing
|
run buildall |
qidaye
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
zzzxl1993
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TPC-H: Total hot run time: 32700 ms |
TPC-DS: Total hot run time: 185277 ms |
ClickBench: Total hot run time: 31.29 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
TPC-H: Total hot run time: 32677 ms |
TPC-DS: Total hot run time: 186628 ms |
ClickBench: Total hot run time: 31.14 s |
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 32350 ms |
TPC-DS: Total hot run time: 191833 ms |
ClickBench: Total hot run time: 30.83 s |
qidaye
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
…iguration to control correct term writing (apache#48657) Problem Summary: Added the `enable_inverted_index_correct_term_write` configuration as a compatibility option to fix the issue of term truncation caused by special characters. In some situations, a rollback may be necessary after an upgrade. To accommodate this, the initial goal is to set `enable_inverted_index_correct_term_write=false`, prioritizing compatibility with correct term reading before enabling correct term writing. Once reading is confirmed to be working correctly, the configuration can be switched to `enable_inverted_index_correct_term_write=true` to write non-truncated terms properly.
…iguration to control correct term writing (apache#48657) Problem Summary: Added the `enable_inverted_index_correct_term_write` configuration as a compatibility option to fix the issue of term truncation caused by special characters. In some situations, a rollback may be necessary after an upgrade. To accommodate this, the initial goal is to set `enable_inverted_index_correct_term_write=false`, prioritizing compatibility with correct term reading before enabling correct term writing. Once reading is confirmed to be working correctly, the configuration can be switched to `enable_inverted_index_correct_term_write=true` to write non-truncated terms properly.
…iguration to control correct term writing (apache#48657) Problem Summary: Added the `enable_inverted_index_correct_term_write` configuration as a compatibility option to fix the issue of term truncation caused by special characters. In some situations, a rollback may be necessary after an upgrade. To accommodate this, the initial goal is to set `enable_inverted_index_correct_term_write=false`, prioritizing compatibility with correct term reading before enabling correct term writing. Once reading is confirmed to be working correctly, the configuration can be switched to `enable_inverted_index_correct_term_write=true` to write non-truncated terms properly.
…iguration to control correct term writing (apache#48657) (apache#48792) (apache#3803) cherry pick from apache#48657
…iguration to control correct term writing (apache#48657) Problem Summary: Added the `enable_inverted_index_correct_term_write` configuration as a compatibility option to fix the issue of term truncation caused by special characters. In some situations, a rollback may be necessary after an upgrade. To accommodate this, the initial goal is to set `enable_inverted_index_correct_term_write=false`, prioritizing compatibility with correct term reading before enabling correct term writing. Once reading is confirmed to be working correctly, the configuration can be switched to `enable_inverted_index_correct_term_write=true` to write non-truncated terms properly.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Added the
enable_inverted_index_correct_term_writeconfiguration as a compatibility option to fix the issue of term truncation caused by special characters. In some situations, a rollback may be necessary after an upgrade. To accommodate this, the initial goal is to setenable_inverted_index_correct_term_write=false, prioritizing compatibility with correct term reading before enabling correct term writing. Once reading is confirmed to be working correctly, the configuration can be switched toenable_inverted_index_correct_term_write=trueto write non-truncated terms properly.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)