Skip to content

branch-2.1:[fix] (inverted index) Fix UTF-8 4-byte truncation issue and add configuration to control correct term writing (#48657) #48741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
airborne12 merged 2 commits into from
Mar 6, 2025
Merged

branch-2.1:[fix] (inverted index) Fix UTF-8 4-byte truncation issue and add configuration to control correct term writing (#48657) #48741

airborne12 merged 2 commits into from
Mar 6, 2025

Conversation

@airborne12
Copy link
Member

@airborne12 airborne12 commented Mar 6, 2025

Cherry-picked from #48657

@airborne12
[fix] (inverted index) Fix UTF-8 4-byte truncation issue and add conf…
d9b7b86 
…iguration to control correct term writing (apache#48657)

Problem Summary:
Added the `enable_inverted_index_correct_term_write` configuration as a
compatibility option to fix the issue of term truncation caused by
special characters. In some situations, a rollback may be necessary
after an upgrade. To accommodate this, the initial goal is to set
`enable_inverted_index_correct_term_write=false`, prioritizing
compatibility with correct term reading before enabling correct term
writing. Once reading is confirmed to be working correctly, the
configuration can be switched to
`enable_inverted_index_correct_term_write=true` to write non-truncated
terms properly.
@Thearas
Copy link
Contributor

Thearas commented Mar 6, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@airborne12
Copy link
Member Author

airborne12 commented Mar 6, 2025

run buildall

@airborne12
Copy link
Member Author

airborne12 commented Mar 6, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Mar 6, 2025

BE UT Coverage Report

Increment line coverage 33.33% (1/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 37.10% (9771/26338)
Line Coverage 28.76% (81623/283815)
Region Coverage 27.33% (41782/152905)
Branch Coverage 24.04% (21200/88194)

@airborne12 airborne12 merged commit 3f684f2 into apache:branch-2.1 Mar 6, 2025
17 of 19 checks passed
@airborne12 airborne12 deleted the fix-4bytes branch March 6, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@airborne12 @Thearas @doris-robot