Skip to content

Conversation

@amorynan
Copy link
Contributor

@amorynan amorynan commented Mar 7, 2025

…rk byte order (#47126)

What problem does this PR solve?

Enhance ipv6 type to accept uint128 strings in network byte order.
according to function : ipv6_from_uint128_string_or_null(string) For load we can load the uint128 number like
338288524927261089657673092949903306134 using function
ipv6_from_uint128_string_or_null
or just using function in select sql

mysql> select
ipv6_from_uint128_string_or_null('340282366920938463463374607431768211455');

+-----------------------------------------------------------------------------+
|
ipv6_from_uint128_string_or_null('340282366920938463463374607431768211455')
|

+-----------------------------------------------------------------------------+
| ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff |

+-----------------------------------------------------------------------------+
1 row in set (0.06 sec)
```、

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
  - [ ] Regression test
  - [ ] Unit Test
  - [ ] Manual test (add detailed scripts or steps below)
  - [ ] No need to test or manual test. Explain why:
      - [ ] This is a refactor/code format and no logic has been changed.
      - [ ] Previous test can cover this change.
      - [ ] No code files have been changed.
      - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
  - [ ] No.
  - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
  - [ ] No.
  - [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->

…k byte order (apache#47126)

### What problem does this PR solve?
 Enhance ipv6  type to accept uint128 strings in network byte order. 
according to function : ipv6_from_uint128_string_or_null(string) 
For load we can load the uint128 number like
```338288524927261089657673092949903306134``` using function
ipv6_from_uint128_string_or_null
or just using function in select sql
  ```
mysql> select
ipv6_from_uint128_string_or_null('340282366920938463463374607431768211455');

+-----------------------------------------------------------------------------+
|
ipv6_from_uint128_string_or_null('340282366920938463463374607431768211455')
|

+-----------------------------------------------------------------------------+
| ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff |

+-----------------------------------------------------------------------------+
1 row in set (0.06 sec)
```、
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@amorynan
Copy link
Contributor Author

amorynan commented Mar 7, 2025

run buildall

@amorynan
Copy link
Contributor Author

amorynan commented Mar 7, 2025

run buildall

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 3.45% (2/58) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 37.09% (9772/26344)
Line Coverage 28.77% (81666/283857)
Region Coverage 27.33% (41790/152931)
Branch Coverage 24.04% (21208/88204)

@yiguolei yiguolei merged commit e957a2f into apache:branch-2.1 Mar 8, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants