-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improve](ipv6) Enhance ipv6 type to accept uint128 strings in network byte order #47126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 32362 ms |
TPC-DS: Total hot run time: 194581 ms |
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 30.28 s |
|
run buildall |
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 32457 ms |
TPC-DS: Total hot run time: 187445 ms |
ClickBench: Total hot run time: 30.91 s |
|
TeamCity be ut coverage result: |
HappenLee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
…k byte order (apache#47126) ### What problem does this PR solve? Enhance ipv6 type to accept uint128 strings in network byte order. according to function : ipv6_from_uint128_string_or_null(string) For load we can load the uint128 number like ```338288524927261089657673092949903306134``` using function ipv6_from_uint128_string_or_null or just using function in select sql ``` mysql> select ipv6_from_uint128_string_or_null('340282366920938463463374607431768211455'); +-----------------------------------------------------------------------------+ | ipv6_from_uint128_string_or_null('340282366920938463463374607431768211455') | +-----------------------------------------------------------------------------+ | ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff | +-----------------------------------------------------------------------------+ 1 row in set (0.06 sec) ```、
…k byte order (apache#47126) ### What problem does this PR solve? Enhance ipv6 type to accept uint128 strings in network byte order. according to function : ipv6_from_uint128_string_or_null(string) For load we can load the uint128 number like ```338288524927261089657673092949903306134``` using function ipv6_from_uint128_string_or_null or just using function in select sql ``` mysql> select ipv6_from_uint128_string_or_null('340282366920938463463374607431768211455'); +-----------------------------------------------------------------------------+ | ipv6_from_uint128_string_or_null('340282366920938463463374607431768211455') | +-----------------------------------------------------------------------------+ | ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff | +-----------------------------------------------------------------------------+ 1 row in set (0.06 sec) ```、
…k byte order (#47126) ### What problem does this PR solve? Enhance ipv6 type to accept uint128 strings in network byte order. according to function : ipv6_from_uint128_string_or_null(string) For load we can load the uint128 number like ```338288524927261089657673092949903306134``` using function ipv6_from_uint128_string_or_null or just using function in select sql ``` mysql> select ipv6_from_uint128_string_or_null('340282366920938463463374607431768211455'); +-----------------------------------------------------------------------------+ | ipv6_from_uint128_string_or_null('340282366920938463463374607431768211455') | +-----------------------------------------------------------------------------+ | ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff | +-----------------------------------------------------------------------------+ 1 row in set (0.06 sec) ```、
…k byte order (#47126) ### What problem does this PR solve? Enhance ipv6 type to accept uint128 strings in network byte order. according to function : ipv6_from_uint128_string_or_null(string) For load we can load the uint128 number like ```338288524927261089657673092949903306134``` using function ipv6_from_uint128_string_or_null or just using function in select sql ``` mysql> select ipv6_from_uint128_string_or_null('340282366920938463463374607431768211455'); +-----------------------------------------------------------------------------+ | ipv6_from_uint128_string_or_null('340282366920938463463374607431768211455') | +-----------------------------------------------------------------------------+ | ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff | +-----------------------------------------------------------------------------+ 1 row in set (0.06 sec) ```、
…k byte order (apache#47126) ### What problem does this PR solve? Enhance ipv6 type to accept uint128 strings in network byte order. according to function : ipv6_from_uint128_string_or_null(string) For load we can load the uint128 number like ```338288524927261089657673092949903306134``` using function ipv6_from_uint128_string_or_null or just using function in select sql ``` mysql> select ipv6_from_uint128_string_or_null('340282366920938463463374607431768211455'); +-----------------------------------------------------------------------------+ | ipv6_from_uint128_string_or_null('340282366920938463463374607431768211455') | +-----------------------------------------------------------------------------+ | ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff | +-----------------------------------------------------------------------------+ 1 row in set (0.06 sec) ```、
…#48802) …rk byte order (#47126) ### What problem does this PR solve? Enhance ipv6 type to accept uint128 strings in network byte order. according to function : ipv6_from_uint128_string_or_null(string) For load we can load the uint128 number like ```338288524927261089657673092949903306134``` using function ipv6_from_uint128_string_or_null or just using function in select sql ``` mysql> select ipv6_from_uint128_string_or_null('340282366920938463463374607431768211455'); +-----------------------------------------------------------------------------+ | ipv6_from_uint128_string_or_null('340282366920938463463374607431768211455') | +-----------------------------------------------------------------------------+ | ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff | +-----------------------------------------------------------------------------+ 1 row in set (0.06 sec) ```、
…k byte order (apache#47126) ### What problem does this PR solve? Enhance ipv6 type to accept uint128 strings in network byte order. according to function : ipv6_from_uint128_string_or_null(string) For load we can load the uint128 number like ```338288524927261089657673092949903306134``` using function ipv6_from_uint128_string_or_null or just using function in select sql ``` mysql> select ipv6_from_uint128_string_or_null('340282366920938463463374607431768211455'); +-----------------------------------------------------------------------------+ | ipv6_from_uint128_string_or_null('340282366920938463463374607431768211455') | +-----------------------------------------------------------------------------+ | ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff | +-----------------------------------------------------------------------------+ 1 row in set (0.06 sec) ```、
What problem does this PR solve?
Enhance ipv6 type to accept uint128 strings in network byte order.
according to function : ipv6_from_uint128_string_or_null(string)
For load we can load the uint128 number like
338288524927261089657673092949903306134using functionipv6_from_uint128_string_or_null
or just using function in select sql
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)