Skip to content

branch-3.0: [improve](ipv6) Enhance ipv6 type to accept uint128 strings in network byte order #47126 #48801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
github-actions wants to merge 1 commit into from
Closed

branch-3.0: [improve](ipv6) Enhance ipv6 type to accept uint128 strings in network byte order #47126 #48801

github-actions wants to merge 1 commit into from

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Mar 7, 2025

Cherry-picked from #47126

[improve](ipv6) Enhance ipv6 type to accept uint128 strings in networ…
79c9b63 
…k byte order (#47126)

### What problem does this PR solve?
 Enhance ipv6  type to accept uint128 strings in network byte order. 
according to function : ipv6_from_uint128_string_or_null(string) 
For load we can load the uint128 number like
```338288524927261089657673092949903306134``` using function
ipv6_from_uint128_string_or_null
or just using function in select sql
  ```
mysql> select
ipv6_from_uint128_string_or_null('340282366920938463463374607431768211455');

+-----------------------------------------------------------------------------+
|
ipv6_from_uint128_string_or_null('340282366920938463463374607431768211455')
|

+-----------------------------------------------------------------------------+
| ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff |

+-----------------------------------------------------------------------------+
1 row in set (0.06 sec)
```、
@github-actions github-actions bot requested a review from dataroaring as a code owner March 7, 2025 03:17
@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 7, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Mar 7, 2025
@dataroaring dataroaring reopened this Mar 7, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 7, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Mar 7, 2025

TeamCity cloud ut coverage result:
Function Coverage: 82.26% (1062/1291)
Line Coverage: 65.85% (17626/26765)
Region Coverage: 65.34% (8679/13282)
Branch Coverage: 55.30% (4683/8468)
Coverage Report: http://coverage.selectdb-in.cc/coverage/79c9b634c50f3a2115fe8a788924f95b0c1c7af8_79c9b634c50f3a2115fe8a788924f95b0c1c7af8_cloud/report/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring Awaiting requested review from dataroaring

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hello-stephen @doris-robot @dataroaring