Skip to content

[Bug] Fix bug introduced by split RowsDelFiltered profile #4881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 1 commit into from
Nov 13, 2020
Merged

[Bug] Fix bug introduced by split RowsDelFiltered profile #4881

morningman merged 1 commit into from
Nov 13, 2020

Conversation

@xinyiZzz
Copy link
Contributor

@xinyiZzz xinyiZzz commented Nov 12, 2020 •
edited
Loading

Proposed changes

bug introduced from pr #4825, will cause schema_change to report an error:

schema_change.cpp:1271] fail to check row num! source_rows=1, merged_rows=0, filtered_rows=0, new_index_rows=0
schema_change.cpp:1921] failed to process the version. version=2-2
schema_change.cpp:1615] failed to alter tablet. base_tablet=44643.1383650721.b140317f6662c1e0-65bcbc87db8d22bc, drop new_tablet=45680.1530531459.474e41f3dd538fb6-9284085daac24f83

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

morningman
morningman reviewed Nov 12, 2020
View reviewed changes
be/src/olap/rowset/beta_rowset_reader.h
RowsetSharedPtr rowset() override { return std::dynamic_pointer_cast<Rowset>(_rowset); }

int64_t filtered_rows() override { return _stats->rows_del_filtered; }
int64_t filtered_rows() override { return _stats->rows_del_filtered + _stats->rows_conditions_filtered; }
Copy link
Contributor

@morningman morningman Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment for this method to notify that this method will be used for validation of schema change task, should be modified carefully.

Copy link
Contributor Author

@xinyiZzz xinyiZzz Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related comment have been added, I will be familiar with the development process again.

@xinyiZzz xinyiZzz force-pushed the olap_scan_node_profile_layering_fix_filter branch from 5db783e to 1eab493 Compare November 12, 2020 09:31
morningman
morningman approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added approved Indicates a PR has been approved by one committer. kind/fix Categorizes issue or PR as related to a bug. labels Nov 13, 2020
@morningman morningman merged commit aca9b2d into apache:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xinyiZzz @morningman